[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #26 from Katrin Fischer --- (In reply to David Roberts from comment #25) > I'm pretty sure that > > $overlay_framework = undef if $overlay_framework = '_USE_ORIG'; > > needs to be > > $overlay_framework = undef if

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Lucas Gass changed: What|Removed |Added Status|Pushed to stable|Needs documenting -- You are

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Phil Ringnalda changed: What|Removed |Added Blocks|33342 | Referenced Bugs:

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Phil Ringnalda changed: What|Removed |Added Blocks||33342 Referenced Bugs:

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Blocks||33412 Referenced Bugs:

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #24 from Holly --- *** Bug 24843 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #22 from Jacob O'Mara --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Jacob O'Mara changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.03

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #21 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal -- You are

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #20 from Nick Clemens --- Created attachment 145406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145406=edit Bug 15869: (QA follow-up) Don't pass placeholder framework '_USE_ORIG' This param in the

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #19 from Kyle M Hall --- Created attachment 145274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145274=edit Bug 15869: (QA follow-up) Add some padding around the pulldowns Signed-off-by: Kyle M Hall

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #18 from Kyle M Hall --- Created attachment 145273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145273=edit Bug 15869: (follow-up) Don't mock undef return value Signed-off-by: Kyle M Hall -- You

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #17 from Kyle M Hall --- Created attachment 145272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145272=edit Bug 15869: Unit test Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall --

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Kyle M Hall changed: What|Removed |Added Attachment #142257|0 |1 is obsolete|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #15 from Nick Clemens --- Created attachment 143033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143033=edit Bug 15869: (follow-up) Don't mock undef return value -- You are receiving this mail

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #14 from Katrin Fischer --- There is a new warning in the output of the unit test with this patch set applied: t/db_dependent/ImportBatch.t .. 9/19 Use of uninitialized value $item_result in string eq at

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 ByWater Sandboxes changed: What|Removed |Added Attachment #140858|0 |1 is obsolete|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 ByWater Sandboxes changed: What|Removed |Added Attachment #140857|0 |1 is obsolete|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #11 from Nick Clemens --- Created attachment 140858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140858=edit Bug 15869: Unit test -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Attachment #77018|0 |1 is obsolete|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #9 from Andrew Fuerste-Henry --- +1, this would be handy! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth.

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Katrin Fischer changed: What|Removed |Added Keywords|Academy | -- You are receiving

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #8 from Nick Clemens --- Patches updated just to see. I think the condition was right (it is checking if there are two variables left in the parameters) but agree it is ugly - changed to take a hash It still needs unit

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Attachment #70800|0 |1 is obsolete|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 emj...@pa.net changed: What|Removed |Added CC||emj...@pa.net --- Comment

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Jessie Zairo changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Attachment #55543|0 |1

[Koha-bugs] [Bug 15869] Change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Katrin Fischer changed: What|Removed |Added Summary|change framework on overlay

[Koha-bugs] [Bug 15869] change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 15869] change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Katrin Fischer changed: What|Removed |Added Keywords|

[Koha-bugs] [Bug 15869] change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15869] change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 Nick Clemens changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 15869] change framework on overlay

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869 --- Comment #1 from Nick Clemens --- Created attachment 55543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55543=edit Bug 15869 - change framework on overlay This patch allows for