[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #27 from Katrin Fischer  ---
I feel this has been resolved by bug 23767 in a way.

*** This bug has been marked as a duplicate of bug 23767 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Andrew Fuerste-Henry  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26878

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Benjamin Daeuber  changed:

   What|Removed |Added

 CC||bdaeu...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #26 from Katrin Fischer  ---
Created attachment 98622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98622=edit
With patch applied

Makes sense to me, but the totals could be a little confusing when comparing to
coumn entries (formatting) and the 'Total available' total is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23767
 Status|Signed Off  |In Discussion

--- Comment #25 from Katrin Fischer  ---
I found this after having tested bug 23767 earlier and I think we should think
about merging both bugs in a way - they deal with very similar problems. I will
move both to 'in Discussion' meaning that I hope you can talk to each other and
figure out the best way to move those 2 forward!

1) I notice the removal of the "Total available" here. I think this is one of
the things libraries really look at - would it be possible to add it back?

2) Also in my case I have the following:

Parent fund, spent: 0,00
Sub fund, spent: 2,00

For Total spent: It shows on both parent and sub fund level, adding up to 2
still. = OK

For Base-level spent: 2,00 shows, but is added up to 0,00 Total.

So... the totals are quite confusing:
2+2 = 2
2+0 = 0

As it's the same we display on budget, maybe adopting the "italic" formatting
from the budgets page could help a little here. 

Attaching a screnshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Katrin Fischer  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #24 from Katrin Fischer  ---
*** Bug 15659 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #23 from sandbo...@biblibre.com  ---
Created attachment 93747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93747=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 | Book
 |_ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 
I tested the functionality and it works as expected. It also passes the QA
script.
It basically adds 'base-level' information to the acquisitions page. The only
difference
with what is displayed on the funds page is that it doesn't add the base-level
available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the
funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow
exactly as
the funds table.

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #84094|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #22 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

 CC||jose-mario.monteiro-santos@
   ||inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

  Attachment #64659|0   |1
is obsolete||

--- Comment #21 from José-Mario Monteiro-Santos 
 ---
Created attachment 84094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84094=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 | Book
 |_ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 
I tested the functionality and it works as expected. It also passes the QA
script.
It basically adds 'base-level' information to the acquisitions page. The only
difference
with what is displayed on the funds page is that it doesn't add the base-level
available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the
funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow
exactly as
the funds table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Charles Farmer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA
 CC||charles.far...@inlibro.com

--- Comment #20 from Charles Farmer  ---
Doesn't apply, will submit rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #19 from J Schmidt  ---
Hello,
I finally had the chance to come back to this today. Thank you Katrin as I
believe I have made changes to staff permissions to successfully limit the
viewing of non-home library budgets. Appreciated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #18 from Koha Team Lyon 3  ---
Hello,
we are not using child fund in my library so we aren't really concerned. But,
if the table is less compact than before it's still acceptable for me.
More opinion from librarians using child fund would be better than my reply on
this one..

But, concerning the discussion between Katrin and Jen, in my library, we need
to see funds from all branches on acq-home page. I'm agree with Katrin, it's
possible to change the display of acq-home page according to user permissions
and fund setting.

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #17 from Katrin Fischer  ---
Hi Jen, take a look at comment#13 especially:
- make sure the user you are testing with has neither budget_manage_all nor
superlibrarian permission. They will have budget_manage_all if they have full
acq permissions, so you might have to uncheck it.
- go to the funds configuration page for the rest.
Good luck!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #16 from J Schmidt  ---
Hello Katrin, I hope this is possible. I don't mind being corrected. Just to
clarify, one branch library wants to ONLY view their own budget from the
acqui/acqui-home.pl screen. ... not any other libraries' budgets or funds (with
dollar amounts)... I am not seeing  any permissions where one can manage and
view only their library's budget... I'll double check to see if the one branch
I'm looking at today has a proper total at the bottom given how I'm logged in
(as that same branch). Maybe the total at the bottom is correct for the branch
EVEN THOUGH I can view the other budgets in the table as a whole. That's
possible. thanks. jen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #15 from Katrin Fischer  ---
(In reply to J Schmidt from comment #14)
> Basically our group is still interested. We want a subtotal per branch's
> budget on the acqui-home.pl page. Right now the total at the bottom isn't
> calculated correctly and is including multiple branches and their
> budgets.Staff are able to view funds and dollar amounts tied to funds
> for any library's budget. There are permission restrictions at the point of
> ordering and editing. However, the viewing of budget information on a few
> Koha Acq pages still remains.  Thanks. jls.

Please don't misunderstand my comments, I am trying to help, because I think
what you describe might already be possible without these patches. I have just
run tests on master with 1 budget and 2 funds for different libraries. When I
set the permissions so I only see the fund of my library, then the Total is
correctly calculated to only include the funds visible to me. So I guess I am
missing something and I would like to understand.

But as this is kind of a separate discussion from this bug, we should probably
move it onto a different bug report. Would you be willing to write it up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #14 from J Schmidt  ---
Basically our group is still interested. We want a subtotal per branch's budget
on the acqui-home.pl page. Right now the total at the bottom isn't calculated
correctly and is including multiple branches and their budgets.Staff are
able to view funds and dollar amounts tied to funds for any library's budget.
There are permission restrictions at the point of ordering and editing.
However, the viewing of budget information on a few Koha Acq pages still
remains.  Thanks. jls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #13 from Katrin Fischer  ---

> Our consortium had requested this development.  The libraries are accustomed
> to not being able to see each other's budgets and actually dollar amounts..I
> believe that falls outside the scope of this bug but I'll reiterate that it
> would be great and would consolidate the amount of information on the
> /koha/acqui/acqui-home.pl screen if the budget displaying was only for
> whichever branch library is logged in... (Tied to the staff login)... The
> more direct response/comment I'll make is that our staff would like the
> amounts for all funds summed on that acqui-home.pl page for the active
> budget... This is especially useful right now as we have one library's
> budget in a table directly followed by another branch's active budget and it
> would be nice to break up the table with a SUM for each budget This
> remains a desire of our library system. Thanks. jenschmidt~

To not see another libraries funds on the start page:
- Make sure user does have neither superlibrarian or budget_manage_all
permission
- Make sure each fund has a library set and is restricted to: owner, users and
library
The user will only see their home branches funds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #12 from Katrin Fischer  ---
Hm, it's already possible to control visibility with the permissions on fund
level. You can especially limit to the home library of the patron.

I think restricting to only the library you are logged in at is too general and
would not work for every library system. There are setups where a main library
orders for all others. This should be configurable, but we already have a
complicated permission system on the funds. I feel like we should not make it
more complicated.

Hiding columns/cells is often not really possible when datatables are used -
this table is getting more and more complicated. So even if there are ids, it's
not always easy to make it work.

I feel we should have a clear concept about what is the difference (or not)
between the one on acq home page and the one on the funds page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

--- Comment #11 from J Schmidt  ---
(In reply to Kyle M Hall from comment #10)
> (In reply to Tomás Cohen Arazi from comment #9)
> > (In reply to Jonathan Druart from comment #8)
> > > (In reply to Tomás Cohen Arazi from comment #7)
> > > > So the table is more compact and easy to follow.
> > > 
> > > Well not really, it is less compact than before.
> > 
> > I meant it was more compact than the funds one. Of course it is adding
> > columns to the original one! hehe
> > 
> > > I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See
> > > comments 5 & 6).
> > 
> > Yeah, I think it is important to listen to interested parties. My feeling is
> > that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if
> > it was just duplicating the funds one, I think it is worth doing.
> 
> I agree with Tomas. In addition table columns can always be hidden with css
> as link as they are IDed/classed properly. I don't think you'll every find a
> library that strongly expressed how this table has too much data ; )

Our consortium had requested this development.  The libraries are accustomed to
not being able to see each other's budgets and actually dollar amounts..I
believe that falls outside the scope of this bug but I'll reiterate that it
would be great and would consolidate the amount of information on the
/koha/acqui/acqui-home.pl screen if the budget displaying was only for
whichever branch library is logged in... (Tied to the staff login)... The more
direct response/comment I'll make is that our staff would like the amounts for
all funds summed on that acqui-home.pl page for the active budget... This is
especially useful right now as we have one library's budget in a table directly
followed by another branch's active budget and it would be nice to break up the
table with a SUM for each budget This remains a desire of our library
system. Thanks. jenschmidt~

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
(In reply to Tomás Cohen Arazi from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > (In reply to Tomás Cohen Arazi from comment #7)
> > > So the table is more compact and easy to follow.
> > 
> > Well not really, it is less compact than before.
> 
> I meant it was more compact than the funds one. Of course it is adding
> columns to the original one! hehe
> 
> > I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See
> > comments 5 & 6).
> 
> Yeah, I think it is important to listen to interested parties. My feeling is
> that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if
> it was just duplicating the funds one, I think it is worth doing.

I agree with Tomas. In addition table columns can always be hidden with css as
link as they are IDed/classed properly. I don't think you'll every find a
library that strongly expressed how this table has too much data ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #9 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Tomás Cohen Arazi from comment #7)
> > So the table is more compact and easy to follow.
> 
> Well not really, it is less compact than before.

I meant it was more compact than the funds one. Of course it is adding columns
to the original one! hehe

> I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See
> comments 5 & 6).

Yeah, I think it is important to listen to interested parties. My feeling is
that the 'compact' one (a.k.a. 'the original') is not useful at all. Even if it
was just duplicating the funds one, I think it is worth doing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion
 CC||nicolas.legr...@bulac.fr,
   ||severine.que...@bulac.fr,
   ||sonia.bo...@univ-lyon3.fr

--- Comment #8 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #7)
> So the table is more compact and easy to follow.

Well not really, it is less compact than before.

I'd like more opinions on this one, Nicolas, Séverine or Sonia maybe (See
comments 5 & 6).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #51931|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 64659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64659=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 | Book
 |_ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 
I tested the functionality and it works as expected. It also passes the QA
script.
It basically adds 'base-level' information to the acquisitions page. The only
difference
with what is displayed on the funds page is that it doesn't add the base-level
available
amounts. So the table is more compact and easy to follow.

I think this is a useful enhancement even if it makes this table closer to the
funds one.
I checked it totalizes correctly on each scenario and respects the acq workflow
exactly as
the funds table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #6 from Katrin Fischer  ---
Created attachment 55811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55811=edit
Screenshot of proposed change to the table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #5 from Katrin Fischer  ---
Created attachment 55810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55810=edit
Screenshot of current table on acq start page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
I've added this bug to the next dev meeting's agenda.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I think that the goal of this table (on the acq home page) was to display a
simplified version of the table on the "all funds" view.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Marc Véron  changed:

   What|Removed |Added

  Attachment #50438|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 51931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51931=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 | Book
 |_ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

--- Comment #1 from Rémi Mayrand-Provencher 
 ---
Created attachment 50438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50438=edit
Bug 16126 - Display base-level amounts on the acquisition module home page

This patch will display on the acquisition module home page the information
already displayed on the "manage fund" page (aqbudgets.pl).

Currently, Koha display the base-level amounts only.

This patch will :

1. rename the column "ordered", "spent" and "available" to "base-level
[ordered|spent|available]"

2. add the column "ordered", "spent" and available with the same calculation
from the "manage fund" page.

TEST PLAN :

1. Go to the Administration module
2. Add a new budget (ie : Budget 2016)
3. Add a fund to this budget (ie : Book)
4. Add a child fund (ie : Adult fiction)

You will have this hierarchy :

Budget 2016
 | Book
 |_ Adult fiction

5. Go to the Acquisition module
6. Place an order and use the "Adult fiction" budget
7. Go back the Acquisition home page and compare the table with the table from
the aqbudgets.pl page (Administration > Budget > Fund)
8. You will see :

BEFORE PATCH :
the base level amounts only

AFTER PATCH :
the base level and the total amounts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |remi.mayrand-provencher@inL
   |ity.org |ibro.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 CC||remi.mayrand-provencher@inL
   ||ibro.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/