[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|Oldversions |---

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||24761


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24761
[Bug 24761] Caching issues in scripts running in daemon mode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Mason James  changed:

   What|Removed |Added

 Blocks|17189   |
 Depends on||17189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189
[Bug 17189] Add the ability to define several memcached namespaces
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Mason James  changed:

   What|Removed |Added

 Blocks||17189
 Depends on|17189   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189
[Bug 17189] Add the ability to define several memcached namespaces
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Mason James  changed:

   What|Removed |Added

 Depends on||17189


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17189
[Bug 17189] Add the ability to define several memcached namespaces
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #19 from Mason James  ---
Pushed to 16.05.x, for 16.05.13 release

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #18 from Katrin Fischer  ---
These patches have been pushed to 16.11.x and will be in 16.11.08.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #17 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jacek, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #16 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #12)
> Why do you get the "syspref" cache instance?
> I guess there is no reason, I'd suggest to remove it and retrieve the
> default one.

When rebuild_zebra.pl starts, it immediately initialises all 3 instances
(config, syspref and default - in that order), so it probably doesn't matter
much which one is used for checking if memcached is in use or not in use. Bug
18250 seems to be a bigger issue (possibility that zebra_daemon gets started
before memcached is up and running). Overall, I don't think this is such a
major issue for zebra daemon right now, because by a look of it,
rebuild_zebra.pl uses very limited set of cached values, and predominantly (if
not only) such kinds of values that are never changed in the production
systems, like:

   syspref_cas* (due to BEGIN block in Auth.pm), syspref_marcflavour,
syspref_includeseefrominsearches

It fetches repeatedly MarcSubfieldStructure-* from default cache instance, but
I think it's mostly used for determining tag numbers (item tag number,
biblio/biblioitem tag number), which don't change very often (if ever) in the
production environments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18250

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #15 from Jonathan Druart  
---
Created attachment 63248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63248=edit
Bug 16758: Use the default cache instance

I do not see a valid reason not to use the default one instead of the
syspref one.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61820|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  
---
Created attachment 63247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63247=edit
Bug 16758 - Caching issues in scripts running in daemon mode

As L1 cache does not have expiration mechanism, scripts running
in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would
not be aware of any possible changes in the data being cached
in upstream L2 cache.

This patch adds ->flush_L1_caches() call in rebuild_zebra.pl
inside daemon mode loop.

To test:

1) apply patch
2) ensure that rebuild_zebra.pl -daemon is still working properly,
without any noticeable performance degradation
3) stop memcached daemon and try to run rebuild_zebra.pl -daemon
again: there should be a warning emitted stating that the script
is running in daemon mode but without recommended caching system

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #13 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #12)
> Why do you get the "syspref" cache instance?
> I guess there is no reason, I'd suggest to remove it and retrieve the
> default one.

Jacek,
It would be great to have this one into 17.05, can you answer please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #12 from Jonathan Druart  
---
Why do you get the "syspref" cache instance?
I guess there is no reason, I'd suggest to remove it and retrieve the default
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Josef Moravec  changed:

   What|Removed |Added

  Attachment #60858|0   |1
is obsolete||

--- Comment #11 from Josef Moravec  ---
Created attachment 61820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61820=edit
[SIGNED-OFF] Bug 16758 - Caching issues in scripts running in daemon mode

As L1 cache does not have expiration mechanism, scripts running
in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would
not be aware of any possible changes in the data being cached
in upstream L2 cache.

This patch adds ->flush_L1_caches() call in rebuild_zebra.pl
inside daemon mode loop.

To test:

1) apply patch
2) ensure that rebuild_zebra.pl -daemon is still working properly,
without any noticeable performance degradation
3) stop memcached daemon and try to run rebuild_zebra.pl -daemon
again: there should be a warning emitted stating that the script
is running in daemon mode but without recommended caching system

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17311

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Marcel de Rooy  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
   Patch complexity|Trivial patch   |Small patch

--- Comment #10 from Marcel de Rooy  ---
(In reply to Jacek Ablewicz from comment #5)
> BTW, I'm wondering what is an order of starting koha-common && memcached in
> debian packaged installs? If on server reboot indexer daemon gets started
> before memcached is up and running, it will default to Cache::Memory as
> well, even if the MEMCACHED_* variables are set up properly.

In my rc5.d I have:
S01koha-common
S03memcached

So yes, koha-common (including indexer, sip) starts before memcached. I added a
debug print in get_instance and saw a few lines with Cache::Memory in the logs
when rebooting.

We probably should use update-rc.d to lower the priority of koha-common in the
Debian package install.

Patch complexity is definitely not trivial ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #9 from Marcel de Rooy  ---
Simple rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #55564|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 60858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60858=edit
Bug 16758 - Caching issues in scripts running in daemon mode

As L1 cache does not have expiration mechanism, scripts running
in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would
not be aware of any possible changes in the data being cached
in upstream L2 cache.

This patch adds ->flush_L1_caches() call in rebuild_zebra.pl
inside daemon mode loop.

To test:

1) apply patch
2) ensure that rebuild_zebra.pl -daemon is still working properly,
without any noticeable performance degradation
3) stop memcached daemon and try to run rebuild_zebra.pl -daemon
again: there should be a warning emitted stating that the script
is running in daemon mode but without recommended caching system

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #7 from Jonathan Druart  
---
Increasing the severity as we need it in the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jacek Ablewicz  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #6 from Jacek Ablewicz  ---
Created attachment 55564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55564=edit
Bug 16758 - Caching issues in scripts running in daemon mode

As L1 cache does not have expiration mechanism, scripts running
in daemon mode (rebuild_zebra.pl -daemon, sip server ?, ...) would
not be aware of any possible changes in the data being cached
in upstream L2 cache.

This patch adds ->flush_L1_caches() call in rebuild_zebra.pl
inside daemon mode loop.

To test:

1) apply patch
2) ensure that rebuild_zebra.pl -daemon is still working properly,
without any noticeable performance degradation
3) stop memcached daemon and try to run rebuild_zebra.pl -daemon
again: there should be a warning emitted stating that the script
is running in daemon mode but without recommended caching system

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jacek Ablewicz  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #5 from Jacek Ablewicz  ---
(In reply to Jacek Ablewicz from comment #4)

> That should work fine IMO, without significant performance hit (as long as
> L2 is memcached).

But if L2 = Cache::Memory, this will be effectively just a null op.

This might happen e.g. if the caching system is not configured quite
consistently (due to MEMCACHED_* environment variables not exported by default
for system & maintenance scripts). I'm not sure if it's still an issue for
packaged debian installs or not (AFAIRC it was an issue at least in 3.22.*
about 4 months ago).

BTW, I'm wondering what is an order of starting koha-common && memcached in
debian packaged installs? If on server reboot indexer daemon gets started
before memcached is up and running, it will default to Cache::Memory as well,
even if the MEMCACHED_* variables are set up properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #4 from Jacek Ablewicz  ---
(In reply to Jonathan Druart from comment #3)
> Something like:
> 
> @@ -242,6 +243,7 @@ my $tester = XML::LibXML->new();
>  if ($daemon_mode) {
>  while (1) {
>  # For incremental updates, skip the update if the updates are locked
> +Koha::Cache->flush_L1_cache;
>  if (_flock($LockFH, LOCK_EX|LOCK_NB)) {
>  do_one_pass() if ( zebraqueue_not_empty() );
>  _flock($LockFH, LOCK_UN);
> 
> (+ use Koha::Cache)

That should work fine IMO, without significant performance hit (as long as L2
is memcached). Or maybe:

   - do_one_pass() if ( zebraqueue_not_empty() );
   + if ( zebraqueue_not_empty() ) {
   + Koha::Cache->flush_L1_cache;
   + do_one_pass();
   + }

would be a bit better (no need to clear the cache at each and every pass if
there is nothing to reindex).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

--- Comment #3 from Jonathan Druart  
---
Something like:

@@ -242,6 +243,7 @@ my $tester = XML::LibXML->new();
 if ($daemon_mode) {
 while (1) {
 # For incremental updates, skip the update if the updates are locked
+Koha::Cache->flush_L1_cache;
 if (_flock($LockFH, LOCK_EX|LOCK_NB)) {
 do_one_pass() if ( zebraqueue_not_empty() );
 _flock($LockFH, LOCK_UN);

(+ use Koha::Cache)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
(In reply to Jacek Ablewicz from comment #0)
> I wonder what would be a best approach for solving this issue for
> perpetually running scripts? Maybe just adding a function to Koha::Cache
> which flushes L1 cache (but not more often then each 10 | 20 | 30 seconds),
> and call it in rebuild_zebra.pl etc. daemon loop  - ?

That sounds good to me.
What about flushing it before each run (in case of rebuild_rebra)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #1 from Tomás Cohen Arazi  ---

I think daemon scripts like this should have L1 disabled. If someone comes up
with a proper caching solution for this, then have an enhancement bug. We
should provide fixes for this on the stable releases, instead of backporting
really complex architectural changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16758] Caching issues in scripts running in daemon mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16758

Jacek Ablewicz  changed:

   What|Removed |Added

 Depends on||11998, 16044, 16190


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998
[Bug 11998] Syspref caching issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044
[Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16190
[Bug 16190] Enable the indexer daemon by default
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/