https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #72 from Fridolin Somers ---
Should we backported to 20.11.x ?
Or is it to much behavior change for a stable version ?
My opinion is more on no backport, reserves is really sensitive.
--
You are receiving this mail bec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #71 from Jonathan Druart
---
Follow-up pushed to master, thanks Nick!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #70 from Nick Clemens ---
Created attachment 120009
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120009&action=edit
Bug 16787: (follow-up) Add and adjust ILSDI tests
--
You are receiving this mail b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #69 from Jonathan Druart
---
We have a test failing, please fix.
# Failed test 'Too many reserves'
# at t/db_dependent/ILSDI_Services.t line 372.
# got: 'noReservesAllowed'
# expected: '
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #68 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #67)
> Pushed to master for 21.05, thanks to everybody involved!
Delayed for a bit.
--
You are receiving this mail because:
You are watching all b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #67 from Jonathan Druart
---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #66 from Nick Clemens ---
Created attachment 119942
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119942&action=edit
Bug 16787: (follow-up) Add noReservesAllowed to ERROR_MAP
--
You are receiving thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #65
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Martin Renvoize changed:
What|Removed |Added
Attachment #119623|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Martin Renvoize changed:
What|Removed |Added
Attachment #119621|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Martin Renvoize changed:
What|Removed |Added
Attachment #119620|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Martin Renvoize changed:
What|Removed |Added
Attachment #119619|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Owen Leonard changed:
What|Removed |Added
Attachment #119622|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #58 from Nick Clemens ---
Created attachment 119622
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119622&action=edit
Bug 16787: (follow-up) Fix check to ensure reasons are passed to template
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #57 from Owen Leonard ---
Created attachment 119621
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119621&action=edit
Bug 16787: DO NOT PUSH - Schema updates
Signed-off-by: Owen Leonard
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #56 from Owen Leonard ---
Created attachment 119620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119620&action=edit
Bug 16787: Add noReservesAllowed to club holds
Signed-off-by: Owen Leonard
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Owen Leonard changed:
What|Removed |Added
Attachment #119335|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Owen Leonard changed:
What|Removed |Added
Patch complexity|--- |Small patch
Stat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #54 from Owen Leonard ---
(In reply to Owen Leonard from comment #52)
> I see a difference in how the holds process behaves before and after this
> patch and I'm not sure it's intentional.
This is not a problem after al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #53 from Owen Leonard ---
Created attachment 119617
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119617&action=edit
Screenshot showing the behavior after the patch
After the patch, there is no warnin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #52 from Owen Leonard ---
Created attachment 119616
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119616&action=edit
Screenshot showing the behavior before the patch
I see a difference in how the hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #51 from Nick Clemens ---
Created attachment 119337
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119337&action=edit
Bug 16787: DO NOT PUSH - Schema updates
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #50 from Nick Clemens ---
Created attachment 119336
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119336&action=edit
Bug 16787: Add noReservesAllowed to club holds
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #119279|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #48 from Nick Clemens ---
Created attachment 119281
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119281&action=edit
Bug 16787: DO NOT PUSH - Schema updates
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #47 from Nick Clemens ---
Created attachment 119280
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119280&action=edit
Bug 16787: Add noReservesAllowed to club holds
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #114675|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Séverine Queune changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #44 from Nick Clemens ---
Created attachment 114677
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114677&action=edit
Bug 16787: DO NOT PUSH - Schema updates
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #43 from Nick Clemens ---
Created attachment 114676
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114676&action=edit
Bug 16787: Add noReservesAllowed to club holds
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #107793|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolutio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #40 from Nick Clemens ---
Created attachment 107795
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107795&action=edit
Bug 16787: DO NOT PUSH - Schema updates
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #39 from Nick Clemens ---
Created attachment 107794
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107794&action=edit
Bug 16787: Add noReservesAllowed to club holds
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #101473|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Sally changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Comment #37
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #36 from Victor Grousset/tuxayo ---
> 4 - The message will be 'Too many holds'
Is that valid if my messages are the following?
> Too many holds: $EXAMPLE $USER can only place a maximum of 0 total holds.
It's for the «i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #35 from Fridolin SOMERS ---
> This patch also fixes a FIXME about using effective_itemtype to fetch item
> rules
Looks like there are several places where GetBranchItemRule() is called with
$item->itype instead of $ite
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #34 from Fridolin SOMERS ---
Bug 23404 also fixed a itemtype issue in holds
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing lis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Fridolin SOMERS changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #101475|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Sally changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #31 from Nick Clemens ---
Created attachment 101475
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101475&action=edit
Bug 16787: DO NOT PUSH - Shcema changes
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #30 from Nick Clemens ---
Created attachment 101474
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101474&action=edit
Bug 16787: Add noReservesAllowed to club holds
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #99949|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #28 from Jonathan Druart
---
Adding the DBIC changes to help testing in a sandbox.
AM123, Lyon3, are you still interested in this bugfix?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #27 from Jonathan Druart
---
Created attachment 100951
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100951&action=edit
Bug 16787: DBIC changes
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #25 from Nick Clemens ---
Created attachment 99950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99950&action=edit
Bug 16787: Add noReservesAllowed to club holds
--
You are receiving this mail becaus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #97403|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #23 from Jonathan Druart
---
Looks like you will need to add the new statuses to the enum of
club_holds_to_patron_holds.error_code
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #96152|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #91146|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Benjamin Daeuber changed:
What|Removed |Added
CC||bdaeu...@cityoffargo.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
benjamin.r.philbr...@lmco.com changed:
What|Removed |Added
CC||benjamin.r.ph
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Hayley Mapley changed:
What|Removed |Added
CC||hayleymap...@catalyst.net.n
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #18 from Nick Clemens ---
Created attachment 91149
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91149&action=edit
Bug 16787: Rebase fixes and updates
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #16 from Nick Clemens ---
Created attachment 91147
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91147&action=edit
Bug 16787: Add tests
--
You are receiving this mail because:
You are watching all bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #17 from Nick Clemens ---
Created attachment 91148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91148&action=edit
Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record
To test:
1 - Se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #72827|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Koha Team Lyon 3 changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Koha Team Lyon 3 changed:
What|Removed |Added
CC||k...@univ-lyon3.fr
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Axelle Aix-Marseille Université changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #12 from Nick Clemens ---
Created attachment 72889
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72889&action=edit
Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record
To test:
1 - Se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Séverine Queune changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #68895|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Attachment #68894|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||victor.grous...@bib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Axelle Aix-Marseille Université changed:
What|Removed |Added
Status|Needs Signoff |Patch does
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #8 from Nick Clemens ---
(In reply to David Bourgault from comment #7)
> Is there a step missing form the test plan? I applied the patch, change my
> Circulation rules to set no holds for All/All (I have no other rules fo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
David Bourgault changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #6 from Jonathan Druart
---
Created attachment 68895
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68895&action=edit
Bug 16787: Add tests
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
Attachment #52652|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Hugh Rundle changed:
What|Removed |Added
CC||hu...@brimbank.vic.gov.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
Koha Team Lyon 3 changed:
What|Removed |Added
See Also||https://bugs.koha-communi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
George Williams (NEKLS) changed:
What|Removed |Added
CC||geo...@nekls.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #2 from Nick Clemens ---
needs unit tests
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing lis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787
--- Comment #1 from Nick Clemens ---
Created attachment 52652
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52652&action=edit
Bug 16787 - 'Too many holds' message appears inappropriately and is missing
data
This
100 matches
Mail list logo