[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825
Bug 16825 depends on bug 18137, which changed state.

Bug 18137 Summary: REST API: Migrate from Mojolicious::Plugin::Swagger2 to 
Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #64275|0   |1
is obsolete||
  Attachment #65007|0   |1
is obsolete||

--- Comment #35 from Lari Taskula  ---
Created attachment 67865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67865&action=edit
Bug 16825: Add API route for getting an item

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table has
a column "itemnotes_nonpublic", which should not be returned if the user has no
catalogue permission.

The OpacHiddenItems syspref restriction is considered for users who are not
staff.
They see "Item Not Found" when trying to view item hidden from OPAC. Only staff
can see those items.

To test:
1. Apply patch
2. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
3. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
4. Make sure the returned data is correct.
5. Run unit tests in t/db_dependent/api/v1/items.t

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #34 from Tomás Cohen Arazi  ---
Lari, the second patch doens't apply. Please rebase/fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-09-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Jonathan Druart  changed:

   What|Removed |Added

  Component|Web services|REST api
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-07-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #33 from Lari Taskula  ---
Created attachment 65007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65007&action=edit
Bug 16825: (squashable) Fix test cleanup issues

Roll back failed at the end of the test. Apply this patch to fix the issue.

To test:
1. prove t/db_dependent/api/v1/items.t
2. Check your database to make sure nothing persists after the test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #32 from Katrin Fischer  ---
Excluding itemnotes_nonpublic is good thinking, but what about other fields
that are set to not display in the OPAC in the frameworks?

I know we got some libraries using more_subfields_xml to store additional
information that is not for thought to be seen by normal users.
I think those should only show if you have catalogue permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-06-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61176|0   |1
is obsolete||

--- Comment #31 from Josef Moravec  ---
Created attachment 64275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64275&action=edit
[SIGNED-OFF] Bug 16825: Add API route for getting an item

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table has
a column "itemnotes_nonpublic", which should not be returned if the user has no
catalogue permission.

The OpacHiddenItems syspref restriction is considered for users who are not
staff.
They see "Item Not Found" when trying to view item hidden from OPAC. Only staff
can see those items.

To test:
1. Apply patch
2. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
3. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
4. Make sure the returned data is correct.
5. Run unit tests in t/db_dependent/api/v1/items.t

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-06-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #30 from Lari Taskula  ---
(In reply to Lari Taskula from comment #29)
> Rewritten, now Mojolicious::Plugin::OpenAPI compatible.

Forgot to include this in the previous comment - Additional note for testers:
requires JSON::Validator version 0.96, otherwise tests fail for the following
reason: 

GET /api/v1/items/340856 [{"message":"Does not match date-time
format.","path":"\/timestamp"},{"message":"anyOf failed: Does not match
date-time format.","path":"\/itemlost_on"},{"message":"anyOf failed: Does not
match date-time format.","path":"\/withdrawn_on"}].

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #29 from Lari Taskula  ---
Rewritten, now Mojolicious::Plugin::OpenAPI compatible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56293|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 Depends on|15126   |18137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
[Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56290|0   |1
is obsolete||

--- Comment #28 from Lari Taskula  ---
Created attachment 61176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61176&action=edit
Bug 16825: Add API route for getting an item

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table has
a column "itemnotes_nonpublic", which should not be returned if the user has no
catalogue permission.

The OpacHiddenItems syspref restriction is considered for users who are not
staff.
They see "Item Not Found" when trying to view item hidden from OPAC. Only staff
can see those items.

To test:
1. Apply patch
2. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
3. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
4. Make sure the returned data is correct.
5. Run unit tests in t/db_dependent/api/v1/items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191
[Bug 18191] REST API: Add endpoint to list valid pickup locations
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |lari.task...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56133|0   |1
is obsolete||

--- Comment #26 from Lari Taskula  ---
Created attachment 56293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56293&action=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #27 from Lari Taskula  ---
Removed minifying step from test plan after Bug 17432.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56124|0   |1
is obsolete||

--- Comment #25 from Lari Taskula  ---
Created attachment 56292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56292&action=edit
Bug 16825: (followup) Add API route for getting an item

Signed-off-by: Jiri Kozlovsky 
Signed-off-by: Benjamin Rokseth 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56123|0   |1
is obsolete||

--- Comment #24 from Lari Taskula  ---
Created attachment 56290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56290&action=edit
Bug 16825: Add API route for getting an item

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table has
a column "itemnotes_nonpublic", which should not be returned if the user has no
catalogue permission.

To test:
1. Apply patch
2. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
3. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
4. Make sure the returned data is correct.
5. Run unit tests in t/db_dependent/api/v1/items.t

Signed-off-by: jirislav 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56131|0   |1
is obsolete||

--- Comment #23 from Lari Taskula  ---
Created attachment 56133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56133&action=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that test fails because of missing new_status.
3. Apply patch and test again
4. Observe that test no longer complains about new_status.

(minify swagger)
perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d
api/v1/swagger/swagger.min.json

Signed-off-by: Jiri Kozlovsky 

Fixed a typo in minifying command.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56125|0   |1
is obsolete||

--- Comment #22 from Lari Taskula  ---
Created attachment 56131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56131&action=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #21 from Lari Taskula  ---
Rebased on top of master and added Swagger-minifying into test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #54687|0   |1
is obsolete||

--- Comment #20 from Lari Taskula  ---
Created attachment 56125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56125&action=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. Observe that test fails because of missing new_status.
3. Apply patch and test again
4. Observe that test no longer complains about new_status.

(minify swagger)
perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d
api/v1/swagger

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56122|0   |1
is obsolete||

--- Comment #18 from Lari Taskula  ---
Created attachment 56123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56123&action=edit
Bug 16825: Add API route for getting an item

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table has
a column "itemnotes_nonpublic", which should not be returned if the user has no
catalogue permission.

To test:
1. Apply patch and run minifySwagger.pl
   perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d
api/v1/swagger/swagger.min.json
2. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
3. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
4. Make sure the returned data is correct.
5. Run unit tests in t/db_dependent/api/v1/items.t

Signed-off-by: jirislav 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #54686|0   |1
is obsolete||

--- Comment #19 from Lari Taskula  ---
Created attachment 56124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56124&action=edit
Bug 16825: (followup) Add API route for getting an item

Signed-off-by: Jiri Kozlovsky 
Signed-off-by: Benjamin Rokseth 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #53222|0   |1
is obsolete||

--- Comment #17 from Lari Taskula  ---
Created attachment 56122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56122&action=edit
Bug 16825: Add API route for getting an item

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table has
a column "itemnotes_nonpublic", which should not be returned if the user has no
catalogue permission.

To test:
1. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
2. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
3. Make sure the returned data is correct.
4. Run unit tests in t/db_dependent/api/v1/items.t

Signed-off-by: jirislav 
Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-09-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825
Bug 16825 depends on bug 15126, which changed state.

Bug 15126 Summary: REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2016-08-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

Summary|Add API route for getting   |REST API: Add API route for
   |an item |getting an item

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/