[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #61 from Martin Renvoize  ---
We add a 'get_availability' API in bug 23336.  It was initially inspired by the
work in the aforementioned plugin, however the scope was narrowed.. It would be
great to continue that work to clean up the availability calculations and
migrate them into Koha:: namespace asap.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #60 from David Cook  ---
(In reply to Katrin Fischer from comment #59)
> How did it go?

I've had a few issues with the plugin, but Ere and I have worked on them. 

Overall, I don't have anyone actively using the integration I was working on
that needed the plugin, so it hasn't advanced since May/June.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #59 from Katrin Fischer  ---
(In reply to David Cook from comment #58)
> (In reply to David Cook from comment #55)
> > I'd love to revisit this.
> > 
> > For now, I'm planning to look at
> > https://github.com/NatLibFi/koha-plugin-rest-di since the folk in Finland
> > have been kind enough to make their work available there!
> 
> I've just been talking to Ere on Zoom. I'm going to use the plugin API for
> now while I do a demo for a library, and if that goes well, then I'd be
> interested in working with Ere and anyone else (Tomas? Martin?) who want to
> help move this into core Koha.

How did it go?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #58 from David Cook  ---
(In reply to David Cook from comment #55)
> I'd love to revisit this.
> 
> For now, I'm planning to look at
> https://github.com/NatLibFi/koha-plugin-rest-di since the folk in Finland
> have been kind enough to make their work available there!

I've just been talking to Ere on Zoom. I'm going to use the plugin API for now
while I do a demo for a library, and if that goes well, then I'd be interested
in working with Ere and anyone else (Tomas? Martin?) who want to help move this
into core Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #57 from David Cook  ---
(In reply to Martin Renvoize from comment #56)
> I took a short cut to add an availability endpoint in bug 23336 but I'd love
> to see a more thorough treatment done longer term. The availability code
> needs a cleanup along the lines of what NatLibFi do I believe but I didn't
> have the sponsorship to go the distance that way.

I've been wondering a bit if the word "availability" means different things to
different people as well. 

For me, I'm interested in the "Status" message that we see on the OPAC. Is that
the same thing needed for the checkout or is it a bit different?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #56 from Martin Renvoize  ---
I took a short cut to add an availability endpoint in bug 23336 but I'd love to
see a more thorough treatment done longer term. The availability code needs a
cleanup along the lines of what NatLibFi do I believe but I didn't have the
sponsorship to go the distance that way.

Happy to help though

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #55 from David Cook  ---
I'd love to revisit this.

For now, I'm planning to look at
https://github.com/NatLibFi/koha-plugin-rest-di since the folk in Finland have
been kind enough to make their work available there!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23336

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Arthur Suzuki  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |arthur.suz...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #54 from Julian Maurice  ---
*** Bug 13927 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

   Assignee|lari.task...@hypernova.fi   |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #53 from Lari Taskula  ---
I'm no longer able to work on this, so I'm setting assignee to default. Feel
free to continue this work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Blocks||23449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23449
[Bug 23449] Get available pickup locations from REST API
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #52 from Nick Clemens  ---
HI Lari, I just wanted to mention bug 21116 - tcohen worked on this as a way of
prototyping new endpoints so the structures could be worked out a bit more
before adding them to Koha - might be useful here or elsewhere

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #51 from Tomás Cohen Arazi  ---
(In reply to Julian Maurice from comment #50)
> (In reply to Tomás Cohen Arazi from comment #49)
> > I don't agree with the proposed endpoints layout. I belive we should have
> > /items/{item_id}/availability instead.
> > 
> > The ->swaggerize methods aren't needed anymore as Koha::Object(s) implement
> > the TO_JSON method with similar behaviour. This was obviously written before
> > the TO_JSON addition.
> 
> Looks like it's Failed QA then ?

Yes.

> Also, it would be nice to have more opinions on what the endpoints should be
> (/availability/object vs /object/availability)

I agree! It really depends on how it is going to be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #50 from Julian Maurice  ---
(In reply to Tomás Cohen Arazi from comment #49)
> I don't agree with the proposed endpoints layout. I belive we should have
> /items/{item_id}/availability instead.
> 
> The ->swaggerize methods aren't needed anymore as Koha::Object(s) implement
> the TO_JSON method with similar behaviour. This was obviously written before
> the TO_JSON addition.

Looks like it's Failed QA then ?

Also, it would be nice to have more opinions on what the endpoints should be
(/availability/object vs /object/availability)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Jonathan Druart  changed:

   What|Removed |Added

  Component|Web services|REST api
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #49 from Tomás Cohen Arazi  ---
I don't agree with the proposed endpoints layout. I belive we should have
/items/{item_id}/availability instead.

The ->swaggerize methods aren't needed anymore as Koha::Object(s) implement the
TO_JSON method with similar behaviour. This was obviously written before the
TO_JSON addition.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Jiri Kozlovsky  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #48 from Jiri Kozlovsky  ---
Changing this to Needs Sign-off (I can see no discussion in here)

Btw Lari, nice job !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #47 from Lari Taskula  ---
Created attachment 62727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62727=edit
Bug 16826: (follow-up, squashable) Remove warnings

Squash to Swaggerize Koha::Availability objects

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60219|0   |1
is obsolete||

--- Comment #46 from Lari Taskula  ---
Created attachment 60269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60269=edit
Bug 16826: Controllers for availability

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

Includes API tests.

To test:
1. prove t/db_dependent/api/v1/availability.t
2. Use Swagger-UI or make direct GET requests to specified availability
   endpoints, and make sure the returned data looks ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60156|0   |1
is obsolete||

--- Comment #45 from Lari Taskula  ---
Created attachment 60268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60268=edit
Bug 16826: Swaggerize Koha::Availability objects

Koha::Biblio::Availability->swaggerize
Koha::Item::Availability->swaggerize

Constructs a HASHref that contains all availability data to be returned in a
JSON
object. Numifies numbers to be numbers instead of strings. E.g. biblio
swaggerize

{
  "biblionumber": 1234,
  "availability": {
"available": true,
"notes": {
  "Patron::SomethingToNote": {
"cool": 1
  }
}
  },
  "item_availabilities": [
{
  "itemnumber": 5678,
  "availability": {
"available": false,
"unavailabilities": {
  "Item::Withdrawn": {}
}
  }
}
  ]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60155|0   |1
is obsolete||

--- Comment #44 from Lari Taskula  ---
Created attachment 60267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60267=edit
Bug 16826: Availability Swagger definitions

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60218|0   |1
is obsolete||

--- Comment #43 from Lari Taskula  ---
Created attachment 60219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60219=edit
Bug 16826: Controllers for availability

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

Includes API tests.

To test:
1. prove t/db_dependent/api/v1/availability.t
2. Use Swagger-UI or make direct GET requests to specified availability
   endpoints, and make sure the returned data looks ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #60157|0   |1
is obsolete||

--- Comment #42 from Lari Taskula  ---
Created attachment 60218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60218=edit
Bug 16826: Controllers for availability

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

Includes API tests.

To test:
1. prove t/db_dependent/api/v1/availability.t
2. Use Swagger-UI or make direct GET requests to specified availability
   endpoints, and make sure the returned data looks ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Blocks||18103


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18103
[Bug 18103] REST API: Add endpoint for patron status / blocks
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58457|0   |1
is obsolete||

--- Comment #40 from Lari Taskula  ---
Created attachment 60156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60156=edit
Bug 16826: Swaggerize Koha::Availability objects

Koha::Biblio::Availability->swaggerize
Koha::Item::Availability->swaggerize

Constructs a HASHref that contains all availability data to be returned in a
JSON
object. Numifies numbers to be numbers instead of strings. E.g. biblio
swaggerize

{
  "biblionumber": 1234,
  "availability": {
"available": true,
"notes": {
  "Patron::SomethingToNote": {
"cool": 1
  }
}
  },
  "item_availabilities": [
{
  "itemnumber": 5678,
  "availability": {
"available": false,
"unavailabilities": {
  "Item::Withdrawn": {}
}
  }
}
  ]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58458|0   |1
is obsolete||

--- Comment #41 from Lari Taskula  ---
Created attachment 60157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60157=edit
Bug 16826: Controllers for availability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #58456|0   |1
is obsolete||

--- Comment #39 from Lari Taskula  ---
Created attachment 60155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60155=edit
Bug 16826: Availability Swagger definitions

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #38 from Lari Taskula  ---
I added Bug 17712 as a dependency and attached new patches that use
Koha::Availabiltiy to provide more detailed availability answer via REST API. I
also marked the old patches obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57369|0   |1
is obsolete||
  Attachment #57382|0   |1
is obsolete||

--- Comment #37 from Lari Taskula  ---
Created attachment 58458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58458=edit
Bug 16826: Controllers for availability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Depends on|13903   |17712
 Blocks|17712   |
 Status|ASSIGNED|In Discussion


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903
[Bug 13903] Add API routes to list, create, update, delete holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712
[Bug 17712] Move availability calculation to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #36 from Lari Taskula  ---
Created attachment 58457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58457=edit
Bug 16826: Swaggerize Koha::Availability objects

Koha::Biblio::Availability->swaggerize
Koha::Item::Availability->swaggerize

Constructs a HASHref that contains all availability data to be returned in a
JSON
object. Numifies numbers to be numbers instead of strings. E.g. biblio
swaggerize

{
  "biblionumber": 1234,
  "availability": {
"available": true,
"notes": {
  "Patron::SomethingToNote": {
"cool": 1
  }
}
  },
  "item_availabilities": [
{
  "itemnumber": 5678,
  "availability": {
"available": false,
"unavailabilities": {
  "Item::Withdrawn": {}
}
  }
}
  ]
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #35 from Lari Taskula  ---
Created attachment 58456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58456=edit
Bug 16826: Availability Swagger definitions

GET /availability/biblio/hold
GET /availability/biblio/search
GET /availability/item/checkout
GET /availability/item/hold
GET /availability/item/search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Blocks||17712


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17712
[Bug 17712] Move availability calculation to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #34 from Lari Taskula  ---
Checks for circulation rules and patron status will be delivered in follow-ups
asap.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57373|0   |1
is obsolete||

--- Comment #33 from Lari Taskula  ---
Created attachment 57382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57382=edit
Bug 16826: Add REST endpoint for displaying item availabilities

Include missing Swagger spec files part 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57371|0   |1
is obsolete||

--- Comment #32 from Lari Taskula  ---
Created attachment 57373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57373=edit
Bug 16826: Add REST endpoint for displaying item availabilities

Include missing Swagger spec files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57370|0   |1
is obsolete||

--- Comment #31 from Lari Taskula  ---
Created attachment 57371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57371=edit
Bug 16826: Add REST endpoint for displaying item availabilities

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #30 from Lari Taskula  ---
I fixed some bugs that I found during testing, and also thought the old patch
should be split into two; first for introducing new classes and the second for
API. I hope this makes it a bit more understandable and easier to test. All
availability logic was moved from Koha::Item to Koha::Item::Availabilities. I
think this way is cleaner and we avoided previously added 170 lines of code
from Koha::Item that could (and should) as well be in its own module. I left a
simple link into Koha::Item, $item->availabilities that you can easily use for
accessing availability data. Another way is to create a new
Koha::Item::Availabilities object and passing $item for the constructor.

Also I added some useful item data in return JSON.

Since these updates changed a lot, I set this Bug back into Needs Signoff
status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #28 from Lari Taskula  ---
Created attachment 57369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57369=edit
Bug 16826: Add Koha::Item::Availabilit(y/ies) for item availability

This patch adds classes for calculating and storing item availability
information.

Usage is simple, e.g. holdability;
my $item = Koha::Items->find(123);
my $holdability = $item->availabilities->hold;
if ($holdability->available) {
  # available for hold!
} else {
  # $holdability->description holds the reason for unavailability
}

To test:
1. Run t/db_dependent/Koha/Item/Availability.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #29 from Lari Taskula  ---
Created attachment 57370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57370=edit
Bug 16826: Add REST endpoint for displaying item availabilities

GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987

This patch adds above routes for checking anonymous item availability. Patron
status is not checked.

The returned data is for example:
{
  "checkout": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "hold": {
 "available": true,
 "description": [],
 "expected_available": null
  },
  "local_use": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "onsite_checkout": {
 "available": false,
 "description": ["onsite_checkouts_disabled"],
 "expected_available": null
  },
  "hold_queue_length": 1,
  + some basic item information on locations, bib/bib(item)numbers etc.
}

Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)

To test:
1. Apply patch
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
5. Repeat steps 2-4 until you are confident the route works as expected.
6. Run t/db_dependent/api/v1/availability.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57321|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57271|0   |1
is obsolete||

--- Comment #27 from Lari Taskula  ---
Created attachment 57321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57321=edit
Bug 16826: Add API route for getting item availability

GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987

This patch adds above routes for checking anonymous item availability. Patron
status is not checked.

The returned data is for example:
{
  "checkout": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "hold": {
 "available": true,
 "description": [],
 "expected_available": null
  },
  "local_use": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "onsite_checkout": {
 "available": false,
 "description": ["onsite_checkouts_disabled"],
 "expected_available": null
  },
  "hold_queue_length": 1,
  + some basic item information on locations, bib/bib(item)numbers etc.
}

Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)

To test:
1. Apply patch
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
5. Repeat steps 2-4 until you are confident the route works as expected.
6. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

Signed-off-by: Jiri Kozlovsky 

Fixed a bug in finding existing holds. Added some more tests to cover it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56295|0   |1
is obsolete||

--- Comment #26 from Lari Taskula  ---
Created attachment 57271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57271=edit
Bug 16826: Add API route for getting item availability

GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987

This patch adds above routes for checking anonymous item availability. Patron
status is not checked.

The returned data is for example:
{
  "checkout": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "hold": {
 "available": true,
 "description": [],
 "expected_available": null
  },
  "local_use": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "onsite_checkout": {
 "available": false,
 "description": ["onsite_checkouts_disabled"],
 "expected_available": null
  },
  "hold_queue_length": 1,
  + some basic item information on locations, bib/bib(item)numbers etc.
}

Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)

To test:
1. Apply patch
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
5. Repeat steps 2-4 until you are confident the route works as expected.
6. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56130|0   |1
is obsolete||

--- Comment #24 from Lari Taskula  ---
Created attachment 56295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56295=edit
Bug 16826: Add API route for getting item availability

GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987

This patch adds above routes for checking anonymous item availability. Patron
status is not checked.

The returned data is for example:
{
  "checkout": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "hold": {
 "available": true,
 "description": [],
 "expected_available": null
  },
  "local_use": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "onsite_checkout": {
 "available": false,
 "description": ["onsite_checkouts_disabled"],
 "expected_available": null
  },
  "hold_queue_length": 1,
  + some basic item information on locations, bib/bib(item)numbers etc.
}

Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)

To test:
1. Apply patch
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
5. Repeat steps 2-4 until you are confident the route works as expected.
6. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #25 from Lari Taskula  ---
Removed minifying step from test plan after Bug 17432 was pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56129|0   |1
is obsolete||

--- Comment #23 from Lari Taskula  ---
Created attachment 56130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56130=edit
Bug 16826: Add API route for getting item availability

Fixing one more typo in test plan:

To test:
1. Apply patch and run minifySwagger.pl
   perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d
api/v1/swagger/swagger.min.json
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
5. Repeat steps 2-4 until you are confident the route works as expected.
6. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56128|0   |1
is obsolete||

--- Comment #22 from Lari Taskula  ---
Created attachment 56129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56129=edit
Bug 16826: Add API route for getting item availability

Fixing typo in test plan. This plan applies:

To test:
1. Apply patch and run minifySwagger.pl
   perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d
api/v1/swagger
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
5. Repeat steps 2-4 until you are confident the route works as expected.
6. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

--- Comment #21 from Lari Taskula  ---
Rebased on top of master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #54053|0   |1
is obsolete||

--- Comment #20 from Lari Taskula  ---
Created attachment 56128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56128=edit
Bug 16826: Add API route for getting item availability

GET /availability/items?itemnumber=123
GET /availability/items?itemnumber=123+456+789
GET /availability/items?biblionumber=321
GET /availability/items?biblionumber=321+654+987

This patch adds above routes for checking anonymous item availability. Patron
status is not checked.

The returned data is for example:
{
  "checkout": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "hold": {
 "available": true,
 "description": [],
 "expected_available": null
  },
  "local_use": {
 "available": false,
 "description": ["onloan"],
 "expected_available": "2016-07-13"
  },
  "onsite_checkout": {
 "available": false,
 "description": ["onsite_checkouts_disabled"],
 "expected_available": null
  },
  "hold_queue_length": 1,
  + some basic item information on locations, bib/bib(item)numbers etc.
}

Possible values in availability description are an empty array and any of:
"onloan", "reserved", "damaged", "withdrawn", "itemlost", "restricted",
"notforloan", "ordered". (+"onsite_checkouts_disabled" for onsite_checkout)

To test:
1. Apply patch and run minifySwagger.pl
   perl misc/devel/minifySwagger.pl -s api/v1/swagger/swagger.json -d
api/v1/swagger
2. Play around with an item. Place a hold on it, checkout, set it damaged etc.
3. Make GET requests to /api/v1/availability/items?itemnumber=YYY, where
   YYY is an existing itemnumber. You can also try with biblionumber=XXX
   query parameter, where XXX is an existing biblionumber.
4. Check that the availability statuses are correct and that availability
   description lists the appropriate status for unavailability.
5. Repeat steps 1-3 until you are confident the route works as expected.
6. Run the following tests:
   - t/Koha/Item/Availability.t
   - t/db_dependent/Items.t
   - t/db_dependent/api/v1/availability.t

Signed-off-by: Jiri Kozlovsky 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] REST API: Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

Summary|Add API routes for getting  |REST API: Add API routes
   |item availability and   |for getting item
   |holdability |availability and
   ||holdability

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/