[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2017-10-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #41 from Mason James  ---
(In reply to Kyle M Hall from comment #36)
> Pushed to master for 16.11, thanks Jonathan!

Enhancement, skipping for 16.05.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-11-30 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17699


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17699
[Bug 17699] DateTime durations are not correctly subtracted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-10-03 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #40 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #39)
> (In reply to Jonathan Druart from comment #38)
> > (In reply to Kyle M Hall from comment #37)
> > > Created attachment 55447 [details] [review] [review] [review]
> > > Bug 16911 [QA Followup] - No need to 'use C4::Members'
> > > 
> > > For some reason, this is causing t/db_dependent/Circulation.t to fail if
> > > run independently.
> > > 
> > > Signed-off-by: Kyle M Hall 
> > 
> > I do not understand this patch, the subroutine AddEnrolmentFeeIfNeeded from
> > C4::Members is called from Koha::Patron. It would make sense to use it.
> 
> Do the unit tests fail for you without that patch? If not, maybe it's a
> quirk of my environment. Because the call to AddEnrolmentFeeIfNeeded is
> fully qualified, the 'use' is not needed, and would be unnecessary overhead
> ( though incredibly minimal ).
> 
> If the tests pass for you without that patch, I'd be happy to revert that
> specific commit.

No, the tests don't pass, but I don't understand why they do with this patch.
I am suspecting there is bug hidden somewhere else :-/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-27 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #39 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #38)
> (In reply to Kyle M Hall from comment #37)
> > Created attachment 55447 [details] [review] [review]
> > Bug 16911 [QA Followup] - No need to 'use C4::Members'
> > 
> > For some reason, this is causing t/db_dependent/Circulation.t to fail if
> > run independently.
> > 
> > Signed-off-by: Kyle M Hall 
> 
> I do not understand this patch, the subroutine AddEnrolmentFeeIfNeeded from
> C4::Members is called from Koha::Patron. It would make sense to use it.

Do the unit tests fail for you without that patch? If not, maybe it's a quirk
of my environment. Because the call to AddEnrolmentFeeIfNeeded is fully
qualified, the 'use' is not needed, and would be unnecessary overhead ( though
incredibly minimal ).

If the tests pass for you without that patch, I'd be happy to revert that
specific commit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-27 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17307


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17307
[Bug 17307] Some edit buttons/links for patrons do not work
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #38 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #37)
> Created attachment 55447 [details] [review]
> Bug 16911 [QA Followup] - No need to 'use C4::Members'
> 
> For some reason, this is causing t/db_dependent/Circulation.t to fail if
> run independently.
> 
> Signed-off-by: Kyle M Hall 

I do not understand this patch, the subroutine AddEnrolmentFeeIfNeeded from
C4::Members is called from Koha::Patron. It would make sense to use it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #37 from Kyle M Hall  ---
Created attachment 55447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55447=edit
Bug 16911 [QA Followup] - No need to 'use C4::Members'

For some reason, this is causing t/db_dependent/Circulation.t to fail if
run independently.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #36 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #35 from Kyle M Hall  ---
Created attachment 55424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55424=edit
Bug 16911 [QA Followup] - Fix number of categories to look for after deleting
one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54794|0   |1
is obsolete||

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 55196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55196=edit
Bug 16911: ->get_expiry_date accepts strings

To make sure nothing else will be broken, it's certainly better to
handle date strings in a first phase.

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54792|0   |1
is obsolete||

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 55194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55194=edit
Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to
->extend_subscription

This patch moves the code from C4::Members::ExtendMemberSubscriptionTo
to Koha::Patron->extend_subscription.

The expected behavior is:
When a new patron is created, the enrolment period defined for the
patron category is used unless an enrolment period date is defined. In
that case, this date is used.
When an account is renewed, the pref BorrowerRenewalPeriodBase is used to
determine if the subscription is renewed from today or from the day when
his/her
account has expired.

Test plan:
Confirm that the behavior is correct before this patch and that it's
still the same after this patchset applied.

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #34 from Tomás Cohen Arazi  ---
Created attachment 55197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55197=edit
Bug 16911: (QA followup) CGI->param should not be called in list context

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54793|0   |1
is obsolete||

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 55195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55195=edit
Bug 16911: Rename extend_subscription with renew_account

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54791|0   |1
is obsolete||

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 55193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55193=edit
Bug 16911: Koha::Patrons - Add tests for ->extend_subscription

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54790|0   |1
is obsolete||

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 55192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55192=edit
Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to ->get_expiry_date

This patch moves the code from C4::Members::GetExpiryDate to
Koha::Patron::Categories.
Nothing much exiting, please follow test plan in next patches.

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54789|0   |1
is obsolete||

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 55191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55191=edit
Bug 16911: Koha::Patron::Categories - Add tests for ->get_expiry_date

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #54755|0   |1
is obsolete||

--- Comment #25 from Aleisha Amohia  ---
Created attachment 54792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54792=edit
[SIGNED-OFF] Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to
->extend_subscription

This patch moves the code from C4::Members::ExtendMemberSubscriptionTo
to Koha::Patron->extend_subscription.

The expected behavior is:
When a new patron is created, the enrolment period defined for the
patron category is used unless an enrolment period date is defined. In
that case, this date is used.
When an account is renewed, the pref BorrowerRenewalPeriodBase is used to
determine if the subscription is renewed from today or from the day when
his/her
account has expired.

Test plan:
Confirm that the behavior is correct before this patch and that it's
still the same after this patchset applied.

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #54757|0   |1
is obsolete||

--- Comment #27 from Aleisha Amohia  ---
Created attachment 54794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54794=edit
[SIGNED-OFF] Bug 16911: ->get_expiry_date accepts strings

To make sure nothing else will be broken, it's certainly better to
handle date strings in a first phase.

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #54753|0   |1
is obsolete||

--- Comment #23 from Aleisha Amohia  ---
Created attachment 54790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54790=edit
[SIGNED-OFF] Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to
->get_expiry_date

This patch moves the code from C4::Members::GetExpiryDate to
Koha::Patron::Categories.
Nothing much exiting, please follow test plan in next patches.

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #54754|0   |1
is obsolete||

--- Comment #24 from Aleisha Amohia  ---
Created attachment 54791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54791=edit
[SIGNED-OFF] Bug 16911: Koha::Patrons - Add tests for ->extend_subscription

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #54756|0   |1
is obsolete||

--- Comment #26 from Aleisha Amohia  ---
Created attachment 54793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54793=edit
[SIGNED-OFF] Bug 16911: Rename extend_subscription with renew_account

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #54752|0   |1
is obsolete||

--- Comment #22 from Aleisha Amohia  ---
Created attachment 54789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54789=edit
[SIGNED-OFF] Bug 16911: Koha::Patron::Categories - Add tests for
->get_expiry_date

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #21 from Jonathan Druart  
---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53517|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 54755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54755=edit
Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to
->extend_subscription

This patch moves the code from C4::Members::ExtendMemberSubscriptionTo
to Koha::Patron->extend_subscription.

The expected behavior is:
When a new patron is created, the enrolment period defined for the
patron category is used unless an enrolment period date is defined. In
that case, this date is used.
When an account is renewed, the pref BorrowerRenewalPeriodBase is used to
determine if the subscription is renewed from today or from the day when
his/her
account has expired.

Test plan:
Confirm that the behavior is correct before this patch and that it's
still the same after this patchset applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53518|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart  
---
Created attachment 54756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54756=edit
Bug 16911: Rename extend_subscription with renew_account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53516|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 54754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54754=edit
Bug 16911: Koha::Patrons - Add tests for ->extend_subscription

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53515|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  
---
Created attachment 54753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54753=edit
Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to ->get_expiry_date

This patch moves the code from C4::Members::GetExpiryDate to
Koha::Patron::Categories.
Nothing much exiting, please follow test plan in next patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53514|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 54752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54752=edit
Bug 16911: Koha::Patron::Categories - Add tests for ->get_expiry_date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-08-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53533|0   |1
is obsolete||

--- Comment #20 from Jonathan Druart  
---
Created attachment 54757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54757=edit
Bug 16911: ->get_expiry_date accepts strings

To make sure nothing else will be broken, it's certainly better to
handle date strings in a first phase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #14 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #12)
> This seems to work correctly with a patron category which has a fixed
> expiration date, but when I try to add a patron with an enrollment period
> defined in months I get an error:
> 
> Can't locate object method "add" via package "2016-07-06" (perhaps you
> forgot to load "2016-07-06"?) at Koha/Patron/Category.pm line 185.
> 
> "2016-07-06" is the date I entered in the "registration date" field.

Good catch Owen, I did not try that case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #13 from Jonathan Druart  
---
Created attachment 53533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53533=edit
Bug 16911: ->get_expiry_date accepts strings

To make sure nothing else will be broken, it's certainly better to
handle date strings in a first phase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #12 from Owen Leonard  ---
This seems to work correctly with a patron category which has a fixed
expiration date, but when I try to add a patron with an enrollment period
defined in months I get an error:

Can't locate object method "add" via package "2016-07-06" (perhaps you forgot
to load "2016-07-06"?) at Koha/Patron/Category.pm line 185.

"2016-07-06" is the date I entered in the "registration date" field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53339|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 53515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53515=edit
Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to ->get_expiry_date

This patch moves the code from C4::Members::GetExpiryDate to
Koha::Patron::Categories.
Nothing much exiting, please follow test plan in next patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53346|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 53518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53518=edit
Bug 16911: Rename extend_subscription with renew_account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53340|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 53516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53516=edit
Bug 16911: Koha::Patrons - Add tests for ->extend_subscription

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53338|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 53514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53514=edit
Bug 16911: Koha::Patron::Categories - Add tests for ->get_expiry_date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53341|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 53517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53517=edit
Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to
->extend_subscription

This patch moves the code from C4::Members::ExtendMemberSubscriptionTo
to Koha::Patron->extend_subscription.

The expected behavior is:
When a new patron is created, the enrolment period defined for the
patron category is used unless an enrolment period date is defined. In
that case, this date is used.
When an account is renewed, the pref BorrowerRenewalPeriodBase is used to
determine if the subscription is renewed from today or from the day when
his/her
account has expired.

Test plan:
Confirm that the behavior is correct before this patch and that it's
still the same after this patchset applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-18 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-07-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Jonathan Druart  changed:

   What|Removed |Added

Summary|Koha::Patrons - Move|Koha::Patrons - Move
   |ExtendMemberSubscriptionTo  |ExtendMemberSubscriptionTo
   |to ->extend_subscription|to ->renew_account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/