[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement improves

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #42

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #41 from Aleisha Amohia --- (In reply to Nick Clemens from comment #40) > Please rebase, thanks This applies cleanly for me? Where does it need rebasing? -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #38 from Jonathan Druart --- Created attachment 83134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83134=edit Bug 16939: (follow-up) Correction for orderreceive.tt This patch makes a change to

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #39 from Jonathan Druart --- Created attachment 83135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83135=edit Bug 16939: (follow-up) Adding missing bracket Signed-off-by: Owen Leonard

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What|Removed |Added Attachment #82986|0 |1 is obsolete|

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #36 from Owen Leonard --- Created attachment 82988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82988=edit Bug 16939: (follow-up) Adding missing bracket Signed-off-by: Owen Leonard -- You are

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Attachment #80791|0 |1 is obsolete|

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #35 from Owen Leonard --- Created attachment 82987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82987=edit Bug 16939: (follow-up) Correction for orderreceive.tt This patch makes a change to

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #33 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #32) > (In reply to Aleisha Amohia from comment #30) > > (In reply to Katrin Fischer from comment #27) > > > Does it fail with Elasitc with and without

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #32 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #30) > (In reply to Katrin Fischer from comment #27) > > Does it fail with Elasitc with and without this patch? > > This is a good point. I've

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #30 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #27) > Does it fail with Elasitc with and without this patch? This is a good point. I've retested and can confirm that we cannot add to a basket with

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #31 from Aleisha Amohia --- (In reply to Owen Leonard from comment #28) > The QA tool fails acqui/z3950_search.tt: parse error - > /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ > z3950_search.tt

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #29 from Aleisha Amohia --- Created attachment 80999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80999=edit Bug 16939: (follow-up) Adding missing bracket -- You are receiving this mail because:

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #28

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #75641|0 |1 is obsolete|

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #61661|0 |1 is obsolete|

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #23 from Owen Leonard --- Created attachment 75641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75641=edit Bug 16939: (follow-up) Correction for orderreceive.tt This patch makes a change to

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #22 from Jonathan Druart --- You are modifying a js file that is used from different templates. You will introduced side-effects with these changes (when receiving an item if

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #21 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #20) > Aleisha, > Take a look at orderreceive.tt, it also uses additem.js when AcqCreateItem = > "on receiving". Sorry

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Marc Véron changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Marc Véron changed: What|Removed |Added Attachment #61655|0 |1 is

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #57874|0

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #16 from Marc Véron --- Created attachment 61206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61206=edit Strange artifact when ordering from external source Testing 11) 'Order'

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #54494|0

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | --

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #13 from Aleisha Amohia --- (In reply to Owen Leonard from comment #11) > I'm still getting the plus sign when there is no link. I think the template > logic is off somewhere. If it helps, feel

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #53791|0

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #53716|0

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #9 from Owen Leonard --- Please update circ/reserveratios.tt so that the "plus" icon is not shown when there is no link. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #53565|0

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nicole C. Engard changed: What|Removed |Added Attachment #53545|0 |1

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #53538|0

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Attachment #53484|0

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #3 from Héctor Eduardo Castro Avalos --- Looks great, just fix the "clas" in Add orders -> addorderiso2709.tt -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #2 from Héctor Eduardo Castro Avalos --- Comment on attachment 53484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53484 Bug 16939: Making all 'add to basket' actions

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 --- Comment #1 from Aleisha Amohia --- Created attachment 53484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53484=edit Bug 16939: Making all 'add to basket' actions buttons To test:

[Koha-bugs] [Bug 16939] Making all 'add to basket' actions buttons

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16939 Aleisha Amohia changed: What|Removed |Added Change sponsored?|---