[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2018-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21730


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21730
[Bug 21730] PA_CLASS missing from list of authorized values categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2018-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21144
[Bug 21144] ROADTYPE missing from authorised value categories list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2017-03-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||18248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248
[Bug 18248] Add missing patch from 17216
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2017-03-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|18248   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18248
[Bug 18248] Add missing patch from 17216
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2017-03-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #106 from Katrin Fischer  ---
This changed an existing database entry - what about the installations that
have already updated to 16.11.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2017-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #105 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #95)
> Created attachment 57729 [details] [review]
> Bug 17216: Fix SQL statement to setting
> marc_subfield_structure.authorised_value to NULL
> 
> We want to update it if it's empty, not equal to ';'
> nopaste vim mode is to blame

This is not in, we absolutely need it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2017-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18097


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18097
[Bug 18097] It is possible to create unusable category codes (ccode) due to
field length mismatch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2017-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||This patch set adds a new
  release notes||table
   ||authorised_value_categories
   ||to store authori(s|z)ed
   ||value categories into a
   ||separate table. The
   ||problematic is explained on
   ||bug 15799 comment 4:
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15799#c4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #104 from Jonathan Druart  
---
I am going to provide a patch on bug 17676

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17676


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17676
[Bug 17676] Default COLLATE for marc_subfield_structure is not set
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #103 from Jonathan Druart  
---
All of this sounds related to bug 13810

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #102 from Jacek Ablewicz  ---
(In reply to Mirko Tietgen from comment #101)

> [Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
> 12632.
> [Thu Nov 24 00:06:15 2016] updatedatabase.pl: DBD::mysql::db do failed:
> Can't create table 'koha_koha.#sql-2221_18d' (errno: 150) [for Statement "
> [Thu Nov 24 00:06:15 2016] updatedatabase.pl: ALTER TABLE
> marc_subfield_structure
> [Thu Nov 24 00:06:15 2016] updatedatabase.pl: MODIFY COLUMN
> authorised_value VARCHAR(32) DEFAULT NULL,
> [Thu Nov 24 00:06:15 2016] updatedatabase.pl: ADD CONSTRAINT
> marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES
> authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET
> NULL;
> [Thu Nov 24 00:06:15 2016] updatedatabase.pl: "] at
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
> 13175.
> 
> 
> @Jacek: that is what you are talking about, right?

Possibly ;), hard to tell (errno: 150 by itself is not very informative).
What I did while trying to troubleshoot this problem (following the guidelines
from
,
especially nr 4 is quite helpful):

- split erroneous statement in two

1) ALTER TABLE marc_subfield_structure
MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL;

2) ALTER TABLE marc_subfield_structure
ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value)
REFERENCES authorised_value_categories (category_name) ON UPDATE CASCADE ON
DELETE SET NULL;

- part 1) executed OK, but part 2) still resulted in the same error (150)

- noticed that after 1), utf8_unicode_ci collation is no longer there for
authorised_value field (mysqldump --no-data marc_subfield_structure)

- replaced 1) with

ALTER TABLE marc_subfield_structure
MODIFY COLUMN authorised_value VARCHAR(32) CHARACTER SET utf8 COLLATE
utf8_unicode_ci DEFAULT NULL;

- re-run 1) and 2) - no error, FK constrain got created successfully and
collation for authorised_value is utf8_unicode_ci.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #101 from Mirko Tietgen  ---
Did an install with the latest patch added, got

Update errors :

[Thu Nov 24 00:06:08 2016] updatedatabase.pl: DBD::mysql::db do failed:
Duplicate column name 'updated_on' [for Statement "
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ALTER TABLE borrowers
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ADD COLUMN updated_on
timestamp NULL DEFAULT CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ON UPDATE CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: AFTER
privacy_guarantor_checkouts;
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
12626.
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: DBD::mysql::db do failed:
Duplicate column name 'updated_on' [for Statement "
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ALTER TABLE deletedborrowers
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ADD COLUMN updated_on
timestamp NULL DEFAULT CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ON UPDATE CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: AFTER
privacy_guarantor_checkouts;
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
12632.
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: DBD::mysql::db do failed:
Can't create table 'koha_koha.#sql-2221_18d' (errno: 150) [for Statement "
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: ALTER TABLE
marc_subfield_structure
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: MODIFY COLUMN
authorised_value VARCHAR(32) DEFAULT NULL,
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: ADD CONSTRAINT
marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES
authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET
NULL;
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: "] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
13175.


@Jacek: that is what you are talking about, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #100 from Jacek Ablewicz  ---
Huh, this is what happens (mysql 5.5.49): for a table with no default collation
defined on table level (like marc_subfield_structure)

   MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL

does not preserve existing collation for that field (which was, after all,
utf8_unicode_ci in my test DB before attempting that upgrade: manually set up
to utf8_unicode_ci for a bunch of marc_subfield_structure fields in DB update
from Bug 11944), and it subsequently fails with error 150 on adding FK
constraint because of collations inconsistency (I think.. not quite sure, but a
solution from comment #96 fixes this problem).

It's reproductible; note that I have different default collation defined mysql
server-side on that box (utf8_general_ci) - if it was utf8_unicode_ci
server-side, I guess there is a possibility this issue does not manifest itself
(?).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #98 from Jacek Ablewicz  ---
(In reply to Katrin Fischer from comment #97)
> >Got the same error in my test setup. For undetermined reason, 
> >authorised_value >field in marc_subfield_structure table did not have 
> >utf8_unicode_ci collation.
> 
> That's intentional. ci = case insensitive breaks uppercase subfield codes
> which are often used to create additional fields in 952.

marc_subfield_structure.tagsubfield indeed has utf8_bin collation, but should
the same rule apply for authorised_value? By default (in fresh installs),
marc_subfield_structure.authorised_value has utf8_unicode_ci collation, for
some reasons (I still have no idea why, maybe update from Bug 11944 partially
failed) in my old test DB, this field has no collation defined, and that's why
adding FK failed for me with error 150.

But it can be failing for different reason[s] for other people - and probably
is, this collation issue seems to be some kind of problem which was specific to
this particular DB.

There is one other table (overduerules) in that DB which does not have
utf8_unicode_ci collation set by default for all text fields, but it looks more
like an omission in updatedatabase (Bug 13624, DB version: 3.23.00.007).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #99 from Jacek Ablewicz  ---
(In reply to Jacek Ablewicz from comment #96)

> No idea why this DB update is tagged 
> with "Bug 17357 - WTHDRAWN is still used in installer files)" and not with a
> "Bug 17216 ..." instead.

Uhm, scratch that; in fact it is tagged correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #97 from Katrin Fischer  ---
>Got the same error in my test setup. For undetermined reason, authorised_value 
>>field in marc_subfield_structure table did not have utf8_unicode_ci collation.

That's intentional. ci = case insensitive breaks uppercase subfield codes which
are often used to create additional fields in 952.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #96 from Jacek Ablewicz  ---
(In reply to Mirko Tietgen from comment #93)
> With a Debian package for 16.11, on upgrade from 16.05 the following happens:
> 
> Upgrade to 16.06.00.032 done (Bug 17357 - WTHDRAWN is still used in
> installer files)
> DBD::mysql::db do failed: Can't create table 'koha_upgrade.#sql-329_a5'
> (errno: 150) [for Statement "
> ALTER TABLE marc_subfield_structure
> MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,
> ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY
> (authorised_value) REFERENCES authorised_value_categories (category_name) ON
> UPDATE CASCADE ON DELETE SET NULL;
> "] at
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
> 13175.
> Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store
> authorized value categories)
> 
> I assume it is related to this bug? Is it safe to ignore? It does sound more
> scary than the duplicate warnings we get from time to time.

Got the same error in my test setup. For undetermined reason, authorised_value
field in marc_subfield_structure table did not have utf8_unicode_ci collation.

I replaced

MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,

with

MODIFY COLUMN authorised_value VARCHAR(32) CHARACTER SET utf8 COLLATE
utf8_unicode_ci DEFAULT NULL,

and after that it seems to work fine. No idea why this DB update is tagged 
with "Bug 17357 - WTHDRAWN is still used in installer files)" and not with a
"Bug 17216 ..." instead.

BTW, there are some other text fields in my test DB with inconsistent collation
too, but this is a database with a long history of accumulated DB updates
(including various unstable / atomic ones).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #95 from Jonathan Druart  
---
Created attachment 57729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57729=edit
Bug 17216: Fix SQL statement to setting
marc_subfield_structure.authorised_value to NULL

We want to update it if it's empty, not equal to ';'
nopaste vim mode is to blame

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #94 from Mirko Tietgen  ---
FYI: I'll wait with the package release for 16.11.00 until this is solved. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #93 from Mirko Tietgen  ---
With a Debian package for 16.11, on upgrade from 16.05 the following happens:

Upgrade to 16.06.00.032 done (Bug 17357 - WTHDRAWN is still used in installer
files)
DBD::mysql::db do failed: Can't create table 'koha_upgrade.#sql-329_a5' (errno:
150) [for Statement "
ALTER TABLE marc_subfield_structure
MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,
ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY
(authorised_value) REFERENCES authorised_value_categories (category_name) ON
UPDATE CASCADE ON DELETE SET NULL;
"] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
13175.
Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store authorized
value categories)

I assume it is related to this bug? Is it safe to ignore? It does sound more
scary than the duplicate warnings we get from time to time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17540


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540
[Bug 17540] auth_values_input_www.t is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17538


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17538
[Bug 17538] t/db_dependent/Upload.t is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #92 from Brendan Gallagher  ---
(In reply to Jonathan Druart from comment #91)
> (In reply to Jonathan Druart from comment #90)
> > Created attachment 56619 [details] [review] [review]
> > Bug 17216: Revert changes to ItemsSearchField schema file
> 
> @RM, could you please push this follow-up please? It seems that I have
> generated a wrong file (80 vs 32).

Thanks!  Pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #91 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #90)
> Created attachment 56619 [details] [review]
> Bug 17216: Revert changes to ItemsSearchField schema file

@RM, could you please push this follow-up please? It seems that I have
generated a wrong file (80 vs 32).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #90 from Jonathan Druart  
---
Created attachment 56619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56619=edit
Bug 17216: Revert changes to ItemsSearchField schema file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #89 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 2016 Release.   Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Alex Sassmannshausen  changed:

   What|Removed |Added

 Blocks||5670


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670
[Bug 5670] Housebound Readers Module
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55693|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55835|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55692|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55376|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55374|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55373|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55375|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55371|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55372|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55370|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55367|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55369|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55368|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55366|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55365|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #55840|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #85 from Katrin Fischer  ---
Created attachment 56214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56214=edit
[PASSED QA] Bug 17216: Do not display branches, itemtypes and cn_source

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #87 from Katrin Fischer  ---
Created attachment 56216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56216=edit
[PASSED QA] Bug 17216: Internal AV should be correctly handled when creating a
new category

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #84 from Katrin Fischer  ---
Created attachment 56213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56213=edit
[PASSED QA] Bug 17216: Fix other tests

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #86 from Katrin Fischer  ---
Created attachment 56215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56215=edit
[PASSED QA] Bug 17216: Do no display the empty string category name

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #88 from Katrin Fischer  ---
Created attachment 56217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56217=edit
[PASSED QA] Bug 17216: Move the AV cat list file to the top level

This way it will get used for any languages.

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #83 from Katrin Fischer  ---
Created attachment 56212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56212=edit
[PASSED QA] Bug 17216: Fix tests

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #80 from Katrin Fischer  ---
Created attachment 56209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56209=edit
[PASSED QA] Bug 17216: Add FK on authorised_values.category

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #82 from Katrin Fischer  ---
Created attachment 56211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56211=edit
[PASSED QA] Bug 17216: Update DBIC schema for MSS

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #79 from Katrin Fischer  ---
Created attachment 56208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56208=edit
[PASSED QA] Bug 17216: Use Koha::AVC from mss.pl

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #81 from Katrin Fischer  ---
Created attachment 56210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56210=edit
[PASSED QA] Bug 17216: Update DBIC Schema

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #76 from Katrin Fischer  ---
Created attachment 56205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56205=edit
[PASSED QA] Bug 17216: DBIC Schema changes

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #78 from Katrin Fischer  ---
Created attachment 56207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56207=edit
[PASSED QA] Bug 17216: Add FK on mss.authorised_value

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #75 from Katrin Fischer  ---
Created attachment 56204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56204=edit
[PASSED QA] Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #77 from Katrin Fischer  ---
Created attachment 56206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56206=edit
[PASSED QA] Bug 17216: Update the admin interface

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #74 from Katrin Fischer  ---
Created attachment 56203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56203=edit
[PASSED QA] Bug 17216: Add new table authorised_value_categories and populate
it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #73 from Katrin Fischer  ---
Created attachment 56202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56202=edit
[PASSED QA] Bug 17216: Add Koha::AuthorisedValueCategory|ies classes

Signed-off-by: Owen Leonard 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17360

--- Comment #72 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #70)
> Cool, thx Jonathan - one last thing - could you take a look at the installer
> files? 
> 
> You noted that before this is pushed we need to fix the files there. I think
> this is really close to PQA now.
> 
> Could we handle this like sysprefs.sql having one file on top level used for
> all? I think we got no need for translations here.

Done, see the last patch.
You can use the script from bug 17360 to test it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #71 from Jonathan Druart  
---
Created attachment 55840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55840=edit
Bug 17216: Move the AV cat list file to the top level

This way it will get used for any languages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17358


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17358
[Bug 17358] Authorised values: COU>COUNTRY | LAN>LANG
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17357


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17357
[Bug 17357] WTHDRAWN is still used in installer files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #70 from Katrin Fischer  ---
Cool, thx Jonathan - one last thing - could you take a look at the installer
files? 

You noted that before this is pushed we need to fix the files there. I think
this is really close to PQA now.

Could we handle this like sysprefs.sql having one file on top level used for
all? I think we got no need for translations here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #69 from Jonathan Druart  
---
Created attachment 55835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55835=edit
Bug 17216: Internal AV should be correctly handled when creating a new category

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355
[Bug 17355] Allow deletion of authorised value categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #68 from Katrin Fischer  ---
Hi Jonathan,

this is looking good, but I found something a bit disturbing (to me :) ):
Try to add an authorized value category "Branches".
The system tells you, that the category already exists.
But: It will allow you then to add a new value to it.

Can we show the "used internally message" and now allow to do that?

I will move the "delete category" to a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #67 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #64)
> Hi Jonathan, mostly good - please take a look:
> 
> Administration > Authorized values
> 
> 1) I think the 'virtual' authorized values branches, itemtypes and cn_sort
> should not show up in the authorized value list in administration. It's not
> a nice effect that it looks like you can add to them and then get an error
> message - we should avoid that kind of user experience.

Done, removed.

> 2) Small typo when adding to 'branches'. Should be:
> The authorized value categories 'branches', 'itemtypes' and 'cn_source' are
> used internally by Koha and are not valid.

Done, thanks.

> 3) If you typo in an authorized value category, there is no way to remove
> it. That can get annoying pretty fast. We should offer a way to delete an
> empty authorized value category (maybe if not empty too?).

Yes, it's in the TODO section of the commit msg.

> 4) The new empty option in the pull down list leads to some confusing
> display:
> Authorized values for category :
> There are no authorized values defined for 

Fixed, the empty one is no longer displayed.

> Editing items
> 
> 5) There is a problem with the STACK on 952$j as this doesn't exist. Should
> we clean it up by removing it from the frameworks if there are no values
> defined for it?

I have not found regression with master. So let's deal with it on another bug
report.

> Authority types
> 6) Should we add the same FK relationship there? (separate bug?)

Yes, and others as well. But that should be done on another bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #66 from Jonathan Druart  
---
Created attachment 55693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55693=edit
Bug 17216: Do no display the empty string category name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #65 from Jonathan Druart  
---
Created attachment 55692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55692=edit
Bug 17216: Do not display branches, itemtypes and cn_source

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #64 from Katrin Fischer  ---
Hi Jonathan, mostly good - please take a look:

Administration > Authorized values

1) I think the 'virtual' authorized values branches, itemtypes and cn_sort
should not show up in the authorized value list in administration. It's not a
nice effect that it looks like you can add to them and then get an error
message - we should avoid that kind of user experience.

2) Small typo when adding to 'branches'. Should be:
The authorized value categories 'branches', 'itemtypes' and 'cn_source' are
used internally by Koha and are not valid.

3) If you typo in an authorized value category, there is no way to remove it.
That can get annoying pretty fast. We should offer a way to delete an empty
authorized value category (maybe if not empty too?).

4) The new empty option in the pull down list leads to some confusing display:
Authorized values for category :
There are no authorized values defined for 

Editing items

5) There is a problem with the STACK on 952$j as this doesn't exist. Should we
clean it up by removing it from the frameworks if there are no values defined
for it?

Authority types
6) Should we add the same FK relationship there? (separate bug?)

Successfully tested:
- Bibliographic MARC frameworks
- Cataloguing
- Patron attribute types / Patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|17249   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249
[Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55216|0   |1
is obsolete||

--- Comment #61 from Jonathan Druart  
---
Created attachment 55374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55374=edit
Bug 17216: Update DBIC schema for MSS

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55217|0   |1
is obsolete||

--- Comment #62 from Jonathan Druart  
---
Created attachment 55375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55375=edit
Bug 17216: Fix tests

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55215|0   |1
is obsolete||

--- Comment #60 from Jonathan Druart  
---
Created attachment 55373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55373=edit
Bug 17216: Update DBIC Schema

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55218|0   |1
is obsolete||

--- Comment #63 from Jonathan Druart  
---
Created attachment 55376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55376=edit
Bug 17216: Fix other tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55213|0   |1
is obsolete||

--- Comment #58 from Jonathan Druart  
---
Created attachment 55371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55371=edit
Bug 17216: Use Koha::AVC from mss.pl

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55214|0   |1
is obsolete||

--- Comment #59 from Jonathan Druart  
---
Created attachment 55372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55372=edit
Bug 17216: Add FK on authorised_values.category

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55212|0   |1
is obsolete||

--- Comment #57 from Jonathan Druart  
---
Created attachment 55370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55370=edit
Bug 17216: Add FK on mss.authorised_value

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55207|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart  
---
Created attachment 55365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55365=edit
Bug 17216: Add Koha::AuthorisedValueCategory|ies classes

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55208|0   |1
is obsolete||

--- Comment #53 from Jonathan Druart  
---
Created attachment 55366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55366=edit
Bug 17216: Add new table authorised_value_categories and populate it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55211|0   |1
is obsolete||

--- Comment #56 from Jonathan Druart  
---
Created attachment 55369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55369=edit
Bug 17216: Update the admin interface

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55209|0   |1
is obsolete||

--- Comment #54 from Jonathan Druart  
---
Created attachment 55367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55367=edit
Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55210|0   |1
is obsolete||

--- Comment #55 from Jonathan Druart  
---
Created attachment 55368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55368=edit
Bug 17216: DBIC Schema changes

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #50 from Jonathan Druart  
---
Created attachment 55218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55218=edit
Bug 17216: Fix other tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #48 from Jonathan Druart  
---
Created attachment 55216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55216=edit
Bug 17216: Update DBIC schema for MSS

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #47 from Jonathan Druart  
---
Created attachment 55215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55215=edit
Bug 17216: Update DBIC Schema

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #49 from Jonathan Druart  
---
Created attachment 55217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55217=edit
Bug 17216: Fix tests

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #51 from Jonathan Druart  
---
Last patch set fixes conflict with bug 11019.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #46 from Jonathan Druart  
---
Created attachment 55214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55214=edit
Bug 17216: Add FK on authorised_values.category

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #40 from Jonathan Druart  
---
Created attachment 55208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55208=edit
Bug 17216: Add new table authorised_value_categories and populate it

This patch set adds a new table authorised_value_categories to store
authori(s|z)ed value categories into a separate table.
The problematic is explained on bug 15799 comment 4:
We need FK to the AV categories but some may not have authorized values
yet.

What does this patch set:
- Add a new authorised_value_categories table
- Populate it with known categories
- Update FK items_search_fields.authorised_values_category
- Create a new FK marc_subfield_structure.authorised_value (FIXME should
  be authorised_value_categories instead)

They are some problems this patch set do not take into account:
- The .sql installer files won't insert correctly (will have to be
  updated when this patch set will be ready to be pushed)
- All the categories (even the ones without authorized values defined)
  are listed when you edit frameworks (marc_subfield_structure.pl)
- There is no way to delete a category (TODO). But to do so it would be
  good to have a authorised_value_categories.is_internal field to mark
  some categories as "cannot be deleted".

Test plan:
0/ Execute the DB entry to create and populate the new table and set the FK
1/ Create a new AV category from the admin module (admin/authorised_values.pl)
2/ Add/edit subfield linked to a AV category
(admin/marc_subfield_structure.pl)
3/ You won't be allowed to add AV for branches, itemtypes or cn_source.
They are used internally.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #41 from Jonathan Druart  
---
Created attachment 55209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55209=edit
Bug 17216: Add some other AV categories

Found in
installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #45 from Jonathan Druart  
---
Created attachment 55213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55213=edit
Bug 17216: Use Koha::AVC from mss.pl

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >