https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Andrew Fuerste-Henry changed:
What|Removed |Added
Blocks||26916
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Text to go in the||This patch preserves the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #49 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #48 from Jonathan Druart
---
I cleaned the patches a bit (squash and remove warn, whitespaces, etc.).
After this patch, columns.def and
koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc list the borrowers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #47 from Jonathan Druart
---
Created attachment 100439
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100439=edit
Bug 17374: (QA follow-up) Make search labels match with patron record
Makes some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #46 from Jonathan Druart
---
Created attachment 100438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100438=edit
Bug 17374: (follow-up) Unit tests
Signed-off-by: Maxime Dufresne
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #45 from Jonathan Druart
---
Created attachment 100437
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100437=edit
Bug 17374: (follow-up) Remove spaces from include file
Bug 17374: Fix another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Attachment #96341|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #43 from Nick Clemens ---
Created attachment 98478
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98478=edit
Bug 17374: (follow-up) Remove all spaces from include file
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #41 from Katrin Fischer ---
Created attachment 98106
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98106=edit
Bug 17374: (QA follow-up) Make search labels match with patron record
Makes some small
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Depends on|14874 |
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #40 from Nick Clemens ---
Created attachment 96679
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96679=edit
Bug 17374: Fix another occurrence
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #39 from Jonathan Druart
---
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc: [%
NEXT IF display_name.length == 5 %]
So this one too I guess?
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #38 from Nick Clemens ---
(In reply to Jonathan Druart from comment #34)
> (In reply to Nick Clemens from comment #22)
> > (In reply to Jonathan Druart from comment #19)
> > > + [% NEXT IF
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #37 from Nick Clemens ---
Created attachment 96343
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96343=edit
Bug 17374: (follow-up) Unit tests and remove warns
Signed-off-by: Maxime Dufresne
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Attachment #74828|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #36 from Nick Clemens ---
Created attachment 96342
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96342=edit
Bug 17374: (follow-up) Remove spaces from include file
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Attachment #74828|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Maxime Dufresne changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Maxime Dufresne changed:
What|Removed |Added
Attachment #94890|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Maxime Dufresne changed:
What|Removed |Added
Attachment #94876|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Maxime Dufresne changed:
What|Removed |Added
Attachment #94831|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #29 from Nick Clemens ---
Created attachment 94876
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94876=edit
Bug 17374: (follow-up) Unit tests and remove warns
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Kelly McElligott changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
ByWater Sandboxes changed:
What|Removed |Added
Attachment #93226|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #25 from Nick Clemens ---
(In reply to Jonathan Druart from comment #23)
> 2 majors problems:
>
> 1. compare columns.def and patronfields.inc
> => They are the "same"
>
Yes, but I think this is for another report. The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Attachment #71597|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
QA Contact|katrin.fisc...@bsz-bw.de|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #22 from Nick Clemens ---
(In reply to Jonathan Druart from comment #19)
> + [% NEXT IF display_name.length == 5 %]
>
> Hum??
Ah, the indents in the file were adding 5 spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #21 from Nick Clemens ---
Created attachment 74828
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74828=edit
Bug 17374: (follow-up) Remove spaces from include file
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Lisette changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #18 from Katrin Fischer ---
Fixed koha to Koha in the last commit and changed commit subject lines to meet
standard.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Attachment #66400|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Attachment #58239|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Attachment #70226|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Attachment #71536|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #17 from Katrin Fischer ---
Created attachment 71600
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71600=edit
Bug 17374: (QA follow-up) Update description of syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #16 from Katrin Fischer ---
Created attachment 71599
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71599=edit
Bug 17374: (QA follow-up) Add cardnumber to list of searchable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #14 from Katrin Fischer ---
Created attachment 71597
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71597=edit
Bug 17374: Make use of fields from syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #15 from Katrin Fischer ---
Created attachment 71598
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71598=edit
Bug 17374: (QA follow-up) Skip invalid field names and add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #13 from Katrin Fischer ---
Would have accepted a change to just .pref :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #12 from Nick Clemens ---
Created attachment 71536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71536=edit
Bug 17374: (follow-up) update description of syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #11 from Katrin Fischer ---
Hm, I think now I understand better how this works:
DefaultPatronSearchFields currently defines what is used for the "standard"
search option but doesn't change the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #9 from Nick Clemens ---
Created attachment 70226
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70226=edit
Bug 17374 - Add cardnumber to list of searchable patron fields
To
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #7 from Nick Clemens ---
Created attachment 66400
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66400=edit
Bug 17374 - QA Followup
Skip invlid field names
Add fields to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Marc Véron changed:
What|Removed |Added
Attachment #56958|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Attachment #56931|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Attachment #56921|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
--- Comment #1 from Nick Clemens ---
Created attachment 56921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56921=edit
Bug 17374 - Make use of fields from syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens changed:
What|Removed |Added
Status|NEW
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Marc Véron changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Marc Véron changed:
What|Removed |Added
Depends on||14874
77 matches
Mail list logo