[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #22 from Mirko Tietgen --- (the thinking was if it is possible to support 14.04 while 16.04 has still problems with mysql 5.7, but as mariadb is a working alternative, I don't care about 14.04) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #21 from Mirko Tietgen --- Kyle, I'd drop the idea. It does not make sense to support 14.04 when we drop Wheezy support. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #20 from Kyle M Hall --- (In reply to Mirko Tietgen from comment #19) > Ubuntu 14.04 has libtry-tiny-perl 0.19-1. Can we lower the dependency min > version? Mirko, can you file new bug reports for these requests? If you can supply the patch as well that should help us move it along! If we want to do that for 16.11, we need to move fast! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #19 from Mirko Tietgen --- Ubuntu 14.04 has libtry-tiny-perl 0.19-1. Can we lower the dependency min version? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13995 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Jonathan Druart changed: What|Removed |Added Blocks||17495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17495 [Bug 17495] reports/issues_stats.pl is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall --- Pushed to master for 16.11, thanks Tomas, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Martin Renvoize changed: What|Removed |Added Blocks|17445 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17445 [Bug 17445] REST API: Generic handling of malformed query parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Martin Renvoize changed: What|Removed |Added Blocks||17445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17445 [Bug 17445] REST API: Generic handling of malformed query parameters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56395|0 |1 is obsolete|| --- Comment #17 from Tomás Cohen Arazi --- Created attachment 56461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56461&action=edit Bug 17425: Add the Object::MethodNotCoveredByTests exception Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56394|0 |1 is obsolete|| --- Comment #16 from Tomás Cohen Arazi --- Created attachment 56460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56460&action=edit Bug 17425: Add Try::Tiny dependency This patch just introduces Try::Tiny as a core Koha dependency. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56393|0 |1 is obsolete|| --- Comment #15 from Tomás Cohen Arazi --- Created attachment 56459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56459&action=edit Bug 17425: Make Koha::Object raise exceptions This patch makes Koha::Object raise exceptions in the following situations: - When a non existent accessor is called - When a non existent property is tried to be updated using ->set On implementing this change, we introduce Koha::Exceptions::Object class to contain all Koha::Object-specific exception definitions. Unit tests for this change are introduced in t/db_dependent/Koha/Objects.t To test: - Apply the patches on master - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests return green - Sign off Note: A followup introduces the dependency for Try::Tiny. It needs to be present for running the tests. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Jonathan Druart changed: What|Removed |Added Attachment #56220|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 56393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56393&action=edit Bug 17425: Make Koha::Object raise exceptions This patch makes Koha::Object raise exceptions in the following situations: - When a non existent accessor is called - When a non existent property is tried to be updated using ->set On implementing this change, we introduce Koha::Exceptions::Object class to contain all Koha::Object-specific exception definitions. Unit tests for this change are introduced in t/db_dependent/Koha/Objects.t To test: - Apply the patches on master - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests return green - Sign off Note: A followup introduces the dependency for Try::Tiny. It needs to be present for running the tests. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #14 from Jonathan Druart --- Tomas, please have a look at the third patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Jonathan Druart changed: What|Removed |Added Attachment #56221|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 56394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56394&action=edit Bug 17425: Add Try::Tiny dependency This patch just introduces Try::Tiny as a core Koha dependency. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #13 from Jonathan Druart --- Created attachment 56395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56395&action=edit Bug 17425: Add the Object::MethodNotCoveredByTests exception -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #10 from Jonathan Druart --- Please rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Lari Taskula changed: What|Removed |Added CC||lari.task...@jns.fi --- Comment #9 from Lari Taskula --- After Bug 17226 Applying: Bug 17425: Make Koha::Object raise exceptions Using index info to reconstruct a base tree... M Koha/Object.pm Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: Koha/Exceptions/Object.pm Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 17425: Make Koha::Object raise exceptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Mirko Tietgen changed: What|Removed |Added Keywords||dependency, nowheezy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Mirko Tietgen changed: What|Removed |Added Blocks||17084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 [Bug 17084] Automatic debian/control updates (master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Kyle M Hall changed: What|Removed |Added Attachment #56188|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall --- Created attachment 56221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56221&action=edit Bug 17425: Add Try::Tiny dependency This patch just introduces Try::Tiny as a core Koha dependency. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Kyle M Hall changed: What|Removed |Added Attachment #56187|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 56220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56220&action=edit Bug 17425: Make Koha::Object raise exceptions This patch makes Koha::Object raise exceptions in the following situations: - When a non existent accessor is called - When a non existent property is tried to be updated using ->set On implementing this change, we introduce Koha::Exceptions::Object class to contain all Koha::Object-specific exception definitions. Unit tests for this change are introduced in t/db_dependent/Koha/Objects.t To test: - Apply the patches on master - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests return green - Sign off Note: A followup introduces the dependency for Try::Tiny. It needs to be present for running the tests. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #6 from Mirko Tietgen --- Created attachment 56218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56218&action=edit Bug 17425 Try::Tiny Control file update (master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Josef Moravec changed: What|Removed |Added Attachment #56170|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 56188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56188&action=edit Bug 17425: Add Try::Tiny dependency This patch just introduces Try::Tiny as a core Koha dependency. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 [Bug 17428] REST api: CRUD endpoint for cities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Josef Moravec changed: What|Removed |Added Attachment #56169|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 56187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56187&action=edit Bug 17425: Make Koha::Object raise exceptions This patch makes Koha::Object raise exceptions in the following situations: - When a non existent accessor is called - When a non existent property is tried to be updated using ->set On implementing this change, we introduce Koha::Exceptions::Object class to contain all Koha::Object-specific exception definitions. Unit tests for this change are introduced in t/db_dependent/Koha/Objects.t To test: - Apply the patches on master - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests return green - Sign off Note: A followup introduces the dependency for Try::Tiny. It needs to be present for running the tests. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 56170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56170&action=edit Bug 17425: Add Try::Tiny dependency This patch just introduces Try::Tiny as a core Koha dependency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56168|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 56169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56169&action=edit Bug 17425: Make Koha::Object raise exceptions This patch makes Koha::Object raise exceptions in the following situations: - When a non existent accessor is called - When a non existent property is tried to be updated using ->set On implementing this change, we introduce Koha::Exceptions::Object class to contain all Koha::Object-specific exception definitions. Unit tests for this change are introduced in t/db_dependent/Koha/Objects.t To test: - Apply the patches on master - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests return green - Sign off Note: A followup introduces the dependency for Try::Tiny. It needs to be present for running the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 56168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56168&action=edit Bug 17425: Make Koha::Object raise exceptions This patch makes Koha::Object raise exceptions in the following situations: - When a non existent accessor is called - When a non existent property is tried to be updated using ->set On implementing this change, we introduce Koha::Exceptions::Object class to contain all Koha::Object-specific exception definitions. Unit tests for this change are introduced in t/db_dependent/Koha/Objects.t To test: - Apply the patches on master - Run: $ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests return green - Sign off Note: A followup introduces the dependency for Try::Tiny. It needs to be present for running the tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Depends on||17091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17091 [Bug 17091] Add AUTOLOAD to Koha::Objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17425] Koha::Object should raise exceptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17425 Tomás Cohen Arazi changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
