https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #107 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #106)
> Hum, I had to install the following packages:
> apt install libautovivification-perl libhash-fieldhash-perl
> libfile-slurper-perl
Those a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #106 from Jonathan Druart ---
Hum, I had to install the following packages:
apt install libautovivification-perl libhash-fieldhash-perl
libfile-slurper-perl
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|NEW
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #105 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #76)
> (In reply to Kyle M Hall from comment #66)
> > The big blocker is replacing the use of CGI::Session::Find
> > (https://metacpan.org/pod/CGI::S
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #104 from Jonathan Druart ---
Created attachment 153040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153040&action=edit
Bug 17427: Fix id vs userid in tests
--
You are receiving this mail because:
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #103 from Jonathan Druart ---
Created attachment 153039
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153039&action=edit
Bug 17427: Retrieve sessionID from HTTP_COOKIE
To make some tests pass (t/db_de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #102 from Jonathan Druart ---
Created attachment 153038
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153038&action=edit
Bug 17427: HACKY - force new session
Look at Data::Session->new, it's calling $
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #101 from Jonathan Druart ---
Created attachment 153037
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153037&action=edit
Bug 17427: Remove confusion between session id and param id
FIXME Certainly mor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #100 from Jonathan Druart ---
Created attachment 153036
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153036&action=edit
Bug 17427: Embed Data::Session
Test plan:
Install libdata-session-perl and make
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #99 from Jonathan Druart ---
Created attachment 153035
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153035&action=edit
Bug 17427: Remove SessionStorage mock from tests
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #98 from Jonathan Druart ---
Created attachment 153034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153034&action=edit
Bug 17427: Remove more occurrences of CGI::Session
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #97 from Jonathan Druart ---
Created attachment 153033
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153033&action=edit
Bug 17427: Remove use lines for CGI::Session from Auth.pm
Signed-off-by: Kyle M
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #96 from Jonathan Druart ---
Created attachment 153032
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153032&action=edit
Bug 17427: Use our own YAML::XS serializer
Signed-off-by: Kyle M Hall
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #95 from Jonathan Druart ---
Created attachment 153031
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153031&action=edit
Bug 17427: Use JSON serialization
Signed-off-by: Kyle M Hall
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Attachment #150603|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
David Cook changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #92 from Jonathan Druart ---
(In reply to David Cook from comment #91)
> (In reply to Jonathan Druart from comment #90)
> > (In reply to David Cook from comment #89)
> > > What's outstanding on this one?
> >
> > Read the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #91 from David Cook ---
(In reply to Jonathan Druart from comment #90)
> (In reply to David Cook from comment #89)
> > What's outstanding on this one?
>
> Read the commit messages.
I did and I couldn't make sense of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #90 from Jonathan Druart ---
(In reply to David Cook from comment #89)
> What's outstanding on this one?
Read the commit messages.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #89 from David Cook ---
What's outstanding on this one?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #88 from David Cook ---
(In reply to Jonathan Druart from comment #80)
> Created attachment 150927 [details] [review]
> Bug 17427: Embed Data::Session
>
> Test plan:
> Install libdata-session-perl and make sure our lib h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Keywords|dependency |
--- Comment #87 from Jon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #86 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #73)
> Created attachment 150638 [details] [review]
> Bug 17427: Retrieve sessionID from HTTP_COOKIE
>
> To make some tests pass (t/db_dependent/Auth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #85 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #78)
> After applying the patches and running reset_all in ktd, I get the following
> error when I try to log in:
>
> Data::Session::Driver::mysql::store
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #84 from Jonathan Druart ---
Created attachment 150931
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150931&action=edit
Bug 17427: Fix id vs userid in tests
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #83 from Jonathan Druart ---
Created attachment 150930
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150930&action=edit
Bug 17427: Retrieve sessionID from HTTP_COOKIE
To make some tests pass (t/db_dep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #82 from Jonathan Druart ---
Created attachment 150929
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150929&action=edit
Bug 17427: HACKY - force new session
Look at Data::Session->new, it's calling $s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #81 from Jonathan Druart ---
Created attachment 150928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150928&action=edit
Bug 17427: Remove confusion between session id and param id
FIXME Certainly more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #80 from Jonathan Druart ---
Created attachment 150927
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150927&action=edit
Bug 17427: Embed Data::Session
Test plan:
Install libdata-session-perl and make
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Attachment #150634|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #78 from Kyle M Hall ---
After applying the patches and running reset_all in ktd, I get the following
error when I try to log in:
Data::Session::Driver::mysql::store(): DBI Exception: DBD::mysql::db do failed:
Data too l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|NEW
Assignee|jo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #76 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #66)
> The big blocker is replacing the use of CGI::Session::Find
> (https://metacpan.org/pod/CGI::Session#find(-%5C&code-)) in C4::Auth_with_cas
Yes, th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #75 from Jonathan Druart ---
still 2 tests failing
/kohadevbox/koha/t/db_dependent/Auth.t .. 12/17
# Failed test at /kohadevbox/koha/t/db_dependent/Auth.t line 840.
#
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #74 from Jonathan Druart ---
Created attachment 150639
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150639&action=edit
Bug 17427: Fix id vs userid in tests
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #73 from Jonathan Druart ---
Created attachment 150638
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150638&action=edit
Bug 17427: Retrieve sessionID from HTTP_COOKIE
To make some tests pass (t/db_dep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #72 from Jonathan Druart ---
Created attachment 150637
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150637&action=edit
Bug 17427: HACKY - force new session
Look at Data::Session->new, it's calling $s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #71 from Jonathan Druart ---
Created attachment 150636
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150636&action=edit
Bug 17427: Remove confusion between session id and param id
FIXME Certainly more
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #70 from Jonathan Druart ---
Created attachment 150635
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150635&action=edit
Bug 17427: Embed Data::Session
Test plan:
Install libdata-session-perl and make
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #69 from Jonathan Druart ---
Created attachment 150634
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150634&action=edit
Bug 17427: Remove SessionStorage mock from tests
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #68 from Jonathan Druart ---
Created attachment 150633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150633&action=edit
Bug 17427: Remove more occurrences of CGI::Session
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
Assign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #67 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #61)
> (In reply to Jonathan Druart from comment #59)
> > No, please read the previous comments.
>
> Well, yes, we could, if we embed Data::Session a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #66 from Kyle M Hall ---
The big blocker is replacing the use of CGI::Session::Find
(https://metacpan.org/pod/CGI::Session#find(-%5C&code-)) in C4::Auth_with_cas
--
You are receiving this mail because:
You are the assig
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #65 from Kyle M Hall ---
Created attachment 150606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150606&action=edit
Bug 17427: Remove use lines for CGI::Session from Auth.pm
Signed-off-by: Kyle M Hall
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #64 from Kyle M Hall ---
Created attachment 150605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150605&action=edit
Bug 17427: Use our own YAML::XS serializer
Signed-off-by: Kyle M Hall
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #63 from Kyle M Hall ---
Created attachment 150604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150604&action=edit
Bug 17427: Use JSON serialization
Signed-off-by: Kyle M Hall
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Kyle M Hall changed:
What|Removed |Added
Attachment #150569|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #61 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #59)
> No, please read the previous comments.
Well, yes, we could, if we embed Data::Session and modify it. But why would
we do that?
Isn't the "lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #60 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #59)
> No, please read the previous comments.
Well, yes, we could, if we embed Data::Session and modify it. But what would we
do that?
Isn't the "li
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #59 from Jonathan Druart ---
No, please read the previous comments.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #58 from Tomás Cohen Arazi ---
Can we (In reply to Jonathan Druart from comment #57)
> (In reply to Kyle M Hall from comment #56)
> > I'm getting the error "Data::Session. Unknown serialize 'yamlxs' at
> > /usr/local/shar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #57 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #56)
> I'm getting the error "Data::Session. Unknown serialize 'yamlxs' at
> /usr/local/share/perl/5.32.1/Data/Session.pm line 752".
>
> I installed Data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #56 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||rel_23_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #55 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #53)
> This needs more work to be ready for push:
> * Adjust deps (cpanfile)
> * `git grep CGI::Session` occurrences to be adjusted
> * Remove FIXME
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #54 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #53)
> This needs more work to be ready for push:
> * Adjust deps (cpanfile)
> * `git grep CGI::Session` occurrences to be adjusted
> * Remove FIXMEs from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #53 from Jonathan Druart ---
This needs more work to be ready for push:
* Adjust deps (cpanfile)
* `git grep CGI::Session` occurrences to be adjusted
* Remove FIXMEs from api tests
But please test and tell me if it's wor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
See Also|https://bugs.koha-community |
|.org/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #51 from Jonathan Druart ---
Patches rebased, status back to NSO. Why isn't this ready? What am I missing?
Everything is working correctly in my tests.
--
You are receiving this mail because:
You are watching all bug c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #50 from Jonathan Druart ---
Created attachment 150571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150571&action=edit
Bug 17427: Use our own YAML::XS serializer
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #49 from Jonathan Druart ---
Created attachment 150570
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150570&action=edit
Bug 17427: Use JSON serialization
--
You are receiving this mail because:
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Attachment #121657|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #47 from Jonathan Druart ---
(In reply to David Cook from comment #43)
> (In reply to Jonathan Druart from comment #42)
> > Ok, let's discuss then. What do we do?
> >
> > I am ok with having our module where Data::Session
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #46 from David Cook ---
Marcel suggests writing Koha::Session at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29942#c2
Maybe we should just do that. Jonathan opened this issue nearly 6 years ago and
we stil
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #45 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #44)
> What about https://metacpan.org/pod/MojoX::Session
It hasn't been updated in over 7 years and the developer says he doesn't want
to develop it an
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #44 from Tomás Cohen Arazi ---
What about https://metacpan.org/pod/MojoX::Session
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_11_candidate,|
|RM_pr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #43 from David Cook ---
(In reply to Jonathan Druart from comment #42)
> Ok, let's discuss then. What do we do?
>
> I am ok with having our module where Data::Session is expecting it.
How do you propose to do that in pro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #41 from David Cook ---
(In reply to Jonathan Druart from comment #40)
> > Oh maybe I misunderstand what you're saying... you meant in the vendor perl
> > not the Koha perl lib... right?
>
> Yes, I copied it to /path/Dat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #40 from Jonathan Druart ---
(In reply to David Cook from comment #39)
> (In reply to David Cook from comment #38)
> > (In reply to Jonathan Druart from comment #34)
> > > And, FWIW, if I move the YAML::XS serializer (see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #39 from David Cook ---
(In reply to David Cook from comment #38)
> (In reply to Jonathan Druart from comment #34)
> > And, FWIW, if I move the YAML::XS serializer (see last patch) in the
> > Data/Session/Serialize direct
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #38 from David Cook ---
(In reply to Jonathan Druart from comment #34)
> And, FWIW, if I move the YAML::XS serializer (see last patch) in the
> Data/Session/Serialize directory, all tests pass (longblob).
Wait this works
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #37 from Mason James ---
hi joubu
i've uploaded a libdata-session-perl pkg to koha-staging/dev, for testing
root@kohadevbox:/kohadevbox# apt install libdata-session-perl
Reading package lists... Done
Building dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_21_11_candidate,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #28 from Jonathan Druart ---
JSON serialization does not work (when SessionStorage=tmp), selenium tests from
bug 28489 are failing.
With longblob:
# Failed test 'logged-in-branch-name set - SessionStorage=mysql,
br
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Depends on|28489 |28519
--- Comment #36 fro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #34 from Jonathan Druart ---
And, FWIW, if I move the YAML::XS serializer (see last patch) in the
Data/Session/Serialize directory, all tests pass (longblob).
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #33 from Jonathan Druart ---
Created attachment 121659
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121659&action=edit
Bug 17427: Use our own YAML::XS serializer
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #32 from Jonathan Druart ---
Created attachment 121658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121658&action=edit
Bug 17427: Use JSON serialization
--
You are receiving this mail because:
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Attachment #121337|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #35 from David Cook ---
(In reply to Jonathan Druart from comment #34)
> And, FWIW, if I move the YAML::XS serializer (see last patch) in the
> Data/Session/Serialize directory, all tests pass (longblob).
Does this have
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #30 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #28)
This comment was confusing, with JSON serialization we have:
With longtext it's working with SessionStorage=mysql
With longblob it's failing wit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #29 from Jonathan Druart ---
And it's not possible to add a serializer that is not in the same dir as
others, because of this code in Data::Session:
318 sub get_my_serializers
319 {
320 my($self) = @_;
321
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
Jonathan Druart changed:
What|Removed |Added
Depends on||28489
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #27 from Katrin Fischer ---
Bug 28517 might be related to this?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #26 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #25)
> However there is still an issue if SessionStorage=tmp file
root@kohadevbox$ more
/var/lib/koha/kohadev/tmp/cgisess_koha_kohadev/cgisess_6967e
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #25 from Jonathan Druart ---
We are now aiming to provide a long-term solution for the encoding issue found
on bug 28489.
Using Data::Session using the JSON serializer seems to be the more robust
solution.
However there
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #24 from Jonathan Druart ---
Created attachment 121633
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121633&action=edit
Bug 17427: Use JSON serialization
--
You are receiving this mail because:
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427
--- Comment #23 from Jonathan Druart ---
(In reply to David Cook from comment #22)
> (In reply to Jonathan Druart from comment #21)
> > (patch rebased)
>
> Should this be "Needs Signoff" now?
I rebased it to see if it fixed bug 281
1 - 100 of 131 matches
Mail list logo
