[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436
Bug 17436 depends on bug 23838, which changed state.

Bug 23838 Summary: Add ability to view item renew history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838

   What|Removed |Added

 Status|Needs documenting   |CLOSED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

 CC|bugzi...@warmlight.co.uk|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #8 from Martin Renvoize  ---
I think with the subsequent work on bug 23838 and friends this is probably
fully covered..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

  Change sponsored?|Sponsored   |---
 Depends on||23838

--- Comment #7 from Andrew Isherwood  ---
It turns out that the development I have carried out for our customer, although
similar to the requirements specified in this bug, has more basic requirements.
Our customer simply wants to be able to click a link next to the renewal count
and view details of renewal date and who the renewal was carried out by, all of
which is currently recorded when the RenewalLog syspref is enabled.

The requirements specified in this bug would require more work as the
information they wish to display is not currently recorded.

Consequently, I have create a new bug (Bug 23838) where I will attach the
patches and test plan for the work I have done. Hopefully that work will ease
the path for whoever tackles this bug. I will make this bug dependent on 23838.

Apologies for the confusion!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
[Bug 23838] Add ability to view item renew history
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #6 from Andrew Isherwood  ---
Ignore those patches and the test plan. I just realised there's something
missing. Apologies!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94392|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94393|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94391|0   |1
is obsolete||

--- Comment #4 from Andrew Isherwood  ---
Created attachment 94393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94393=edit
Bug 17436: Add renewals modal

This patch adds the display of the renewals modal when appropriate. A
"View" link is displayed next to renewals that have logs associated with
them. Clicking the link opens the modal that displays the logged
renewals.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com
  Change sponsored?|--- |Sponsored
 Status|NEW |Needs Signoff

--- Comment #5 from Andrew Isherwood  ---
Test plan
-

- Apply the patch
- Navigate to Koha administration and locate the "RenewalLog" syspref
- Ensure the syspref is initially set to "Don't log"
- Navigate to Patrons
- Find a patron with at least one loan, or loan an item to a patron
- Renew an item that is on loan, feel free to do this a few times
- Click "Circulation history"
- TEST: Observe that the item renewal count is displayed but it is not possible
to view details of the renewals
- Navigate to Koha administration and locate the "RenewalLog" syspref
- Set the syspref to "Log"
- Return to the patron's loans
- Renew the item a few more times
- Click "Circulation history"
- TEST: Note that the renewal count has increased appropriately, and there is
now a "View" link
- Click the "View" link
- TEST: Observe that an "Item renewals" modal appears containing details of the
renewals
- TEST: Observe that, since not all renewals were logged, information about
what proportion of renewals were logged is displayed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #94390|0   |1
is obsolete||

--- Comment #3 from Andrew Isherwood  ---
Created attachment 94392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94392=edit
Bug 17436: Add 'renewals' API route

This patch adds a /patrons/x/renewals API GET route which returns a patron's
renewals, optionally filtered by item_id. Tests are also included

Sponsored-by: Loughborough University

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

--- Comment #1 from Andrew Isherwood  ---
Created attachment 94390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94390=edit
Bug 17436: Add 'renewals' API route

This patch adds a /patrons/x/renewals API GET route which returns a patron's
renewals, optionally filtered by item_id. Tests are also included

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

--- Comment #2 from Andrew Isherwood  ---
Created attachment 94391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94391=edit
Bug 17436: Add renewals modal

This patch adds the display of the renewals modal when appropriate. A
"View" link is displayed next to renewals that have logs associated with
them. Clicking the link opens the modal that displays the logged
renewals.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17436] Add a way to know in patron module where renew of an item was made

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/