[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #6 from Marcel de Rooy --- Created attachment 58524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58524&action=edit Bug 17447: Remove unused vars from batchRebuildItemsTables.pl Variables $extkey not used, %opt not used. Variables $tmptest[...] not used, calling _build_tag_directory useless. The script now does not only print help if you specify -t. Sub defnonull tidied. Rearranged modules, removed Dumper. Test plan: [1] Run the script with -t flag. The script should not only print usage statement, but should do a dry run. (Test this on a small database, or pass an additional where clause.) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Attachment #56578|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 58523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58523&action=edit Bug 17447: Run perltidy on batchRebuildItemsTables.pl Test plan: Verify that the output of diff -w between the original and tidied file does not introduce code changes. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #4 from Marcel de Rooy --- (In reply to M. Tompsett from comment #3) > > my $starttime = gettimeofday; > > my @errors; > > my %opt; > > Is this even used? The first two are used, the third is not. Removing it now too. > Tweaks and whitespace changes should be separate commits to make it easier > to check. So true :) Added a perltidy patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #3 from M. Tompsett --- Comment on attachment 56578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56578 Bug 17447: Housekeeping: Tidy up misc/batchRebuildItemsTables.pl Review of attachment 56578: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17447&attachment=56578) - ::: misc/batchRebuildItemsTables.pl @@ +35,3 @@ > my $starttime = gettimeofday; > my @errors; > my %opt; Is this even used? @@ +43,4 @@ > 'where:s' => \$where, > ) or pod2usage(2); > > +pod2usage(1) if $help || ( !$confirm && !$test_parameter ); Tweaks and whitespace changes should be separate commits to make it easier to check. git diff -w origin/master pointed out this and a couple others. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Attachment #56516|0 |1 is obsolete|| --- Comment #2 from Marcel de Rooy --- Created attachment 56578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56578&action=edit Bug 17447: Housekeeping: Tidy up misc/batchRebuildItemsTables.pl This script contained lots of complete if blocks on one line. In this patch a lot of whitespace has been moved around. A line with a call to _build_tag_directory has been removed; the results were discarded. Variable $extkey was not used either. The script now does not only print help if you specify -t. Test plan: Run the script. Do not test on production data! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 --- Comment #1 from Marcel de Rooy --- Created attachment 56516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56516&action=edit Bug 17447: Housekeeping: Tidy up misc/batchRebuildItemsTables.pl This script contained lots of complete if blocks on one line. In this patch a lot of whitespace has been moved around. A line with a call to _build_tag_directory has been removed; the results were discarded. Variable $extkey was not used either. The script now does not only print help if you specify -t. Test plan: Run the script. Do not test on production data! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17447] Housekeeping: Tidy up misc/batchRebuildItemsTables.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17447 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
