[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #33 from Katrin Fischer --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #32 from Kyle M Hall --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Attachment #57913|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart --- Created attachment 58483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58483&action=edit Bug 17569: [QA Follow-up] Small changes Patron.pm: Adds two missing semicolons at the last statement. Not strictly needed, but strongly recommended. Patrons.t: Add a test description, remove two comments that refer to previously hardcoded dates. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Attachment #57912|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 58482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58482&action=edit Bug 17569: Do not limit by branch if option is not passed Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Attachment #57910|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 58480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58480&action=edit Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Attachment #57911|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart --- Created attachment 58481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58481&action=edit Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Attachment #57908|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 58478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58478&action=edit Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Attachment #57909|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart --- Created attachment 58479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58479&action=edit Bug 17569: Move tests to the patron module test file Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Bug 17569 depends on bug 17568, which changed state. Bug 17568 Summary: Add the Koha::Patron->library method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17568 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Version|unspecified |master --- Comment #25 from Marcel de Rooy --- QA Comment: sub search_upcoming_membership_expires The mix of before/after and search options in the parameters does not really look good to me. (No blocker, but source for future problems when someone adds stuff and is not careful.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Attachment #57897|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 57911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57911&action=edit Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Attachment #57898|0 |1 is obsolete|| --- Comment #23 from Marcel de Rooy --- Created attachment 57912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57912&action=edit Bug 17569: Do not limit by branch if option is not passed Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #24 from Marcel de Rooy --- Created attachment 57913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57913&action=edit Bug 17569: [QA Follow-up] Small changes Patron.pm: Adds two missing semicolons at the last statement. Not strictly needed, but strongly recommended. Patrons.t: Add a test description, remove two comments that refer to previously hardcoded dates. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Attachment #57895|0 |1 is obsolete|| --- Comment #20 from Marcel de Rooy --- Created attachment 57909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57909&action=edit Bug 17569: Move tests to the patron module test file Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Attachment #57894|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 57908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57908&action=edit Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Attachment #57896|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 57910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57910&action=edit Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #17 from Jonathan Druart --- Created attachment 57897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57897&action=edit Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #18 from Jonathan Druart --- Created attachment 57898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57898&action=edit Bug 17569: Do not limit by branch if option is not passed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #15 from Jonathan Druart --- Created attachment 57895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57895&action=edit Bug 17569: Move tests to the patron module test file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #16 from Jonathan Druart --- Created attachment 57896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57896&action=edit Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Attachment #57315|0 |1 is obsolete|| Attachment #57316|0 |1 is obsolete|| Attachment #57317|0 |1 is obsolete|| Attachment #57318|0 |1 is obsolete|| Attachment #57319|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 57894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57894&action=edit Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #13 from Marcel de Rooy --- Applied dependency 17568 first. Applying: Bug 17569: Move tests to the patron module test file fatal: sha1 information is lacking or useless (t/db_dependent/Koha/Patrons.t). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #12 from Josef Moravec --- Created attachment 57319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57319&action=edit [SIGNED-OFF] Bug 17569: Do not limit by branch if option is not passed Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #9 from Josef Moravec --- Created attachment 57316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57316&action=edit [SIGNED-OFF] Bug 17569: Move tests to the patron module test file Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #11 from Josef Moravec --- Created attachment 57318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57318&action=edit [SIGNED-OFF] Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Josef Moravec changed: What|Removed |Added Attachment #57265|0 |1 is obsolete|| Attachment #57266|0 |1 is obsolete|| Attachment #57267|0 |1 is obsolete|| Attachment #57294|0 |1 is obsolete|| Attachment #57295|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 57315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57315&action=edit [SIGNED-OFF] Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #10 from Josef Moravec --- Created attachment 57317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57317&action=edit [SIGNED-OFF] Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #7 from Jonathan Druart --- Fixed Josef, thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #6 from Jonathan Druart --- Created attachment 57295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57295&action=edit Bug 17569: Do not limit by branch if option is not passed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #5 from Jonathan Druart --- Created attachment 57294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57294&action=edit Bug 17569: Remove C4::Members::GetUpcomingMembershipExpires -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #4 from Josef Moravec --- Are you going to remove C4::Members::GetUpcomingMembershipExpires sub? I can't see it in patchset. Also, the membership_expiry.pl script works fine, when you specify branch, but without branch, it should search for patrons in all branches, but always returns 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #3 from Jonathan Druart --- Created attachment 57267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57267&action=edit Bug 17569: Koha::Patrons - Move GetUpcomingMembershipExpires to search_upcoming_membership_expires This patchset moves the C4::Members::GetUpcomingMembershipExpires subroutine code to the Koha::Patrons->search_upcoming_membership_expires method. This subroutine was used from only 1 place, so it's an easier to move. Test plan: Use the membership_expiry.pl cronjob script using the different options. The behavior should be the same as prior to this patch. prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #2 from Jonathan Druart --- Created attachment 57266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57266&action=edit Bug 17569: Move tests to the patron module test file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17569] Move GetUpcomingMembershipExpires to Koha::Patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17569 --- Comment #1 from Jonathan Druart --- Created attachment 57265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57265&action=edit Bug 17569: Rewrite existing tests to make them reusable and more robust In order not to cheat you, I am rewriting the tests in a separate commit. You can confirm that they pass with the other patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
