[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|14825 |23894 Status|BLOCKED |Needs Signoff Depends on|23894 | --- Comment #24 from Martin Renvoize --- Thanks for taking this on Julian, I'll just reverse the dependencies and we can unblock this one, it's great to see a new face taking an interest in this work. I'll give it a test later today :) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #23 from Julian Maurice --- Not sure if it should still be BLOCKED, or if it is the right bug for this patch. Martin, can you take a look please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #22 from Julian Maurice --- Created attachment 98564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98564&action=edit Bug 17702: Add UI to manage account credit types It is the same as for debit types. It adds a new column `archived` in table `account_credit_types` that has the same purpose than `account_debit_types.archived` Test plan: 0. Apply patch && run updatedatabase && update_dbix_class_files 1. Go to Admin » Credit types 2. Add a new credit type, give it a code and a description and check 'Can be manually added' 3. Go to a patron's accounting section, 'Create manual credit' tab 4. Verify that the new credit type appears 5. Return to Admin » Credit types and archive the credit type 6. Verify that the new credit type is not available anymore in 'Create manual credit' 7. Restore the credit type and verify that it is available again 8. Create a manual credit with the new credit type 9. Go to Reports » Cash register and make sure you can find the transaction by filtering on transaction type 10. Edit the new credit type and set some library limitations, make sure that the credit type doesn't appear if you're connected to a library you didn't selected, and that it appears if you're connected to a library you selected. Note to QA team: The change in Koha/Account.pm, I added it because otherwise Koha died when adding a manual credit with a custom type. In that case, offset type will default to 'Manual Credit'. I'm not sure if that is the best thing to do. I'm open to suggestions :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|23049 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|17596 |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|23805 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||23894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23049 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #21 from Martin Renvoize --- The combination of bug 23049 and bug 23805 resolves 90% of this enhancement report. What is missing is the UI for account credits. I chose not to implement the UI for account credit definitions as part of bug 23805 as at the time of writing all credit types are hard coded in Koha. I do wonder if we still require the 'PAYMENT_TYPE' authorized value and corresponding accountlines field however. It feels like that should be merged into account_credit_types and then a UI exposed much like the account_debit_type management page introduced in but 23049. As such, I'm leaving this bug open awaiting those next steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #85874|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Assignee|josef.mora...@gmail.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #85877|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #85875|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #85876|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||23805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23049 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|23046 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 [Bug 23046] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|21739 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739 [Bug 21739] 'Copier fees' should not be used as accounttype on maninvoice.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|22393 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|22610 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|22510 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Bug 17702 depends on bug 22510, which changed state. Bug 22510 Summary: 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Bug 17702 depends on bug 22510, which changed state. Bug 22510 Summary: 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Bug 17702 depends on bug 22510, which changed state. Bug 22510 Summary: 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|23047 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 [Bug 23047] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks||23046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046 [Bug 23046] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|6759| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 [Bug 6759] Use a different account type for account renewals than for new accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks||23047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23047 [Bug 23047] Add tax handling to accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #20 from Martin Renvoize --- Probably the best way to get this one moving again at this point is for someone to follow the dependencies down from bug 22200. I think I've added reasonable test plans to each of the bugs now so they should be reasonably clear. I intend to get back onto this bug in earnest very shortly, but I have my doubts that it'll make it into 19.05 at this stage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #19 from Michal Denar --- Hi Martin, we want this feature too. So, I'm ready for testing. Just set status if follow-up will be ready. Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #18 from Martin Renvoize --- Sorry, this one isn't ready at all for testing yet I'm afraid. I've been working through the tree of bugs above it and may will split this one up a little further too once a few more of those foundations are closer to being in. Don't worry, I've certainly not forgotten this one though, we have lots of customers very eager to see it too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #17 from Michal Denar --- I tried test this patch but there're some problem with depencies. Applying: Bug 22511: Update tests Applying: Bug 22511: Update void method to use status Applying: Bug 22511: Update UI to use accountlines.status error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 22511: Update UI to use accountlines.status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #16 from Michal Denar --- Hi Martin, it's ready for testing? Thank You. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|11573 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 [Bug 11573] Fine descriptions related to Rentals are untranslatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||6759 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 [Bug 6759] Use a different account type for account renewals than for new accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||11573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 [Bug 11573] Fine descriptions related to Rentals are untranslatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|21683 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|22511 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Bug 17702 depends on bug 21683, which changed state. Bug 21683 Summary: Remove accountlines.accountno https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Bug 17702 depends on bug 22510, which changed state. Bug 22510 Summary: 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks||21739 Depends on|21739 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739 [Bug 21739] 'Copier fees' should not be used as accounttype on maninvoice.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||22510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks||13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on|20912 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 [Bug 20912] Rental fees based on time period -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||20912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 [Bug 20912] Rental fees based on time period -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #58066|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 85877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85877&action=edit Bug 17702: Add tests Test plan: prove t/db_dependent/Koha/AccountTypes.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #57858|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 85876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85876&action=edit Bug 17702: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Account types page in Patrons and circulation section 2) Go to any other admin page and confirm there is link to Account types in admin menu as welll 3) Go to Account types page 4) You should see two datatables, one for debit types and one for credit types, ensure the datatables are working corectly 5) Try to create, edit and delete some debit types, note, that some of them can't be deleted - they are neede for Koha internally 6) Do the same with credit types 7) Try to add some default amount to internal debits - like Acccount management fee, New card, ... 8) Go to Patron fines page and play with account type select, when you change thy account type, the description and amount should change as you set it on the admin page 9) Try to add some fees and ensure they are inserted corectly 10) Pay the inserted fees 11) Try to add manual credit and ensure it is added corectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #57857|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 85875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85875&action=edit Bug 17702: Account types configuration - Manual invoice and credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Attachment #57856|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 85874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85874&action=edit Bug 17702: Account types configuration - db changes Test plan: 1) Read the diff and confirm that it does make sense 2) Comment what does not make sense ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|21739 | Depends on||21739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739 [Bug 21739] 'Copier fees' should not be used as accounttype on maninvoice.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks||22393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks||21739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739 [Bug 21739] 'Copier fees' should not be used as accounttype on maninvoice.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added Depends on||21683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #11 from Josef Moravec --- (In reply to Radek Šiman (R-Bit Technology, s.r.o.) from comment #9) > (In reply to Josef Moravec from comment #1) > > Created attachment 57856 [details] [review] [review] > > Bug 17702: Account types configuration - db changes > > > > Test plan: > > 1) Read the diff and confirm that it does make sense > > 2) Comment what does not make sense ;) > > According to db changes, is it possible to extend type_code from only 5 > chars to (let's say) 10 chars? It would be very useful for some libraries > having a longer list of payments not to be so cryptic. For instance, one of > them (Czech only - sorry): I have no problem with this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #10 from Josef Moravec --- (In reply to Chris Kirby from comment #8) > (In reply to comment #7), > Hi Josef, thanks for the tip to upgrade the db schema. > > When one creates a "manual invoice" for a patron using one of the created > debit types, both the debit type code and the description are entered into > the "Description of charges." However, for the pre-existing debit types, the > debit type description is entered twice in the "description of charges". > Is there any reason for this difference? It's a bug, I am going to work on this a bit more... > When one creates a credit type, there is no field for default amount. Is > there any reason for leaving a default amount out of the credit type but > keeping it in the debit? Yes, the reason is, the when you are creating manual invoice, you often know the price of some kind of things, but you can't pretend which amount are people going to pay, or so... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #9 from Radek Šiman (R-Bit Technology, s.r.o.) --- (In reply to Josef Moravec from comment #1) > Created attachment 57856 [details] [review] > Bug 17702: Account types configuration - db changes > > Test plan: > 1) Read the diff and confirm that it does make sense > 2) Comment what does not make sense ;) According to db changes, is it possible to extend type_code from only 5 chars to (let's say) 10 chars? It would be very useful for some libraries having a longer list of payments not to be so cryptic. For instance, one of them (Czech only - sorry): mvs 50|MVS tA4 3|Tisk a kopie A4 t2sA4 4|Tisk a kopie A4 oboustranně toA46|Tisk a kopie A4 + obrázek tbA415|Celobarevná A4 t20A4 2|Tisk a kopie A4 nad 20 kusů s20A4 3|Tisk a kopie A4 oboustranně nad 20 kusů b20A4 10|Tisk a kopie A4 barevně nad 20 kusů tA3 5|Tisk a kopie A3 t2sA3 7|Tisk a kopie A3 oboustranně toA310|Tisk a kopie A3 + obrázek tbA325|Celobarevná A3 t20A3 3|Tisk a kopie A3 nad 20 kusů s20A3 5|Tisk a kopie A3 oboustranně nad 20 kusů b20A3 20|Tisk a kopie A3 barevně nad 20 kusů sken7|skenování eursl 3|eurosložka papsl 5|papírová složka taskm 3|taška malá taskv 5|taška velká prodj ?|prodej plack ?|placky eshop ?|e-shop poukaz 110|Poukaz na registraci REZER 10|Rezervace (ručně) pspec 2|Papír speciál -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #8 from Chris Kirby --- (In reply to comment #7), Hi Josef, thanks for the tip to upgrade the db schema. When one creates a "manual invoice" for a patron using one of the created debit types, both the debit type code and the description are entered into the "Description of charges." However, for the pre-existing debit types, the debit type description is entered twice in the "description of charges". Is there any reason for this difference? When one creates a credit type, there is no field for default amount. Is there any reason for leaving a default amount out of the credit type but keeping it in the debit? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #7 from Josef Moravec --- (In reply to Chris Kirby from comment #6) > Hi Josef, > When I tried to add a new debit type, I got the following error: > DBIx::Class::Storage::DBI::_dbh_execute(): Table > 'koha_mykoha.account_debit_types' doesn't exist at > /home/ckirby/koha/Koha/Objects.pm line 83 Did you upgrade your db schema? I forget to mention it in test plan, sorry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Chris Kirby changed: What|Removed |Added CC||chris.kirby@ilsleypubliclib ||rary.org --- Comment #6 from Chris Kirby --- Hi Josef, When I tried to add a new debit type, I got the following error: DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_mykoha.account_debit_types' doesn't exist at /home/ckirby/koha/Koha/Objects.pm line 83 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #5 from Josef Moravec --- Created attachment 58066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58066&action=edit Bug 17702: Add tests Test plan: prove t/db_dependent/Koha/AccountTypes.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #4 from Josef Moravec --- I attached my current work, but stay with ASSIGNED status till I write tests ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #1 from Josef Moravec --- Created attachment 57856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57856&action=edit Bug 17702: Account types configuration - db changes Test plan: 1) Read the diff and confirm that it does make sense 2) Comment what does not make sense ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #3 from Josef Moravec --- Created attachment 57858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57858&action=edit Bug 17702: Account types configuration - Admin page Test plan: 1) Go to admin home, note there is new Account types page in Patrons and circulation section 2) Go to any other admin page and confirm there is link to Account types in admin menu as welll 3) Go to Account types page 4) You should see two datatables, one for debit types and one for credit types, ensure the datatables are working corectly 5) Try to create, edit and delete some debit types, note, that some of them can't be deleted - they are neede for Koha internally 6) Do the same with credit types 7) Try to add some default amount to internal debits - like Acccount management fee, New card, ... 8) Go to Patron fines page and play with account type select, when you change thy account type, the description and amount should change as you set it on the admin page 9) Try to add some fees and ensure they are inserted corectly 10) Pay the inserted fees 11) Try to add manual credit and ensure it is added corectly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 --- Comment #2 from Josef Moravec --- Created attachment 57857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57857&action=edit Bug 17702: Account types configuration - Manual invoice and credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17702] Create configuration for account types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Patch complexity|--- |Small patch Status|NEW |ASSIGNED Blocks||17596, 14825 CC||blac...@gmail.com, ||r...@rbit.cz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/