[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-03-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #4 from Katrin Fischer  ---
Hi Zoe, small thing: I filed this for the result page - can you change the
title of the bug to match your changes and maybe file a new one for the result
list page if the problem still shows there? The titles of bugs are used for the
release notes, so it's always good to give a good description.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Zoe Bennett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #3 from Zoe Bennett  ---
Created attachment 70662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70662&action=edit
Bug 17765: Changed variable $flags to $userflags to eliminate the issue of
masking declaration in the same scope. Hides 'Holds' link on the 'Details' and
'Checkout' pages when the user does not have the permission to
'reserveforothers'.

Test Plan:
1) With a user who has the permission to 'reserveforothers' check that the
'Holds' link is on the 'Details' and 'Check out' pages
2) Then with a user who does not have the permission to 'reserveforothers'
check that on the 'Details' and 'Check out' pages there is no longer the
'Holds' link next to the 'Checkouts' and 'Fines & Charges' tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #2 from Owen Leonard  ---
I'm not sure if this is ready for testing or not, but in it's current state it
doesn't work for me:

"my" variable $flags masks earlier declaration in same scope at
/home/vagrant/kohaclone/circ/circulation.pl line 464. Can't call method "flags"
on an undefined value at /home/vagrant/kohaclone/circ/circulation.pl line 179.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2018-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

--- Comment #1 from Zoe Bennett  ---
Created attachment 70584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70584&action=edit
Bug 17765: Hid 'Holds' link on the 'Details' and 'Checkout' pages when the user
does not have the permission to 'reserveforothers'.

Test Plan:
1) With a user who has the permission to 'reserveforothers' check that the
'Holds' link is on the 'Details' and 'Check out' pages
2) Then with a user who does not have the permission to 'reserveforothers'
check that on the 'Details' and 'Check out' pages there is no longer the
'Holds' link next to the 'Checkouts' and 'Fines & Charges' tabs.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17765] Hide 'Holds' link in staff result list when user has no permission to place holds

2017-06-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/