[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #41 from Nick Clemens --- Enhancement, not backported to 17.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #40 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|m...@kohaaloha.com Keywords|dependency | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #39 from Jonathan Druart --- Created attachment 73403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73403&action=edit Bug 18055: The 2 new deps are used for testing purpose -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Mason James changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #38 from Mason James --- (In reply to Jonathan Druart from comment #30) > (In reply to Jonathan Druart from comment #29) > > Solved! > I upgraded Test::Simple from 1.001014 to 1.302075 and the tests now pass! Hi Jonathan Mirko has packaged libtest-simple-perl in BZ-18993 (resolved) ..therefore this bug can be switched back to PASSED-QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m Assignee|baptiste.wojtkowski@biblibr |ch...@bigballofwax.co.nz |e.com | --- Comment #37 from Victor Grousset/tuxayo --- Baptiste doesn't work anymore at BibLibre. Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Bug 18055 depends on bug 18993, which changed state. Bug 18993 Summary: Bump libtest-simple-perl to 1.302073 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Jonathan Druart changed: What|Removed |Added Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tomás Cohen Arazi changed: What|Removed |Added CC||mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #36 from Tomás Cohen Arazi --- I removed the changes to debian/control from the first patch. That file is actually generated and we shuold leave that to Mirko. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 66771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66771&action=edit Bug 18055: (QA followup) Only print output if DEBUG Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tomás Cohen Arazi changed: What|Removed |Added Attachment #64322|0 |1 is obsolete|| --- Comment #34 from Tomás Cohen Arazi --- Created attachment 66770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66770&action=edit Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager add KOHA_PROVE_CPUS envar to manually set number of cpus to test.. 1/ set number of cpus to 1 $ export KOHA_PROVE_CPUS=1 2/ observe 1 cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 1 CPUs... 3/ unset number of cpus $ export KOHA_PROVE_CPUS= 4/ observe all available cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 32 CPUs... Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tomás Cohen Arazi changed: What|Removed |Added Attachment #63341|0 |1 is obsolete|| --- Comment #33 from Tomás Cohen Arazi --- Created attachment 66769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66769&action=edit Bug 18055: Speed up '00-strict.t' test, with Parallel::ForkManager to test... 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real16m34.104s 2/ apply patch 3/ install Parallel::ForkManager package $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl 4/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real6m4.355s Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Edit: removed debian/control changes as the file is generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Jonathan Druart changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Kyle M Hall changed: What|Removed |Added Status|Signed Off |BLOCKED CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tomás Cohen Arazi changed: What|Removed |Added Keywords||dependency -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|gmcha...@gmail.com |tomasco...@gmail.com CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Mason James changed: What|Removed |Added Depends on||18993 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18993 [Bug 18993] Bump libtest-simple-perl to 1.302075 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #32 from Jonathan Druart --- (In reply to Jonathan Druart from comment #28) > Could we use the same method for > t/00-testcritic.t, => Not needed, from the POD: all_critic_ok() is also optimized to run tests in parallel over multiple cores (if you have them) so it is usually better to call this function than calling critic_ok() directly. > t/00-merge-conflict-markers.t, => Not efficient. > xt/author/valid-templates.t and => See bug 18979 > xt/author/translatable-templates.t => Fork already -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Jonathan Druart changed: What|Removed |Added Blocks||18979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 [Bug 18979] Speed up 'valid-templates.t' tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #31 from Jonathan Druart --- Master, with 4 dirs acqui, admin, authorities, basket: real2m17.136s user2m8.156s sys 0m8.184s Master + these patches, same dirs: real1m10.204s user2m28.904s sys 0m8.720s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #30 from Jonathan Druart --- (In reply to Jonathan Druart from comment #29) Solved! I upgraded Test::Simple from 1.001014 to 1.302075 and the tests now pass! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #29 from Jonathan Druart --- Something is wrong for me: Inside the a kohadevbox, I have only 1 CPU, so no speed up noticed. >From the host, 4 CPUs (I launched the tests 00-strict.t with only the admin and acqui dirs): time perl t/db_dependent/00-strict.t Using 4 CPUs... ok 1 - Syntax check admin/systempreferences.pl ok 1 - Syntax check acqui/z3950_search.pl ok 2 - Syntax check admin/cities.pl ok 2 - Syntax check acqui/neworderbiblio.pl ok 3 - Syntax check admin/edi_accounts.pl ok 3 - Syntax check acqui/edi_ean.pl [SKIP] ok 48 - Syntax check admin/auth_subfields_structure.pl ok 49 - Syntax check admin/currency.pl ok 50 - Syntax check admin/searchengine/elasticsearch/mappings.pl 1..0 # No tests run! real1m0.178s user1m44.540s sys 0m6.592s => This is ok But, with prove: $ prove t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. 50/? # No tests run! t/db_dependent/00-strict.t .. skipped: (no reason given) Test Summary Report --- t/db_dependent/00-strict.t (Wstat: 65280 Tests: 92 Failed: 0) Non-zero exit status: 255 Parse errors: Tests out of sequence. Found (1) but expected (2) Tests out of sequence. Found (2) but expected (3) Tests out of sequence. Found (2) but expected (4) Tests out of sequence. Found (3) but expected (5) Tests out of sequence. Found (3) but expected (6) Displayed the first 5 of 92 TAP syntax errors. Re-run prove with the -p option to see them all. Files=1, Tests=92, 63 wallclock secs ( 0.04 usr 0.02 sys + 110.22 cusr 6.87 csys = 117.15 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #26 from Mason James --- Created attachment 64322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64322&action=edit Bug 18055 - Speed up '00-strict.t' test, with Parallel::ForkManager add KOHA_PROVE_CPUS envar to manually set number of cpus to test.. 1/ set number of cpus to 1 $ export KOHA_PROVE_CPUS=1 2/ observe 1 cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 1 CPUs... 3/ unset number of cpus $ export KOHA_PROVE_CPUS= 4/ observe all available cpus are used $ time prove -v t/db_dependent/00-strict.t t/db_dependent/00-strict.t .. Using 32 CPUs... --- Comment #27 from Mason James --- (In reply to Mason James from comment #21) > (In reply to Olli-Antti Kivilahti from comment #19) > > Hi! > > > > Pretty good improvement. > > > > What concerns me is how well does this module detect the available CPU > > cores? > > > > For example on LXC all the cores are visible to the test runner. > > > > There can be resource limits, but we might get a situation where we fork 32 > > test runners because the LXC container is ran on a server with 32 cores. > > However resource limits prevent utilization of more than 4 on this > > LXC-container. > > > > This is not good. > > Olli, We can add an enviroment variable to manually limit the number of > CPUS, to handle your situation > > I can add a patch for that, no problem I've added this patch --- Comment #28 from Jonathan Druart --- Could we use the same method for t/00-testcritic.t, t/00-merge-conflict-markers.t, xt/author/valid-templates.t and xt/author/translatable-templates.t as well? Any volunteers? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Marcel de Rooy changed: What|Removed |Added Severity|normal |enhancement CC||m.de.r...@rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- Marking this as an enhancement rather than a bugfix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Josef Moravec changed: What|Removed |Added Attachment #59902|0 |1 is obsolete|| --- Comment #24 from Josef Moravec --- Created attachment 63341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63341&action=edit [SIGNED-OFF] Bug 18055 - Speed up '00-strict.t' test, with Parallel::ForkManager to test... 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real16m34.104s 2/ apply patch 3/ install Parallel::ForkManager package $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl 4/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real6m4.355s Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #23 from M. Tompsett --- (In reply to Mason James from comment #22) > (In reply to Owen Leonard from comment #20) > > Based on the last two comments I think this should be Failed QA. > > hi Owen, > Mark's comment refers to an obsoleted patch > > it's not relevant Correct, though this patch does NOT run correctly for me. The tests don't test in order properly for me, which triggers a failure. As noted in comment #8. If others are able to replicate comment #11 output, then I have no issue with this moving forward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #22 from Mason James --- (In reply to Owen Leonard from comment #20) > Based on the last two comments I think this should be Failed QA. hi Owen, Mark's comment refers to an obsoleted patch it's not relevant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #21 from Mason James --- (In reply to Olli-Antti Kivilahti from comment #19) > Hi! > > Pretty good improvement. > > What concerns me is how well does this module detect the available CPU cores? > > For example on LXC all the cores are visible to the test runner. > > There can be resource limits, but we might get a situation where we fork 32 > test runners because the LXC container is ran on a server with 32 cores. > However resource limits prevent utilization of more than 4 on this > LXC-container. > > This is not good. Olli, We can add an enviroment variable to manually limit the number of CPUS, to handle your situation I can add a patch for that, no problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20 from Owen Leonard --- Based on the last two comments I think this should be Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Baptiste changed: What|Removed |Added Assignee|m...@kohaaloha.com |baptiste.wojtkowski@biblibr ||e.com CC||baptiste.wojtkowski@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #19 from Olli-Antti Kivilahti --- Hi! Pretty good improvement. What concerns me is how well does this module detect the available CPU cores? For example on LXC all the cores are visible to the test runner. There can be resource limits, but we might get a situation where we fork 32 test runners because the LXC container is ran on a server with 32 cores. However resource limits prevent utilization of more than 4 on this LXC-container. This is not good. Maybe a better solution would be to accelerate the whole test running infrastructure. I am not seeing anything in t or $KOHA_PATH which would allow to easily run all Koha's tests, but I have been working on something like Bug 18238. Parallelizing the test runs makes sense in this bigger context, but needs multiple parallel test databases and KOHA_CONF's and is generally a big hassle and prone to all kinds of strange race condition errors. Maybe it is better to parallellize tests from infrastructure using your DevOps (TM) build pipeline and run tests on multiple Koha-intances? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Olli-Antti Kivilahti changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18238 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #18 from M. Tompsett --- (In reply to Mason James from comment #17) > hmm, your patch OOMs my server, then fails... So it does for kohadevbox. :( I tested it in a 8GB RAM VM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Mason James changed: What|Removed |Added Attachment #59966|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #17 from Mason James --- (In reply to Mason James from comment #16) > (In reply to M. Tompsett from comment #15) > > I couldn't get the first patch to work for me, so I threw up a counter > > patch. > > Test them both. Decide your preference. Sign it off, obsolete the other. :) > > > hmm, your patch OOMs my server, then fails... > I'm happy to refine my initial patch, but thanks for your help :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #16 from Mason James --- (In reply to M. Tompsett from comment #15) > I couldn't get the first patch to work for me, so I threw up a counter patch. > Test them both. Decide your preference. Sign it off, obsolete the other. :) hmm, your patch OOMs my server, then fails... vagrant@kohadevbox:kohaclone(1)$ sudo koha-shell -c 'time prove -v ./t/db_dependent/00-strict.t ' kohadev ./t/db_dependent/00-strict.t .. No subtests run Test Summary Report --- ./t/db_dependent/00-strict.t (Wstat: 9 Tests: 0 Failed: 0) Non-zero wait status: 9 Parse errors: No plan found in TAP output Files=1, Tests=0, 37 wallclock secs ( 0.05 usr 0.02 sys + 3.03 cusr 0.58 csys = 3.68 CPU) Result: FAIL real0m37.559s user0m3.192s sys 0m0.620s vagrant@kohadevbox:~$ dmesg -T | grep -i oom-kil [Tue Feb 7 05:07:08 2017] perl invoked oom-killer: gfp_mask=0x280da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:09 2017] perl invoked oom-killer: gfp_mask=0x280da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:09 2017] perl invoked oom-killer: gfp_mask=0x201da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:09 2017] perl invoked oom-killer: gfp_mask=0x201da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:15 2017] perl invoked oom-killer: gfp_mask=0x201da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:15 2017] perl invoked oom-killer: gfp_mask=0x201da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:15 2017] sshd invoked oom-killer: gfp_mask=0x201da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:15 2017] sshd invoked oom-killer: gfp_mask=0x201da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:22 2017] perl invoked oom-killer: gfp_mask=0x280da, order=0, oom_score_adj=0 [Tue Feb 7 05:07:25 2017] perl invoked oom-killer: gfp_mask=0x280da, order=0, oom_score_adj=0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 M. Tompsett changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #15 from M. Tompsett --- I couldn't get the first patch to work for me, so I threw up a counter patch. Test them both. Decide your preference. Sign it off, obsolete the other. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 M. Tompsett changed: What|Removed |Added Summary|Speed up '00-strict.t' |Speed up '00-strict.t' test |test, with | |Parallel::ForkManager | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #14 from M. Tompsett --- > ok 1 - Syntax check acqui/modordernotes.pl > ok 2 - Syntax check acqui/edifactmsgs.pl > ok 3 - Syntax check acqui/check_uniqueness.pl > ok 4 - Syntax check acqui/transferorder.pl > ok 5 - Syntax check acqui/invoice-files.pl > ok 6 - Syntax check acqui/check_budget_total.pl > ok 7 - Syntax check acqui/invoices.pl > ok 8 - Syntax check acqui/booksellers.pl > ok 9 - Syntax check acqui/newordersuggestion.pl > ok 10 - Syntax check acqui/lateorders-export.pl ... > ok 657 - Syntax check tools/quotes/quotes-upload_ajax.pl > ok 658 - Syntax check virtualshelves/shelves.pl > ok 659 - Syntax check virtualshelves/addbybiblionumber.pl > ok 660 - Syntax check virtualshelves/downloadshelf.pl > ok 661 - Syntax check virtualshelves/sendshelf.pl > 1..661 > ok > All tests successful. > Files=1, Tests=661, 492 wallclock secs ( 0.06 usr 0.03 sys + 869.45 cusr > 51.84 csys = 921.38 CPU) > Result: PASS Counter patch isn't as pretty order-wise as this, but it is simpler. And, I hope runs faster. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #13 from M. Tompsett --- Created attachment 59966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59966&action=edit [COUNTER PATCH] Bug 18055: Speed up t/db_dependent/00-strict.t TEST PLAN - 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real16m34.104s 2/ apply patch 3/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real6m4.355s 4/ run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #12 from M. Tompsett --- I have a simplified counter-patch coming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Mason James changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #11 from Mason James --- (In reply to Mason James from comment #6) > (In reply to M. Tompsett from comment #5) > > Also, acqui which runs first has 42 tests, and sequentially you would expect > > 43, but admin restarts numbering at 1. This confuses the prove. I get a test > > failure. > > > works for me on the latest kohadevbox > > - here's a more verbose run... vagrant@kohadevbox:kohaclone(1)$ git log --oneline | head -3 b35842c Bug 18055 - Speed up '00-strict.t' test, with Parallel::ForkManager 6abf904 Bug 17960 - DBRev 16.12.00.007 2e9ae12 Bug 17960: Replace missing occurrences vagrant@kohadevbox:kohaclone(1)$ sudo koha-shell -c 'time prove -v ./t/db_dependent/00-strict.t ' kohadev ./t/db_dependent/00-strict.t .. ok 1 - Syntax check acqui/modordernotes.pl ok 2 - Syntax check acqui/edifactmsgs.pl ok 3 - Syntax check acqui/check_uniqueness.pl ok 4 - Syntax check acqui/transferorder.pl ok 5 - Syntax check acqui/invoice-files.pl ok 6 - Syntax check acqui/check_budget_total.pl ok 7 - Syntax check acqui/invoices.pl ok 8 - Syntax check acqui/booksellers.pl ok 9 - Syntax check acqui/newordersuggestion.pl ok 10 - Syntax check acqui/lateorders-export.pl ok 11 - Syntax check acqui/edimsg.pl ok 12 - Syntax check acqui/basketgroup.pl ok 13 - Syntax check acqui/parcels.pl ok 14 - Syntax check acqui/edi_ean.pl ok 15 - Syntax check acqui/add_user_search.pl ok 16 - Syntax check acqui/check_duplicate_barcode_ajax.pl ok 17 - Syntax check acqui/histsearch.pl ok 18 - Syntax check acqui/neworderbiblio.pl ok 19 - Syntax check acqui/newordersubscription.pl ok 20 - Syntax check acqui/addorderiso2709.pl ok 21 - Syntax check acqui/uncertainprice.pl ok 22 - Syntax check acqui/acqui-home.pl ok 23 - Syntax check acqui/ordered.pl ok 24 - Syntax check acqui/finishreceive.pl ok 25 - Syntax check acqui/cancelorder.pl ok 26 - Syntax check acqui/z3950_search.pl ok 27 - Syntax check acqui/spent.pl ok 28 - Syntax check acqui/basketheader.pl ok 29 - Syntax check acqui/neworderempty.pl ok 30 - Syntax check acqui/updatesupplier.pl ok 31 - Syntax check acqui/lateorders.pl ok 32 - Syntax check acqui/orderreceive.pl ok 33 - Syntax check acqui/basket.pl ok 34 - Syntax check acqui/supplier.pl ok 35 - Syntax check acqui/addorder.pl ok 36 - Syntax check acqui/invoice.pl ok 37 - Syntax check acqui/parcel.pl ok 38 - Syntax check acqui/ajax-getauthvaluedropbox.pl ok 39 - Syntax check acqui/pdfformat/layout2pagesde.pm ok 40 - Syntax check acqui/pdfformat/layout2pages.pm ok 41 - Syntax check acqui/pdfformat/layout3pages.pm ok 42 - Syntax check acqui/pdfformat/layout3pagesfr.pm ok 43 - Syntax check admin/branches.pl ok 44 - Syntax check admin/audio_alerts.pl ok 45 - Syntax check admin/cities.pl ok 46 - Syntax check admin/transport-cost-matrix.pl ok 47 - Syntax check admin/sru_modmapping.pl ok 48 - Syntax check admin/koha2marclinks.pl ok 49 - Syntax check admin/aqbudgets.pl ok 50 - Syntax check admin/smart-rules.pl ok 51 - Syntax check admin/biblio_framework.pl ok 52 - Syntax check admin/fieldmapping.pl ok 53 - Syntax check admin/admin-home.pl ok 54 - Syntax check admin/check_parent_total.pl ok 55 - Syntax check admin/checkmarc.pl ok 56 - Syntax check admin/patron-attr-types.pl ok 57 - Syntax check admin/add_user_search.pl ok 58 - Syntax check admin/env_tz_test.pl ok 59 - Syntax check admin/aqbudgetperiods.pl ok 60 - Syntax check admin/preferences.pl ok 61 - Syntax check admin/classsources.pl ok 62 - Syntax check admin/import_export_framework.pl ok 63 - Syntax check admin/systempreferences.pl ok 64 - Syntax check admin/printers.pl ok 65 - Syntax check admin/branch_transfer_limits.pl ok 66 - Syntax check admin/marctagstructure.pl ok 67 - Syntax check admin/localization.pl ok 68 - Syntax check admin/items_search_field.pl ok 69 - Syntax check admin/oai_set_mappings.pl ok 70 - Syntax check admin/oai_sets.pl ok 71 - Syntax check admin/currency.pl ok 72 - Syntax check admin/item_circulation_alerts.pl ok 73 - Syntax check admin/matching-rules.pl ok 74 - Syntax check admin/clone-rules.pl ok 75 - Syntax check admin/auth_tag_structure.pl ok 76 - Syntax check admin/didyoumean.pl ok 77 - Syntax check admin/z3950servers.pl ok 78 - Syntax check admin/marc_subfields_structure.pl ok 79 - Syntax check admin/check_budget_parent.pl ok 80 - Syntax check admin/auth_subfields_structure.pl ok 81 - Syntax check admin/authorised_values.pl ok 82 - Syntax check admin/edi_accounts.pl ok 83 - Syntax check admin/aqplan.pl ok 84 - Syntax check admin/itemtypes.pl ok 85 - Syntax check admin/authtypes.pl ok 86 - Syntax check admin/aqcontract.pl ok 87 - Syntax check admin/edi_ean_accounts.pl ok 88 - Syntax check admin/categories.pl ok 89 - Syntax check admin/columns_settings.pl ok 90 - Syntax check admin/items_search_fields.pl ok 91 - Syntax check admin/sms_providers.pl ok 92 - Syntax check admin/searchengine/elasticsearch/mappings.pl ok 93 - Syntax check authorities/merge.pl ok 94 - Syntax check
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #10 from Mason James --- (In reply to Mason James from comment #9) > (In reply to M. Tompsett from comment #8) > > (In reply to Mason James from comment #7) > > > (In reply to M. Tompsett from comment #4) > > > > > $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl > > > > Shouldn't this be a PerlDependencies tweak too? > > > yes, the patch includes this already... > > > > Yep, my bad. But I was running it on a non-kohadevbox git install. > > Fails horribly after running everything successfully, because of the test > > numbering. > i assume your 00-strict.t fails, without the patch too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #9 from Mason James --- (In reply to M. Tompsett from comment #8) > (In reply to Mason James from comment #7) > > (In reply to M. Tompsett from comment #4) > > > > $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl > > > Shouldn't this be a PerlDependencies tweak too? > > yes, the patch includes this already... > > Yep, my bad. But I was running it on a non-kohadevbox git install. > Fails horribly after running everything successfully, because of the test > numbering. fyi, it should make no difference please provide a detailed log of your error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #8 from M. Tompsett --- (In reply to Mason James from comment #7) > (In reply to M. Tompsett from comment #4) > > > $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl > > Shouldn't this be a PerlDependencies tweak too? > yes, the patch includes this already... Yep, my bad. But I was running it on a non-kohadevbox git install. Fails horribly after running everything successfully, because of the test numbering. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055
Mason James changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #7 from Mason James ---
(In reply to M. Tompsett from comment #4)
> > $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl
>
> Shouldn't this be a PerlDependencies tweak too?
yes, the patch includes this already...
-
diff --git a/C4/Installer/PerlDependencies.pm
b/C4/Installer/PerlDependencies.pm
index 4e1f75f..1ed5943 100644
--- a/C4/Installer/PerlDependencies.pm
+++ b/C4/Installer/PerlDependencies.pm
@@ -852,6 +852,16 @@ our $PERL_DEPS = {
required => 1,
min_ver => '0.28',
},
+'Parallel::ForkManager' => {
+usage => 'Core',
+required => 0,
+min_ver => '0.75',
+},
+'Sys::CPU' => {
+usage => 'Core',
+required => 0,
+min_ver => '0.52',
+},
};
-
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #6 from Mason James --- (In reply to M. Tompsett from comment #5) > Also, acqui which runs first has 42 tests, and sequentially you would expect > 43, but admin restarts numbering at 1. This confuses the prove. I get a test > failure. works for me on the latest kohadevbox - vagrant@kohadevbox:~/kohaclone$ git log --oneline | head -3 b35842c Bug 18055 - Speed up '00-strict.t' test, with Parallel::ForkManager 6abf904 Bug 17960 - DBRev 16.12.00.007 2e9ae12 Bug 17960: Replace missing occurrences vagrant@kohadevbox:~/kohaclone$ sudo koha-shell -c 'time prove ./t/db_dependent/00-strict.t ' kohadev ./t/db_dependent/00-strict.t .. ok All tests successful. Files=1, Tests=661, 537 wallclock secs ( 0.06 usr 0.00 sys + 943.76 cusr 61.74 csys = 1005.56 CPU) Result: PASS real8m57.167s user15m43.892s sys 1m1.752s - -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 M. Tompsett changed: What|Removed |Added Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #5 from M. Tompsett --- Also, acqui which runs first has 42 tests, and sequentially you would expect 43, but admin restarts numbering at 1. This confuses the prove. I get a test failure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||mtomp...@hotmail.com --- Comment #4 from M. Tompsett --- > $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl Shouldn't this be a PerlDependencies tweak too? Obviously not required, but it is good to install for testing. Kind of like Test::DBIx::Class. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Mason James changed: What|Removed |Added Attachment #59900|0 |1 is obsolete|| Attachment #59901|0 |1 is obsolete|| --- Comment #3 from Mason James --- Created attachment 59902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59902&action=edit Bug 18055 - Speed up '00-strict.t' test, with Parallel::ForkManager to test... 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real16m34.104s 2/ apply patch 3/ install Parallel::ForkManager package $ sudo apt-get install libparallel-forkmanager-perl libsys-cpu-perl 4/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real6m4.355s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #2 from Mason James --- Created attachment 59901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59901&action=edit Add Sys::CPU package, too -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 Mason James changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18055] Speed up '00-strict.t' test, with Parallel::ForkManager
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18055 --- Comment #1 from Mason James --- Created attachment 59900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59900&action=edit Bug 18055 - Speed up '00-strict.t' test, with Parallel::ForkManager to test... 1/ run 00-strict.t test, (16.5 mins on a 4xcpu system) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 994 wallclock secs ( 0.19 usr 0.04 sys + 873.40 cusr 116.20 csys = 989.83 CPU) Result: PASS real16m34.104s 2/ apply patch 3/ install Parallel::ForkManager package $ sudo apt-get install libparallel-forkmanager-perl 4/ run 00-strict.t test again, (now 6 mins.. much faster) $ time prove t/db_dependent/00-strict.t ... Files=1, Tests=654, 364 wallclock secs ( 0.07 usr 0.01 sys + 1159.20 cusr 153.41 csys = 1312.69 CPU) Result: PASS real6m4.355s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
