[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #10 from Mason James --- Pushed to 16.05.x, for 16.05.10 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.04. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall --- Pushed to master for 17.05, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Jonathan Druart changed: What|Removed |Added Attachment #59991|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 60330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60330&action=edit Bug 18068: ES - Fix location and (home|holding)branch facets This patch makes the 'Locations' facet work as expected (i.e. having the same behaviour it has for Zebra: picking the 952$c in MARC21 and 995e for UNIMARC). It also adds the code to handle holding and home library settings for facets and makes the facets show the library name instead of the branch code. The mappings are updated so the labels match what facets.inc expect to work properly. To test: - On master, do a search that returns biblios with items having homebranch set. => FAIL: Under the 'Locations' label on the facets you will notice branchcodes are shown. - Apply the patch - Restart memcached and plack (just in case, it was tricky) - Reset your mappings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 - Restart memcached and plack (again, not sure if needed) - Make sure this mappings are set: homebranch => HomeLibrary holdingbranch => HoldingLibrary (Note: it might not be set due to the place the yaml file is being picked) - Reindex your records: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl misc/search_tools/rebuild_elastic_search.pl -d -v - Repeat the initial search => SUCCESS: 'Location' contains the right stuff, 'Home libraries' and 'Holding libraries' too. - Run k$ prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t => SUCCESS: Tests pass! - Sign off :-D Note: play with the 'DisplayLibraryFacets' syspref options. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 --- Comment #6 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > I do not see the "Holding branch" facet, even when mapped with 952$b > (default mappings). > What did I miss? I forgot to reset the mappings... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #4) > I do not see the "Holding branch" facet, even when mapped with 952$b > (default mappings). > What did I miss? DisplayLibraryFacets? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 --- Comment #4 from Jonathan Druart --- I do not see the "Holding branch" facet, even when mapped with 952$b (default mappings). What did I miss? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Nick Clemens changed: What|Removed |Added Attachment #59948|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 59991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59991&action=edit Bug 18068: ES - Fix location and (home|holding)branch facets This patch makes the 'Locations' facet work as expected (i.e. having the same behaviour it has for Zebra: picking the 952$c in MARC21 and 995e for UNIMARC). It also adds the code to handle holding and home library settings for facets and makes the facets show the library name instead of the branch code. The mappings are updated so the labels match what facets.inc expect to work properly. To test: - On master, do a search that returns biblios with items having homebranch set. => FAIL: Under the 'Locations' label on the facets you will notice branchcodes are shown. - Apply the patch - Restart memcached and plack (just in case, it was tricky) - Reset your mappings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 - Restart memcached and plack (again, not sure if needed) - Make sure this mappings are set: homebranch => HomeLibrary holdingbranch => HoldingLibrary (Note: it might not be set due to the place the yaml file is being picked) - Reindex your records: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl misc/search_tools/rebuild_elastic_search.pl -d -v - Repeat the initial search => SUCCESS: 'Location' contains the right stuff, 'Home libraries' and 'Holding libraries' too. - Run k$ prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t => SUCCESS: Tests pass! - Sign off :-D Note: play with the 'DisplayLibraryFacets' syspref options. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Tomás Cohen Arazi changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17169 [Bug 17169] Add facets for ccode and language to elasticsearch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 59948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59948&action=edit Bug 18068: ES - Fix location and (home|holding)branch facets This patch makes the 'Locations' facet work as expected (i.e. having the same behaviour it has for Zebra: picking the 952$c in MARC21 and 995e for UNIMARC). It also adds the code to handle holding and home library settings for facets and makes the facets show the library name instead of the branch code. The mappings are updated so the labels match what facets.inc expect to work properly. To test: - On master, do a search that returns biblios with items having homebranch set. => FAIL: Under the 'Locations' label on the facets you will notice branchcodes are shown. - Apply the patch - Restart memcached and plack (just in case, it was tricky) - Reset your mappings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 - Restart memcached and plack (again, not sure if needed) - Make sure this mappings are set: homebranch => HomeLibrary holdingbranch => HoldingLibrary (Note: it might not be set due to the place the yaml file is being picked) - Reindex your records: $ sudo koha-shell kohadev k$ cd kohaclone k$ perl misc/search_tools/rebuild_elastic_search.pl -d -v - Repeat the initial search => SUCCESS: 'Location' contains the right stuff, 'Home libraries' and 'Holding libraries' too. - Run k$ prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t => SUCCESS: Tests pass! - Sign off :-D Note: play with the 'DisplayLibraryFacets' syspref options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Tomás Cohen Arazi changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Tomás Cohen Arazi --- To reproduce: - Do a search on a DB with items having a homebranch set => FAIL: the 'Locations' facet shows branchcodes instead of the content from 952$c (MARC21) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068 Tomás Cohen Arazi changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||katrin.fisc...@bsz-bw.de, ||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/