[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Katrin Fischer  ---
1) There is a fail in the QA scripts:

 FAIL   installer/data/mysql/kohastructure.sql
   FAIL   tinyint_has_boolean_flag
The new column categories.canplaceill is using TINYINT(1) as
type but is not defined as boolean in the schema file
(Koha/Schema/Result/Category.pm), see the SQL12 coding guideline


2) Behavior in staff interface

I think, we should not use the staff person's patron category for the check on
the 'new request' button in the staff interface.

If a staff user has permissions for the interlibrary loans module, they should
be able to place ILL requests for the users of the library. They are usually
not placing ILL requests for themselves, but for others. Similar to hold
requests.

The check on the category should be implemented in the patron search/the user
they try to place the request for. But I am not sure if this would have to be
done in the backends then?


3) Changed behaviour for existing installations

As all categories are allowed to place ILL requests now, we should set "Can
place ILL requests?" to yes for all categories if the ILLModule is activated.
This way we won't break things for libraries and they can implement the new
feature if they chose to do so.


But overall this looks quite good already!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

--- Comment #12 from Pedro Amorim  ---
Fixed commit author, had originally been submitted as John Doe.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #145349|0   |1
is obsolete||

--- Comment #11 from Pedro Amorim  ---
Created attachment 145354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145354=edit
Bug 18203: Add per borrower category restrictions on ILL placement

Test Plan:
- Enable ILLModule sys pref and install any backend
- Verify you can place new ILL requests in OPAC and Intranet
- Apply patch
- Run dbic
- Verify you can no longer place new ILL requests in OPAC and Intranet
- In borrower categories, set 'Can place ILL' to yes.
- Verify you can place new ILL requests in OPAC and Intranet.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

David Nind  changed:

   What|Removed |Added

 Attachment #145331|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 145349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145349=edit
Bug 18203: Add per borrower category restrictions on ILL placement

Test Plan:
- Enable ILLModule sys pref and install any backend
- Verify you can place new ILL requests in OPAC and Intranet
- Apply patch
- Run dbic
- Verify you can no longer place new ILL requests in OPAC and Intranet
- In borrower categories, set 'Can place ILL' to yes.
- Verify you can place new ILL requests in OPAC and Intranet.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Martin Renvoize  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Pedro Amorim  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Pedro Amorim  changed:

   What|Removed |Added

  Attachment #60805|0   |1
is obsolete||
  Attachment #60806|0   |1
is obsolete||

--- Comment #9 from Pedro Amorim  ---
Created attachment 145331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145331=edit
Bug 18203: Add per borrower category restrictions on ILL placement

Test Plan:
- Enable ILLModule sys pref and install any backend
- Verify you can place new ILL requests in OPAC and Intranet
- Apply patch
- Run dbic
- Verify you can no longer place new ILL requests in OPAC and Intranet
- In borrower categories, set 'Can place ILL' to yes.
- Verify you can place new ILL requests in OPAC and Intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Pedro Amorim  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|a...@komputilo.eu   |pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

--- Comment #8 from Katrin Fischer  ---
I believe this would still be a nice to have feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Andrew Isherwood  changed:

   What|Removed |Added

 CC|bugzi...@warmlight.co.uk|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com,
   ||martin.renvoize@ptfs-europe
   ||.com
 Status|NEW |Needs Signoff
Summary|Add per borrower category   |Add per borrower category
   |restrictions on ILL |restrictions on ILL
   |placement.  |placement

--- Comment #7 from Katrin Fischer  ---
Alex is no longer working on Koha so I am not sure why this was never set to
'needs sign-off'. 

The DO NOT PUSH for schema changes is normal as this file is only used for
testing and the RM will not use it when pushing the patch set. So this doesn't
tell us much. hm.

I am updating the status to 'Patch doesn't apply' and adding Andrew and Martin
who may know what happened here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer  changed:

   What|Removed |Added

 CC||ha...@orex.es

--- Comment #6 from Katrin Fischer  ---
*** Bug 23976 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

--- Comment #5 from Niamh Walker-Headon  ---
Has there been any update on this since the DO NOT PUSH? 
Thanks, 
Niamh

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Holly  changed:

   What|Removed |Added

 CC||h...@interleaf.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Niamh Walker-Headon  changed:

   What|Removed |Added

 CC||niamh.walkerhea...@hse.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #4 from Katrin Fischer  ---
I think this would still be very useful to have as I see no other option to
limit ILL requests for patrons. By patron category should work for most
libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |
   |y.org   |
  Component|Circulation |ILL
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203
Bug 18203 depends on bug 7317, which changed state.

Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Niamh  changed:

   What|Removed |Added

 CC||niamh.walker-headon@it-tall
   ||aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|20536   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536
[Bug 20536] ILL: authnotrequired not explicitly unset
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||20536


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536
[Bug 20536] ILL: authnotrequired not explicitly unset
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

--- Comment #3 from Alex Sassmannshausen  
---
Test Plan:
- Have ILLModule working
- With any non-database user verify you can place new ILL requests in OPAC and
Intranet
- Apply patches here
- Run dbupdate
- Verify you can no longer place new ILL requests in OPAC and Intranet
- In borrower categories, set 'Can place ILL' to yes.
- Verify you can place new ILL requests in OPAC and Intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

--- Comment #2 from Alex Sassmannshausen  
---
Created attachment 60806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60806=edit
DO NOT PUSH: Schema changes.

* Koha/Schema/Result/Category.pm: Add `canplaceill`.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

--- Comment #1 from Alex Sassmannshausen  
---
Created attachment 60805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60805=edit
Add per borrower category create ILL privilege.

* admin/categories.pl: Add validation & update for `canplaceill`.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: Add
  `canplaceill` handling.
* ill/ill-requests.pl: Pass `canplaceill` to template.
* koha-tmpl/intranet-tmpl/prog/en/includes/ill-toolbar.inc: Check for
  `canplaceill`.
* opac/opac-illrequests.pl: Pass `canplaceill` to template.
* koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt: Check
  for `canplaceill`.
* installer/data/mysql/kohastructure.sql: Create `canplaceill`
  column.
* installer/data/mysql/atomicupdate/ill_cat_permission.sql: New file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18203] Add per borrower category restrictions on ILL placement.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Alex Sassmannshausen  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.sassmannshausen@ptfs-e
   |ity.org |urope.com
 Depends on||7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/