[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comm

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comm

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexi

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #44 from Marcel de Rooy --- Created attachment 66015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66015&action=edit Bug 18331: POST_CHOMP everywhere! Signed-off-by: Marcel de Rooy -- You are recei

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #42 from Marcel de Rooy --- Created attachment 66013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66013&action=edit Bug 18331: Followup - Fix CSV export (once and for all!) Follow-up on Comment 21 to

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Marcel de Rooy changed: What|Removed |Added Attachment #65815|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #43 from Marcel de Rooy --- Created attachment 66014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66014&action=edit Bug 18331: Followup - fix path to orders_by_budget csv header Signed-off-by: Josef

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #41 from Marcel de Rooy --- Created attachment 66012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66012&action=edit Bug 18331: Force tt to insert newline to empty_line.inc See end of comment #4 and I

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #39 from Jonathan Druart --- Yes, basically the idea is to have PRE and POST CHOMP everywhere in the csv template files, then use the empty_line include file to add it explicitly. -- You are receiving this mail because

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #38 from Jonathan Druart --- Created attachment 65956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65956&action=edit Bug 18331: POST_CHOMP everywhere! -- You are receiving this mail because: You ar

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #37 from Katrin Fischer --- It would be great if we could get this one in before the 15th and string freeze. It's well tested now, please don't break it - there is a long history of 'argh' over this problem :) -- You ar

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #34 from Katrin Fischer --- Created attachment 65817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65817&action=edit [SIGNED OFF] Bug 18331: Followup - Fix CSV export (once and for all!) Follow-up on

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #35 from Katrin Fischer --- Created attachment 65818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65818&action=edit [SIGNED OFF] Bug 18331: Followup - fix path to orders_by_budget csv header Signed-o

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #32 from Katrin Fischer --- Created attachment 65815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65815&action=edit [SIGNED OFF] Bug 18331: Fix CSV export (once and for all!) I am going to try and ex

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #33 from Katrin Fischer --- Created attachment 65816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65816&action=edit [SIGNED OFF] Bug 18331: Force tt to insert newline to empty_line.inc See end of com

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Katrin Fischer changed: What|Removed |Added Attachment #65620|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Katrin Fischer changed: What|Removed |Added Attachment #65623|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Katrin Fischer changed: What|Removed |Added Attachment #65622|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Katrin Fischer changed: What|Removed |Added Attachment #65621|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #31 from Katrin Fischer --- Tested, each with English and German (translated): - Acquisitions: Basket export - OK! - Acquisitions: Basket group export - OK! - Acquisitions: Late orders - OK! - Item search - OK! - Report:

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #28 from Josef Moravec --- Created attachment 65621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65621&action=edit [SIGNED-OFF] Bug 18331: Force tt to insert newline to empty_line.inc See end of comm

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #30 from Josef Moravec --- Created attachment 65623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65623&action=edit [SIGNED-OFF] Bug 18331: Followup - fix path to orders_by_budget csv header Signed-of

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #29 from Josef Moravec --- Created attachment 65622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65622&action=edit [SIGNED-OFF] Bug 18331: Followup - Fix CSV export (once and for all!) Follow-up on C

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rece

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Josef Moravec changed: What|Removed |Added Attachment #65581|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com At

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #26 from Lee Jamison --- Created attachment 65583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65583&action=edit Fix CSV export (once and for all!) Follow-up on Comment 21 to correct the empty_line.i

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Lee Jamison changed: What|Removed |Added Attachment #65478|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Lee Jamison changed: What|Removed |Added Attachment #64239|0 |1 is obsolete|

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #23 from Lee Jamison --- Created attachment 65515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65515&action=edit [FOLLOW-UP] Fix CSV export (once and for all!) Follow-up on Comment 21 to correct the

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #22 from Marc Véron --- Created attachment 65478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65478&action=edit Bug 18331: Force tt to insert newline to empty_line.inc See end of comment #4 and IRC:

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #21 from Jonathan Druart --- Not related with the current discussion, but found an error in the current patch: +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basket.tt @@ -1,4 +1,6 @@ -[% INCLUDE csv_headers/ac

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #20 from Jonathan Druart --- Try to remove the content of template_cache_dir or disable it (and restart memcached + plack). -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #19 from Jonathan Druart --- pmvers Template => 2.24 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #18 from Katrin Fischer --- Hi Jonathan, It's exactly what I did. I think the really curious thing is that for me it's broken the English templates too. So if we leave out all the po stuff - where could be the difference

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #16

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #15 from Katrin Fischer --- Hi I tested this fresh from start to end and I am seeing no improvement with the patch: Tested on master: - translate update de-DE - translate install de-DE - Switch to de-DE: - item search

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #14 from Marc Véron --- I can fix and reproduce the issue with following steps: - Apply patch - restart plack / memcached with every step as appropriate - Verify that (on my installation) the CSV export is in one line -

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #13 from Marc Véron --- Updated Template Toolkit to 2.27, same result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koh

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #12 from Marc Véron --- Hmm, there must be a difference. Just to exclude: Same version of Template Toolkit? About page: Template (2.22) 2.26 -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #11 from Jonathan Druart --- I'd like somebody else to test as we get different behaviours with the same code. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #10 from Marc Véron --- (In reply to Jonathan Druart from comment #9) > I replaced empty_string with [% '' %] and I got the same result (i.e. it > works). ...as in my tests from comment #6 What is the next step? - Change

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #9 from Jonathan Druart --- I replaced empty_string with [% '' %] and I got the same result (i.e. it works). -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #8 from Marc Véron --- It happens in English (see comment #4) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@li

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #7 from Jonathan Druart --- Did you update the po file correctly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bu

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #6 from Marc Véron --- Re-tested on current master with patch applied, plack + memcached restarted, page reloaded, 2 late orders, CSV export, open in editor, result (in one line): ORDER DATE,ESTIMATED DELIVERY DATE,VENDO

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #5 from Jonathan Druart --- I have retested and it works for me (late orders). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #4

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Jonathan Druart changed: What|Removed |Added Depends on||18694 Referenced Bugs:

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #3 from Jonathan Druart --- Guys, please try your hardest to test this patch, I am fed up with fixing this bug every release! -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Jonathan Druart changed: What|Removed |Added Severity|normal |major --- Comment #2 from

[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 Jonathan Druart changed: What|Removed |Added Summary|Export csv in item search, |CSV exports need to be