[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-08-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21273


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21273
[Bug 21273] After upgrade from 17.11.08 to 18.05.02 intra not working, Software
error: Template process failed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-05-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

--- Comment #80 from Katrin Fischer  ---
*** Bug 13239 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Nick Clemens  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||n...@bywatersolutions.com
 Resolution|--- |FIXED

--- Comment #79 from Nick Clemens  ---
Seems a big change, not backported for 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20299


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20299
[Bug 20299] Is Koha installer suggesting Koha is shit?
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_18_05_candidate |

--- Comment #78 from Jonathan Druart  
---
Last patch pushed to master, thanks Tomás!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

--- Comment #77 from Tomás Cohen Arazi  ---
Created attachment 71953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71953=edit
Bug 18336: (follow-up) Shift TINYTEXT columns

This patch fixes two errors that slipped in the patchset.

To test:
- Create a dummy branch for testing:
  $ cd kohaclone
  $ git fetch
  $ git checkout v17.11.00 -b dummy
- Reset your working DB
  $ reset_all (y)
- Set your branch to current master
  $ git reset --hard origin/master
- Update the DB
  $ updatedatabase
- Update the schema files
  $ kshell
 k$ misc/devel/update_dbix_class_files.pl \
   --db_name koha_kohadev \
   --db_user koha_kohadev \
   --db_passwd password
 k$ exit
  $ git diff
=> FAIL: There are discrepancies on upgrades
- Reset to v17.11.00 revision and DB:
  $ git reset --hard v17.11.00
  $ reset_all (y)
- Set your branch to current master
  $ git reset --hard origin/master
- Apply this patch
- Update the DB
  $ updatedatabase
- Update the schema files
  $ kshell
 k$ misc/devel/update_dbix_class_files.pl \
   --db_name koha_kohadev \
   --db_user koha_kohadev \
   --db_passwd password
 k$ exit
  $ git diff
=> SUCCESS: No discrepancies!
- Reset to HEAD to get rid of the schema changes
  $ git reset --hard HEAD
- Regenerate the schema files on top of this patch
  $ dbic ; cd /home/vagrant/kohaclone
  $ git diff
=> SUCCESS: No discrepancies!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

--- Comment #76 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #75)
> Tomas, it seems that I missed something, the DBIC schema files are different:
> 
>  Koha/Schema/Result/Club.pm|  8 
>  Koha/Schema/Result/ClubTemplate.pm|  8 
>  Koha/Schema/Result/ClubTemplateEnrollmentField.pm |  8 
>  Koha/Schema/Result/ClubTemplateField.pm   |  8 
>  Koha/Schema/Result/MarcSubfieldStructure.pm   | 12 ++--
>  Koha/Schema/Result/UploadedFile.pm|  8 
> 
> 
>"name",
> -  { data_type => "text", is_nullable => 0 },
> +  { data_type => "tinytext", is_nullable => 0 },
> 
> 
> The ones in master have been generated with a DB upgraded from v17.11.00,
> but with a fresh install (kohastructure.sql) they are different.
> That is weird I am sure I took time to confirm that before I pushed.
> 
> Can you double-check and provide a follow-up please (change to kohastructure
> or updatedabase I guess)?

I will try different engines too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

--- Comment #75 from Jonathan Druart  
---
Tomas, it seems that I missed something, the DBIC schema files are different:

 Koha/Schema/Result/Club.pm|  8 
 Koha/Schema/Result/ClubTemplate.pm|  8 
 Koha/Schema/Result/ClubTemplateEnrollmentField.pm |  8 
 Koha/Schema/Result/ClubTemplateField.pm   |  8 
 Koha/Schema/Result/MarcSubfieldStructure.pm   | 12 ++--
 Koha/Schema/Result/UploadedFile.pm|  8 


   "name",
-  { data_type => "text", is_nullable => 0 },
+  { data_type => "tinytext", is_nullable => 0 },


The ones in master have been generated with a DB upgraded from v17.11.00, but
with a fresh install (kohastructure.sql) they are different.
That is weird I am sure I took time to confirm that before I pushed.

Can you double-check and provide a follow-up please (change to kohastructure or
updatedabase I guess)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18336] Add support for Unicode supplementary characters

2018-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Use utf8mb4 instead of utf8 |Add support for Unicode
   |for MySQL tables, columns,  |supplementary characters
   |and connections |
  Text to go in the||Koha now supports Unicode
  release notes||supplementary characters
   ||like emojis or
   ||supplementary japanese,
   ||chinese and others.
   ||
   ||The DB
   ||structure definition is
   ||changed to make use of the
   ||utf8mb4 encoding, instead
   ||of utf8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/