[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #35 from Katrin Fischer --- Thx Marcel - patches apply now and tests pass. This patch has been pushed to 16.11.x and will be in 16.11.11. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #34 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #32) > Conflicts with 16.11.x. If you want this to be included, please rebase on > 16.11.x. Thx! That you should do it.. --

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #33 from Marcel de Rooy --- Created attachment 66006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66006=edit Bug 18361: [SQUASHED FOR 16.11] Koha::Objects->find should

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #31 from Fridolin SOMERS --- I finally to push to 17.05.x in order to follow master using this change. Will be in 17.05.03. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Fridolin SOMERS changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Bug 18361 depends on bug 18539, which changed state. Bug 18539 Summary: Forbid Koha::Objects->find calls in list context https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18539 What|Removed

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #28 from Marcel de Rooy --- Created attachment 64372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64372=edit Bug 18361: [QA Follow-up] Resolve warning on undef values

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #27 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #26) > I get warnings from tests: > > t/db_dependent/Letters.t . 3/82 >

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #24 from Jonathan Druart --- Created attachment 64349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64349=edit Bug 18361: (QA followup) Add tests for the no

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #23 from Jonathan Druart --- Created attachment 64348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64348=edit Bug 18361: Additional tests for

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #18 from Marcel de Rooy --- ping Jonathan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Attachment #62397|0

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Attachment #62395|0

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Attachment #62396|0

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Bug 18361 depends on bug 18182, which changed state. Bug 18182 Summary: TestBuilder should be able to return Koha::Object objects https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 What|Removed

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #13 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #12) > Signed-off-by: Tomas Cohen Arazi Thx -- You are receiving this mail because: You are

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 62397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62397=edit Bug 18361: (QA followup) Add tests for the no params case This

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Tomás Cohen Arazi changed: What|Removed |Added Attachment #62143|0 |1

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #8 from Marcel de Rooy --- Tomas: I adjusted the POD to make your concerns more visible, and renamed the @id array to a more generic name @pars, since it indeed may contain an attrs hash.

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #3) > (In reply to Marcel de Rooy from comment #2) > > The indirect way of testing the changed find via TestBuilder works. >

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Attachment #61754|0

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #7 from Marcel de Rooy --- Created attachment 62143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62143=edit Bug 18361: Additional tests for Koha::Objects->find Adding a

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #5 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #4) > Comment on attachment 61754 [details] [review] > Bug 18361: Koha::Objects->find should accept composite primary keys

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #4 from Tomás Cohen Arazi --- Comment on attachment 61754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61754 Bug 18361: Koha::Objects->find should accept composite primary keys

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #3 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #2) > The indirect way of testing the changed find via TestBuilder works. > Is it enough or should we add

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 --- Comment #1 from Marcel de Rooy --- Created attachment 61754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61754=edit Bug 18361: Koha::Objects->find should accept composite primary

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 18361] Koha::Objects->find should accept composite primary keys

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18361 Marcel de Rooy changed: What|Removed |Added Depends on|