[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Blocks||25924 Referenced Bugs:

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Nick Clemens changed: What|Removed |Added Blocks||25869 Referenced Bugs:

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Jonathan Druart changed: What|Removed |Added Blocks||25369 Referenced Bugs:

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #55 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What|Removed |Added Attachment #91789|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What|Removed |Added Attachment #91788|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What|Removed |Added Attachment #91786|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What|Removed |Added Attachment #91787|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley changed: What|Removed |Added Attachment #91554|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley changed: What|Removed |Added Attachment #91555|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley changed: What|Removed |Added Attachment #91553|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Alex Buckley changed: What|Removed |Added Attachment #91552|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #83633|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #83635|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #83636|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #83634|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #39 from Maryse Simard --- Created attachment 83636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83636=edit Bug 18421: (follow-up) Center image in results table Adds the "thumbnail" class to the

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #80139|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #80138|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Maryse Simard changed: What|Removed |Added Attachment #80137|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Attachment #77764|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #34 from Owen Leonard --- Created attachment 80138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80138=edit Bug 18421: (follow-up) QA fixes Use the community's terminology, change coce.js's path,

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #35 from Owen Leonard --- Created attachment 80139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80139=edit Bug 18421: (follow-up) Adding missing filters This patch adds template filters as prompted

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Julian Maurice changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #31 from Jonathan Druart --- Quick notes: 1. We hit the same problem as local cover on bug 19511 2. FIXME in .js, but copied from the OPAC one (not blocker) 3. Will fail tests bug 13618 is going to add (should be pushed

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #29 from Katrin Fischer --- I'd not insist on squashing per se - there are reasons when it might not make sense. I haven't taken a closer look at those patches (can't test coce), but signed off is good. -- You are

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #28 from Charles Farmer --- Thanks for the explanation Katrin, it does make sense. Though I feel like in that instance, it begs the question "why should we submit (QA follow-up) patches in the first place"? Either I'm

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #27 from Katrin Fischer --- It's just a warning about something that could easily be confusing or a mistake: FAIL koha-tmpl/intranet-tmpl/prog/js/coce.js FAIL git manipulation The file has been

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #26 from Owen Leonard --- (In reply to Charles Farmer from comment #23) > Wait, `git mv` is now seen as an erroneous operation?! I'll leave that up to QA. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Attachment #77598|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #25 from Owen Leonard --- Created attachment 77765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77765=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #22

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #77597|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #74252|0 |1 is obsolete|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #19 from Charles Farmer --- Created attachment 77597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77597=edit Bug 18421: (QA follow-up) Use the community's terminology, change coce.js's path, update

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #18 from Charles Farmer --- Thank you very much for you reply Owen. When you asked to change the keyword 'Intranet' to 'Staff client', were you talking about strings in the interface, or did you mean to go all the way

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #16 from Katrin Fischer --- Hi Charles, please always add a separate follow-up patch with changes requested by QA and then switch back to 'signed off' if not requested otherwise. This way you

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #73495|0

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #14 from Katrin Fischer --- (In reply to Charles Farmer from comment #13) > I've read your comments and applied them accordingly. > > Only thing bothering me is the IGNORE. I don't know much

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #13 from Charles Farmer --- I've read your comments and applied them accordingly. Only thing bothering me is the IGNORE. I don't know much about SQL, but aren't we trying to avoid MySQLism?

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #73401|0

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #11 from Katrin Fischer --- Comment on attachment 73401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73401 Bug18421 - Add Coce to the staff intranet Review of attachment

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #10 from Charles Farmer --- Rebased C4/Auth.pm over the latest master: conflict over an end-of-line comma. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #72772|0

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Brendan Gallagher changed: What|Removed |Added Attachment #71977|0

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Attachment #71322|0

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #6 from Agnes Rivers-Moore --- I appreciate the response, many thanks. We are planning an upgrade in the next few months - perhaps the behaviour will change after that. -- You are receiving this mail

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #5 from Charles Farmer --- Because of the variables involved in the deployment of Coce -- the koha version, the nodejs version, whether passenger is used or not for clustering, the

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #4 from Agnes Rivers-Moore --- (In reply to Charles Farmer from comment #1) > > When turned on, Coce cover images appear in the OPAC only, not staff > > interface. > (Coce Cover images - settings in

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #3 from Agnes Rivers-Moore --- (In reply to Charles Farmer from comment #1) > > When turned on, Coce cover images appear in the OPAC only, not staff > > interface. > (Coce Cover images - settings in

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Version|unspecified

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 --- Comment #2 from Charles Farmer --- Created attachment 71322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71322=edit Bug18421 - Add Coce to the staff intranet TEST PLAN: 1)

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18421] Make Coce cover images available for staff search

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Charles Farmer changed: What|Removed |Added CC|