[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547
--- Comment #24 from Jonathan Druart
---
Comment on attachment 69126
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69126
Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold
policy
Review of attachment 69126:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18547&attachment=69126)
-
::: C4/Reserves.pm
@@ +1161,5 @@
>
> foreach my $i (@items) {
> +
> +my $circ_control_branch =
> C4::Circulation::_GetCircControlBranch( $i->unblessed(), $borrower );
> +my $branchitemrule = C4::Circulation::GetBranchItemRule(
> $circ_control_branch, $i->itype );
Hum, should not $i->itype be $i->effective_itemtype?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=4319 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Marcel de Rooy changed: What|Removed |Added Keywords|Academy | --- Comment #23 from Marcel de Rooy --- Removed Academy. Should (generally) not be added to Holds patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547
--- Comment #22 from Marcel de Rooy ---
I was looking at 4319 that also proposes changes for this sub in Reserves, and
somehow came here.
The changes here seem too selective to me.
Why are you looking at $branchitemrule->{holdallowed} == 1 only? Why do you not
check the 0 value (no holds allowed) ? And why do you add this test only for If
all unavailable? Should it not be tested globally, over the different values of
On shelf holds allowed?
Does not look good to me. Do I overlook something ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Jonathan Druart changed: What|Removed |Added Keywords|rel_17_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #20 from Nick Clemens --- Created attachment 69127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69127&action=edit Bug 18547: QA Followup Added comments to make clearer Tests had some confusion with names and results, though they do seem to cover the changes here. I believe the tests highlight that ReserveControlBranch has no effect, and possibly it should? Beyond the scope here but left those tests for future work to be done Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #19 from Nick Clemens --- Created attachment 69126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69126&action=edit Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold policy If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. Followed test plan, worked as intended Signed-off-by: Alex Buckley Followed test plan in the intranet and OPAC, worked as intended. With few assumptions made: - when the hold works, should be on the item 1 (Centerville) item 2 is only there to trigger the bug - the circ rules were identically setup on each branch and in "Standard rules for all libraries" Signed-off-by: Victor Grousset Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Nick Clemens changed: What|Removed |Added Attachment #66675|0 |1 is obsolete|| Attachment #68854|0 |1 is obsolete|| --- Comment #18 from Nick Clemens --- Created attachment 69125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69125&action=edit Add tests https://bugs.koha-community.org/show_bug.cgi?id=18547 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Nick Clemens changed: What|Removed |Added CC||cristianbib...@gmail.com --- Comment #17 from Nick Clemens --- *** Bug 19543 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Jonathan Druart changed: What|Removed |Added Keywords||rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #16 from Katrin Fischer --- Glad to see this one moving, thx for taking the time to test! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m --- Comment #15 from Victor Grousset/tuxayo --- @Caroline Cyr La Rose I got results consistent with yours. Thanks for raising the OPAC vs intranet issue, I didn't think of this when first trying the test plan. And it seems that the test plan was written for the OPAC as more details are needed for doing it in the intranet. (related the overriding the circ rule (disabling it or ignoring it)) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #63227|0 |1 is obsolete|| --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 68854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68854&action=edit Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold policy If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. Followed test plan, worked as intended Signed-off-by: Alex Buckley Followed test plan in the intranet and OPAC, worked as intended. With few assumptions made: - when the hold works, should be on the item 1 (Centerville) item 2 is only there to trigger the bug - the circ rules were identically setup on each branch and in "Standard rules for all libraries" Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #13 from Caroline Cyr La Rose --- I'm not sure of the test plan and expected result. Do we have to place the hold from the OPAC or staff interface? And for the result, is it supposed to override the default holds policy? - I changed one of my circulation rules to If all unavailable for one of my patron categories (x all item types). - Fixed a record so that one of the items was in the home library of the user and one was in another branch (both current location and home library) - Check out the item that was in the same home library as the patron from the fiex patron category to another user - Tried to place a hold for my patron in the staff interface. It says "Not on hold OR Due DD/MM/ Item level hold not allowed from OPAC. There is a little yellow "!" triangle icon next to BOTH items but I can still override the circ rule. I have a pop-up saying "This item normally cannot be put on hold except for patrons from (2nd branch), Place hold on this item?" - From the OPAC, I logged in as my user and tried to place the hold and it says "Sorry non of these items can be placed on hold." / "No available items". - After the patch, the yellow "!" triangle icon is ONLY next to the item from the 2nd location (not patron's home library) in the staff interface. So, no problem to reserve the checked out item, but I have to override to reserve the available item. - From the OPAC, I was able to place my hold on the bib record without problem. I went into the "Holds to pull" report and saw that the item from the 2nd location was there, waiting to be pulled from the shelf. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > Created attachment 66675 [details] [review] > Add tests Make sure these tests make sense! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #11 from Jonathan Druart --- Created attachment 66675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66675&action=edit Add tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #10 from Katrin Fischer --- *** Bug 18366 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Any chance to get this moving again? I think this is one of the things that a lot of libraries would like. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18366 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #7) > Any chances to see tests covering this change? Changing status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #7 from Jonathan Druart --- Any chances to see tests covering this change? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #6 from Claudio --- (In reply to Mirko Tietgen from comment #5) > (In reply to Claudio from comment #4) > > > Alex, this is a great fix but does not work. I cannot figure the reason... > > We use this patch in production and it works. Maybe you have another problem > related to this feature which is not covered by the patch. Thanks Mirko! I noticed that changing ReservesControlBranch syspref to "item's home library" the fix works (in my Koha installation ReservesControlBranch was set to "patron's home library"). Is it right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #5 from Mirko Tietgen --- (In reply to Claudio from comment #4) > Alex, this is a great fix but does not work. I cannot figure the reason... We use this patch in production and it works. Maybe you have another problem related to this feature which is not covered by the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #4 from Claudio --- (In reply to Alex Buckley from comment #2) > Created attachment 63227 [details] [review] > Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default > hold policy > > If in the circ rules matrix you set "On shelf holds allowed" to "If all > unavailable", > default hold policy "From home library" is ignored. > > Test plan: > > - Have a test user from one branch (eg Centerville) > > - Set "On shelf holds allowed" to "If all unavailable" for your patron and > item > category (or everyone and everything) > - For "Default checkout, hold and return policy", set hold policy to "From > home library" > -> make sure there is no "Default holds policy by item type" to override > the setting > > - Have two items for a record. > 1. An item with home branch same as test user (eg Centerville) > -> check this item out to somebody else > 2. an item with a different home branch (eg Fairfield) > -> available, not checked out > - Try to place a hold for your test user. Does not work. > > - Apply the patch > - Try to place a hold. Should work now. > > Followed test plan, worked as intended > Signed-off-by: Alex Buckley Alex, this is a great fix but does not work. I cannot figure the reason... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #3 from Claudio --- I tested it in a local installation (16.11.07) but can not make it works... (see #18366) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Claudio changed: What|Removed |Added CC||cost...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Alex Buckley changed: What|Removed |Added Attachment #63157|0 |1 is obsolete|| --- Comment #2 from Alex Buckley --- Created attachment 63227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63227&action=edit Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold policy If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. Followed test plan, worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Mirko Tietgen changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Mirko Tietgen changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 --- Comment #1 from Mirko Tietgen --- Created attachment 63157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63157&action=edit Bug 18547 - On shelf holds allowed > "If all unavailable" ignores default hold policy If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", default hold policy "From home library" is ignored. Test plan: - Have a test user from one branch (eg Centerville) - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - For "Default checkout, hold and return policy", set hold policy to "From home library" -> make sure there is no "Default holds policy by item type" to override the setting - Have two items for a record. 1. An item with home branch same as test user (eg Centerville) -> check this item out to somebody else 2. an item with a different home branch (eg Fairfield) -> available, not checked out - Try to place a hold for your test user. Does not work. - Apply the patch - Try to place a hold. Should work now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18547] On shelf holds allowed > "If all unavailable" ignores default hold policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 Mirko Tietgen changed: What|Removed |Added Summary|On shelf holds allowed >|On shelf holds allowed > |"If all unavailable"|"If all unavailable" |ignores branch rules|ignores default hold policy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
