[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Fridolin SOMERS changed: What|Removed |Added Patch complexity|--- |Small patch CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #14 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #12 from Jonathan Druart --- Created attachment 65853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65853&action=edit Bug 18555: (QA-Followup) Remove duplicate code Remove duplicate code as of comment #7 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #11 from Jonathan Druart --- (In reply to Marc Véron from comment #6) > 2) and 3) could go to a new bug based on this one - I have not much time ATM. Could you open them please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Jonathan Druart changed: What|Removed |Added Attachment #63284|0 |1 is obsolete|| Attachment #65614|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 65852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65852&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc Véron changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #9 from Marc Véron --- Hope it's OK to set back to SO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #8 from Marc Véron --- Created attachment 65614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65614&action=edit Bug 18555: (QA-Followup) Remove duplicate code Remove duplicate code as of comment #7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555
--- Comment #7 from Nick Clemens ---
(In reply to Marc Véron from comment #6)
> (In reply to Nick Clemens from comment #5)
> Can you elaborate a little bit what you mean by 1) ?
109 #create a patronlist
110 my $createpatronlist = $input->param('createpatronlist') || 0;
111 my $dt = dt_from_string();
112 my $timestamp = $dt->ymd('-').' '.$dt->hms(':');
113 my $patronlistname = $uploadborrowers . ' (' . $timestamp .')';
124 #create a patronlist
125 my $createpatronlist = $input->param('createpatronlist');
126 my $dt = dt_from_string();
127 my $timestamp = $dt->ymd('-').' '.$dt->hms(':');
128 my $patronlistname = $uploadborrowers. ' (' . $timestamp .')';
We do this twice - if createpatronlist isn't checked we don't need to do the
rest of the setup
>
> 2) and 3) could go to a new bug based on this one - I have not much time ATM.
I will try to provide a followup or open a new bug for these.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #6 from Marc Véron --- (In reply to Nick Clemens from comment #5) > Nice! A couple things: > > 1 - Duplicated code for testing the input and generating the list name - we > should really only bother inside the check to create a list or not > 2 - We should link from the results page to the newly created list > 3 - We may want to optionally include overwritten borrowers in the list, > they are sort of imported - I see use case in a school that overwrites > patrons to update contact info/expiration and may generate new cards > regularly -not blocker but would be nice Hi Nick Can you elaborate a little bit what you mean by 1) ? 2) and 3) could go to a new bug based on this one - I have not much time ATM. Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #5 from Nick Clemens --- Nice! A couple things: 1 - Duplicated code for testing the input and generating the list name - we should really only bother inside the check to create a list or not 2 - We should link from the results page to the newly created list 3 - We may want to optionally include overwritten borrowers in the list, they are sort of imported - I see use case in a school that overwrites patrons to update contact info/expiration and may generate new cards regularly -not blocker but would be nice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #4 from Marc Véron --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Josef Moravec changed: What|Removed |Added Attachment #63242|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 63284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63284&action=edit [SIGNED-OFF] Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc Véron changed: What|Removed |Added Attachment #63241|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 63242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63242&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 --- Comment #1 from Marc Véron --- Created attachment 63241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63241&action=edit Bug 18555: Create patron list from patron import Create a patron list from imported patrons to be used for printing patron cards and other patron list related actions. To test: - Apply patch - Go to Home > Tools > Import patrons - Select a file to import and check new checkbox 'Create patron list' - Import file - Verify that in import results you see the time stamped name of the patronlist containig the imported patrons (if any patrons were imported) - Go to Home > Tools > Patron lists - Verify that the list shows up and contains the imported patrons https://bugs.koha-community.org/show_bug.cgi?id=15855 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18555] Create patron list from patron import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18555 Marc Véron changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=4115 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
