[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

 CC|bugzi...@warmlight.co.uk|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #37 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #36 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #35 from Nick Clemens  ---
(In reply to Andrew Isherwood from comment #34)
> Did you definitely run the database update and regenerated the schema after
> applying the bug? Sorry, I'm *sure* you did, but I thought it was worth
> mentioning.

Never be too sure - I can't recreate now either, moving back to PQA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591
Bug 18591 depends on bug 20995, which changed state.

Bug 20995 Summary: Add request ID to OPAC ILL requests display table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #34 from Andrew Isherwood  ---
(In reply to Nick Clemens from comment #30)
> Couple issues:
> 1 - Requests existing before this patch throw datatables errors when viewing
> requests:
> DataTables warning: table id=ill-requests - Requested unknown parameter
> 'comments' for row 0, column 8. For more information about this error,
> please see http://datatables.net/tn/4

I've not been able to replicate this at all Nick. I started with no requests at
all and without the bug applied. I created a couple of requests, obviously
lacking comments. I then applied the bug. The request list displayed perfectly,
showing the number of comments as 0 for each request. I then created a request
without any problem.

Did you definitely run the database update and regenerated the schema after
applying the bug? Sorry, I'm *sure* you did, but I thought it was worth
mentioning.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #33 from Andrew Isherwood  ---
To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the FreeForm backend from here:
  https://github.com/PTFS-Europe/koha-ill-freeform
- Create a FreeForm ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #32 from Andrew Isherwood  ---
I've started looking into this. Problems #2 & #3 both appear to be problems
with the Dummy backend. This backend hasn't seen any maintenance for over a
year and has now been replaced by the FreeForm backend as a "simple, no
dependency" backend.

I'll update the test plan accordingly.

Still looking at #1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #31 from Andrew Isherwood  ---
Thanks for that Nick. I think items 2 & 3 are not related to this enhancement,
they appear to be pre-existing bugs in the ILL module. I'll create bugs for
them.

#1 is an interesting one, I'd expect the "comments" property to be available,
even if it didn't exist when the request was available. Since it's seemingly a
datatables problem, I'll take an initial look and see what's going on. If it's
a problem in the original patches, I'll perhaps throw it in Magnus' direction
:-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #30 from Nick Clemens  ---
Couple issues:
1 - Requests existing before this patch throw datatables errors when viewing
requests:
DataTables warning: table id=ill-requests - Requested unknown parameter
'comments' for row 0, column 8. For more information about this error, please
see http://datatables.net/tn/4
2 - Instead of entering a borrowernumber, enter some letters in that field when
creating a request - Internal server error
3 - Enter an invalid borrowernumner - Internal server error

Ideally I think we should use a patron search here and not rely on the user to
come up with borrowernumbers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|7317|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #29 from Andrew Isherwood  ---
I had to squash:

https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80101

and

https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80104

as the problem in the first was causing it to fail to apply before it got to
the second which fixed the problem. So now they're a single patch which should
apply correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com
  Attachment #80104|0   |1
is obsolete||

--- Comment #28 from Andrew Isherwood  ---
Comment on attachment 80104
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80104
Bug 18591: (QA follow-up) Fix merge error in kohastructure.sql

This patch was squashed into
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80227

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #80102|0   |1
is obsolete||

--- Comment #25 from Andrew Isherwood  ---
Created attachment 80228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80228=edit
Bug 18591: Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

Signed-off-by: andrew.isherw...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #80103|0   |1
is obsolete||

--- Comment #26 from Andrew Isherwood  ---
Created attachment 80229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80229=edit
Bug 18591: (follow-up) Add missing html filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #80105|0   |1
is obsolete||

--- Comment #27 from Andrew Isherwood  ---
Created attachment 80230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80230=edit
Bug 18591: (follow-up) Add more POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #80101|0   |1
is obsolete||

--- Comment #24 from Andrew Isherwood  ---
Created attachment 80227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80227=edit
Bug 18591: Database updates

Signed-off-by: andrew.isherw...@ptfs-europe.com

Bug 18591: (QA follow-up) Fix merge error in kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||20941


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941
[Bug 20941] Displaying requests does not display request material type
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #22 from Katrin Fischer  ---
Created attachment 80104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80104=edit
Bug 18591: (QA follow-up) Fix merge error in kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #20 from Katrin Fischer  ---
Created attachment 80102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80102=edit
Bug 18591: Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

Signed-off-by: andrew.isherw...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #23 from Katrin Fischer  ---
Created attachment 80105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80105=edit
Bug 18591: (follow-up) Add more POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #21 from Katrin Fischer  ---
Created attachment 80103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80103=edit
Bug 18591: (follow-up) Add missing html filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80077|0   |1
is obsolete||
  Attachment #80078|0   |1
is obsolete||
  Attachment #80079|0   |1
is obsolete||
  Attachment #80081|0   |1
is obsolete||
  Attachment #80084|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 80101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80101=edit
Bug 18591: Database updates

Signed-off-by: andrew.isherw...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Small patch |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #18 from Andrew Isherwood  ---
Created attachment 80084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80084=edit
Bug 18591: (follow-up) Add more POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #17 from Andrew Isherwood  ---
Created attachment 80081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80081=edit
Bug 18591: (follow-up) Add missing html filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #79519|0   |1
is obsolete||

--- Comment #16 from Andrew Isherwood  ---
Created attachment 80079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80079=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

Signed-off-by: andrew.isherw...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #74965|0   |1
is obsolete||

--- Comment #14 from Andrew Isherwood  ---
Created attachment 80077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80077=edit
Update Schema - DO NOT PUSH

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #79518|0   |1
is obsolete||

--- Comment #15 from Andrew Isherwood  ---
Created attachment 80078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80078=edit
Bug 18591 - Database updates

Signed-off-by: andrew.isherw...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact||katrin.fisc...@bsz-bw.de
 Depends on||20995


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995
[Bug 20995] Add request ID to OPAC ILL requests display table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #74966|0   |1
is obsolete||

--- Comment #13 from Andrew Isherwood  ---
Created attachment 79519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79519=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

Signed-off-by: andrew.isherw...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-09-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Andrew Isherwood  changed:

   What|Removed |Added

  Attachment #74964|0   |1
is obsolete||

--- Comment #12 from Andrew Isherwood  ---
Created attachment 79518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79518=edit
Bug 18591 - Database updates

Signed-off-by: andrew.isherw...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591
Bug 18591 depends on bug 7317, which changed state.

Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Joe McGlynn  changed:

   What|Removed |Added

 CC||joe.mcgl...@educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |
   |y.org   |
  Component|Circulation |ILL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #11 from Magnus Enger  ---
Updated patches, using utf8mb4, are available now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #10 from Magnus Enger  ---
Created attachment 74966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74966=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

  Attachment #69274|0   |1
is obsolete||

--- Comment #9 from Magnus Enger  ---
Created attachment 74965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74965=edit
Update Schema - DO NOT PUSH

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

  Attachment #69273|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

  Attachment #69275|0   |1
is obsolete||

--- Comment #8 from Magnus Enger  ---
Created attachment 74964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74964=edit
Bug 18591 - Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|20536   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536
[Bug 20536] ILL: authnotrequired not explicitly unset
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||20536


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536
[Bug 20536] ILL: authnotrequired not explicitly unset
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2018-03-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #7 from M. Tompsett  ---
Comment on attachment 69273
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69273
Bug 18591 - Database updates

Review of attachment 69273:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18591=69273)
-

::: installer/data/mysql/kohastructure.sql
@@ +4194,5 @@
> +CONSTRAINT illcomments_ifk
> +  FOREIGN KEY (illrequest_id)
> +  REFERENCES illrequests ( illrequest_id )
> +  ON UPDATE CASCADE ON DELETE CASCADE
> +) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

utf8mb4, not just utf8. see bug 18336. I haven't tried yet, but this patch
might not apply because of this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #6 from Magnus Enger  ---
Created attachment 69275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69275=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #5 from Magnus Enger  ---
Created attachment 69274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69274=edit
Update Schema - DO NOT PUSH

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

  Attachment #69234|0   |1
is obsolete||
  Attachment #69272|0   |1
is obsolete||

--- Comment #4 from Magnus Enger  ---
Created attachment 69273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69273=edit
Bug 18591 - Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #3 from Magnus Enger  ---
Created attachment 69272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69272=edit
Bug 18591 - Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #2 from Magnus Enger  ---
Created attachment 69234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69234=edit
Bug 18591 - Allow any number of comments on ILLs

This patch makes it possible to add arbitrary comments to ILL
requests. Comments are read only and displayed in chronological
order. Comments can be added by librarians, but also added automatically
based on comments in the different protocols, so that comments from the
lending library can also be added.

To test:
- Enable the ILL module ("ILLModule" syspref + config in koha-conf.xml)
- Install the Dummy backend from here:
  https://github.com/PTFS-Europe/Dummy
- Create a Dummy ILL request
- Add comments to the request, checking that the name and borrowernumber
  of the person that added the comment is displayed ok
- Check that the displayed date and time the comment was submitted follows
  the "dateformat" syspref
- On the "List requests" page, check that the correct number of comments
  is displayed in the "Comments" column
- Check that the tests pass:
  prove t/db_dependent/Illcomments.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

--- Comment #1 from Magnus Enger  ---
Two important things to decide on here: 
- Should it be possible to edit comments? 
- Should it be possible to delete comments? 

I lean towards "no" for both questions, because it makes the code simpler and
it means the comments are historically correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18591] Allow an arbitrary number of comments on ILLs

2017-05-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591

Magnus Enger  changed:

   What|Removed |Added

 Blocks|7317|
 Depends on||7317


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/