[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Andrew Fuerste-Henry changed: What|Removed |Added Depends on||29842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29842 [Bug 29842] Item should be removed from rotating collection when item is deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Nick Clemens changed: What|Removed |Added Blocks|17202 | Depends on||17202 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #167 from Martin Renvoize --- Still hoping to move this one forward Josef? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #166 from Katrin Fischer --- Hi Josef, looking through some older bugs - should this still be FQA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #165 from Josef Moravec --- Created attachment 79161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79161&action=edit Bug 18606: Fix TT filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #164 from Josef Moravec --- (In reply to Alex Arnaud from comment #144) > Also, we lost the "reason" in error messages when adding/removing items. > - Failed to add item with barcode : Item is already in this > collection => Failed to add item with barcode > - Failed to add item with barcode unknown_barcode: No item with matching > barcode found=> Failed to add item with barcode unknown_barcode > - Failed to remove item with barcode unknown_barcode: No item with > matching barcode found => Failed to remove item with barcode unknown_barcode I rebased the patches on master and now I am working on the error messages, follow-up will come soon - hopefully -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #163 from Josef Moravec --- (In reply to Alex Arnaud from comment #143) > Comment on attachment 72574 [details] [review] > Bug 18606: Database changes - Add foreign keys to collections_tracking > > Review of attachment 72574 [details] [review]: > - > > ::: installer/data/mysql/kohastructure.sql > @@ +969,5 @@ > > + PRIMARY KEY (collections_tracking_id) > > +) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; > > + > > +ALTER TABLE `collections_tracking` > > + ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) > > REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE; > > Why did add constraints separatly from the table creation? It seems to me > that it is less readable for people wanting to quickly get the structure of > the table. No strong reason from me, fixed in follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #159 from Josef Moravec --- Created attachment 79155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79155&action=edit Bug 18606: Unify handling of success/error messages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #161 from Josef Moravec --- Created attachment 79157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79157&action=edit Bug 18606: (follow-up) Remove lines from collections_tracking referencing non existant objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #156 from Josef Moravec --- Created attachment 79152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79152&action=edit Bug 18606: Remove lefover of C4::RotatingCollections Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #162 from Josef Moravec --- Created attachment 79158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79158&action=edit Bug 18606: (follow-up) Do not add contraints in kohastructure.sql separately -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #155 from Josef Moravec --- Created attachment 79151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79151&action=edit Bug 18606: Get rid of isItemInAnyCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #157 from Josef Moravec --- Created attachment 79153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79153&action=edit Bug 18606: Rework tests for rotating collections Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #154 from Josef Moravec --- Created attachment 79150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79150&action=edit Bug 18606: Get rid of isItemInThisCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #160 from Josef Moravec --- Created attachment 79156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79156&action=edit Bug 18606: (follow-up) Make QA tools happy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #158 from Josef Moravec --- Created attachment 79154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79154&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #152 from Josef Moravec --- Created attachment 79148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79148&action=edit Bug 18606: Get rid of RemoveItemFromCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #153 from Josef Moravec --- Created attachment 79149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79149&action=edit Bug 18606: Get rid of TransferCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #148 from Josef Moravec --- Created attachment 79144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79144&action=edit Bug 18606: Schema changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #151 from Josef Moravec --- Created attachment 79147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79147&action=edit Bug 18606: Get rid of AddItemToCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #149 from Josef Moravec --- Created attachment 79145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79145&action=edit Bug 18606: Get rid of GetItemsInCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #150 from Josef Moravec --- Created attachment 79146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79146&action=edit Bug 18606: Get rid of GetCollectionItemBranches Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #147 from Josef Moravec --- Created attachment 79143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79143&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #146 from Josef Moravec --- Created attachment 79142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79142&action=edit Bug 18606: Easy ones - CRUD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What|Removed |Added Attachment #72572|0 |1 is obsolete|| Attachment #72573|0 |1 is obsolete|| Attachment #72574|0 |1 is obsolete|| Attachment #72575|0 |1 is obsolete|| Attachment #72576|0 |1 is obsolete|| Attachment #72577|0 |1 is obsolete|| Attachment #72578|0 |1 is obsolete|| Attachment #72579|0 |1 is obsolete|| Attachment #72580|0 |1 is obsolete|| Attachment #72581|0 |1 is obsolete|| Attachment #72582|0 |1 is obsolete|| Attachment #72583|0 |1 is obsolete|| Attachment #72584|0 |1 is obsolete|| Attachment #72585|0 |1 is obsolete|| Attachment #72586|0 |1 is obsolete|| Attachment #72587|0 |1 is obsolete|| Attachment #72816|0 |1 is obsolete|| --- Comment #145 from Josef Moravec --- Created attachment 79141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79141&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #144 from Alex Arnaud --- Also, we lost the "reason" in error messages when adding/removing items. - Failed to add item with barcode : Item is already in this collection => Failed to add item with barcode - Failed to add item with barcode unknown_barcode: No item with matching barcode found=> Failed to add item with barcode unknown_barcode - Failed to remove item with barcode unknown_barcode: No item with matching barcode found => Failed to remove item with barcode unknown_barcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #143 from Alex Arnaud --- Comment on attachment 72574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72574 Bug 18606: Database changes - Add foreign keys to collections_tracking Review of attachment 72574: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18606&attachment=72574) - ::: installer/data/mysql/kohastructure.sql @@ +969,5 @@ > + PRIMARY KEY (collections_tracking_id) > +) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci; > + > +ALTER TABLE `collections_tracking` > + ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) > REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE; Why did add constraints separatly from the table creation? It seems to me that it is less readable for people wanting to quickly get the structure of the table. @@ +973,5 @@ > + ADD CONSTRAINT `collections_tracking_ibfk_1` FOREIGN KEY (`colId`) > REFERENCES `collections` (`colId`) ON DELETE CASCADE ON UPDATE CASCADE; > + > +ALTER TABLE `collections_tracking` > + ADD CONSTRAINT `collections_tracking_ibfk_2` FOREIGN KEY (`itemnumber`) > REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE; > + idem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Alex Arnaud changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com |y.org | CC||alex.arn...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #142 from Josef Moravec --- (In reply to Kyle M Hall from comment #140) > QA question, should you not delete 'orphaned' collections_tracking rows > before adding the foreign key constraints? Thank for testing Kyle! I added a follow-up for this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #141 from Josef Moravec --- Created attachment 72816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72816&action=edit Bug 18606: (Follow-up) Remove lines from collections_tracking referencing non existant objects -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #140 from Kyle M Hall --- QA question, should you not delete 'orphaned' collections_tracking rows before adding the foreign key constraints? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #139 from Kyle M Hall --- Created attachment 72587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72587&action=edit Bug 18606: (Follow-up) Make QA tools happy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #136 from Kyle M Hall --- Created attachment 72584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72584&action=edit Bug 18606: Rework tests for rotating collections Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #135 from Kyle M Hall --- Created attachment 72583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72583&action=edit Bug 18606: Remove lefover of C4::RotatingCollections Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #138 from Kyle M Hall --- Created attachment 72586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72586&action=edit Bug 18606: Unify handling of success/error messages Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #137 from Kyle M Hall --- Created attachment 72585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72585&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #134 from Kyle M Hall --- Created attachment 72582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72582&action=edit Bug 18606: Get rid of isItemInAnyCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #132 from Kyle M Hall --- Created attachment 72580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72580&action=edit Bug 18606: Get rid of TransferCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #126 from Kyle M Hall --- Created attachment 72574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72574&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #133 from Kyle M Hall --- Created attachment 72581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72581&action=edit Bug 18606: Get rid of isItemInThisCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #128 from Kyle M Hall --- Created attachment 72576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72576&action=edit Bug 18606: Get rid of GetItemsInCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #129 from Kyle M Hall --- Created attachment 72577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72577&action=edit Bug 18606: Get rid of GetCollectionItemBranches Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #130 from Kyle M Hall --- Created attachment 72578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72578&action=edit Bug 18606: Get rid of AddItemToCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #131 from Kyle M Hall --- Created attachment 72579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72579&action=edit Bug 18606: Get rid of RemoveItemFromCollection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #127 from Kyle M Hall --- Created attachment 72575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72575&action=edit Bug 18606: Schema changes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #125 from Kyle M Hall --- Created attachment 72573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72573&action=edit Bug 18606: Easy ones - CRUD Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Kyle M Hall changed: What|Removed |Added Attachment #72416|0 |1 is obsolete|| Attachment #72417|0 |1 is obsolete|| Attachment #72418|0 |1 is obsolete|| Attachment #72419|0 |1 is obsolete|| Attachment #72420|0 |1 is obsolete|| Attachment #72421|0 |1 is obsolete|| Attachment #72422|0 |1 is obsolete|| Attachment #72423|0 |1 is obsolete|| Attachment #72424|0 |1 is obsolete|| Attachment #72425|0 |1 is obsolete|| Attachment #72426|0 |1 is obsolete|| Attachment #72427|0 |1 is obsolete|| Attachment #72428|0 |1 is obsolete|| Attachment #72429|0 |1 is obsolete|| Attachment #72430|0 |1 is obsolete|| Attachment #72431|0 |1 is obsolete|| --- Comment #124 from Kyle M Hall --- Created attachment 72572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72572&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #123 from Josef Moravec --- Created attachment 72431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72431&action=edit Bug 18606: (Follow-up) Make QA tools happy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #121 from Josef Moravec --- Created attachment 72429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72429&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #120 from Josef Moravec --- Created attachment 72428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72428&action=edit Bug 18606: Rework tests for rotating collections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #122 from Josef Moravec --- Created attachment 72430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72430&action=edit Bug 18606: Unify handling of success/error messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #119 from Josef Moravec --- Created attachment 72427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72427&action=edit Bug 18606: Remove lefover of C4::RotatingCollections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #110 from Josef Moravec --- Created attachment 72418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72418&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #118 from Josef Moravec --- Created attachment 72426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72426&action=edit Bug 18606: Get rid of isItemInAnyCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #109 from Josef Moravec --- Created attachment 72417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72417&action=edit Bug 18606: Easy ones - CRUD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #114 from Josef Moravec --- Created attachment 72422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72422&action=edit Bug 18606: Get rid of AddItemToCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #116 from Josef Moravec --- Created attachment 72424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72424&action=edit Bug 18606: Get rid of TransferCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #115 from Josef Moravec --- Created attachment 72423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72423&action=edit Bug 18606: Get rid of RemoveItemFromCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #111 from Josef Moravec --- Created attachment 72419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72419&action=edit Bug 18606: Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #112 from Josef Moravec --- Created attachment 72420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72420&action=edit Bug 18606: Get rid of GetItemsInCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What|Removed |Added Attachment #69709|0 |1 is obsolete|| Attachment #69710|0 |1 is obsolete|| Attachment #69711|0 |1 is obsolete|| Attachment #69712|0 |1 is obsolete|| Attachment #69713|0 |1 is obsolete|| Attachment #69714|0 |1 is obsolete|| Attachment #69715|0 |1 is obsolete|| Attachment #69716|0 |1 is obsolete|| Attachment #69717|0 |1 is obsolete|| Attachment #69718|0 |1 is obsolete|| Attachment #69719|0 |1 is obsolete|| Attachment #69720|0 |1 is obsolete|| Attachment #69721|0 |1 is obsolete|| Attachment #69722|0 |1 is obsolete|| Attachment #69723|0 |1 is obsolete|| Attachment #69759|0 |1 is obsolete|| --- Comment #108 from Josef Moravec --- Created attachment 72416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72416&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #117 from Josef Moravec --- Created attachment 72425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72425&action=edit Bug 18606: Get rid of isItemInThisCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #113 from Josef Moravec --- Created attachment 72421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72421&action=edit Bug 18606: Get rid of GetCollectionItemBranches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #107 from Josef Moravec --- (In reply to Owen Leonard from comment #105) > Testing functionality goes without any problem, but running "prove > t/db_dependent/Koha/Items.t t/db_dependent/Circu lation.t" gave this result: > > t/db_dependent/Circulation.t (Wstat: 65280 Tests: 42 Failed: 1) > Failed test: 41 > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 112 tests but ran 42. > > Also, running the QA tool highlighted some issues. Thanks for testing! I added a followup, test are passing now and QA tools return just one "warning" about pod coverage on Koha/RotatingCollection/Tracking.pm, but that is new file with no added methods, so there is nothing more to add to pod IMO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #106 from Josef Moravec --- Created attachment 69759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69759&action=edit Bug 18606: (followup) Make QA tools happy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #105 from Owen Leonard --- Testing functionality goes without any problem, but running "prove t/db_dependent/Koha/Items.t t/db_dependent/Circu lation.t" gave this result: t/db_dependent/Circulation.t (Wstat: 65280 Tests: 42 Failed: 1) Failed test: 41 Non-zero exit status: 255 Parse errors: Bad plan. You planned 112 tests but ran 42. Also, running the QA tool highlighted some issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #103 from Josef Moravec --- Created attachment 69722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69722&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #104 from Josef Moravec --- Created attachment 69723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69723&action=edit Bug 18606: Unify handling of success/error messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #98 from Josef Moravec --- Created attachment 69717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69717&action=edit Bug 18606: Get rid of TransferCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #96 from Josef Moravec --- Created attachment 69715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69715&action=edit Bug 18606: Get rid of AddItemToCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #99 from Josef Moravec --- Created attachment 69718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69718&action=edit Bug 18606: Get rid of isItemInThisCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #102 from Josef Moravec --- Created attachment 69721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69721&action=edit Bug 18606: Rework tests for rotating collections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #100 from Josef Moravec --- Created attachment 69719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69719&action=edit Bug 18606: Get rid of isItemInAnyCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #101 from Josef Moravec --- Created attachment 69720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69720&action=edit Bug 18606: Remove lefover of C4::RotatingCollections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #97 from Josef Moravec --- Created attachment 69716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69716&action=edit Bug 18606: Get rid of RemoveItemFromCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #93 from Josef Moravec --- Created attachment 69712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69712&action=edit Bug 18606: Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #94 from Josef Moravec --- Created attachment 69713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69713&action=edit Bug 18606: Get rid of GetItemsInCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #95 from Josef Moravec --- Created attachment 69714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69714&action=edit Bug 18606: Get rid of GetCollectionItemBranches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #91 from Josef Moravec --- Created attachment 69710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69710&action=edit Bug 18606: Easy ones - CRUD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What|Removed |Added Attachment #68428|0 |1 is obsolete|| Attachment #68429|0 |1 is obsolete|| Attachment #68430|0 |1 is obsolete|| Attachment #68431|0 |1 is obsolete|| Attachment #68432|0 |1 is obsolete|| Attachment #68433|0 |1 is obsolete|| Attachment #68434|0 |1 is obsolete|| Attachment #68435|0 |1 is obsolete|| Attachment #68436|0 |1 is obsolete|| Attachment #68437|0 |1 is obsolete|| Attachment #68438|0 |1 is obsolete|| Attachment #68439|0 |1 is obsolete|| Attachment #68440|0 |1 is obsolete|| Attachment #68441|0 |1 is obsolete|| Attachment #68442|0 |1 is obsolete|| Attachment #68443|0 |1 is obsolete|| --- Comment #90 from Josef Moravec --- Created attachment 69709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69709&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #92 from Josef Moravec --- Created attachment 69711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69711&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #89 from Josef Moravec --- Just rebased on master (conflict in C4/Circulation.pm because of bug 14826) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #86 from Josef Moravec --- Created attachment 68441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68441&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #88 from Josef Moravec --- Created attachment 68443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68443&action=edit Bug 18606: (followup) Fix double delete confirmation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #87 from Josef Moravec --- Created attachment 68442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68442&action=edit Bug 18606: Unify handling of success/error messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #85 from Josef Moravec --- Created attachment 68440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68440&action=edit Bug 18606: Rework tests for rotating collections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #77 from Josef Moravec --- Created attachment 68432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68432&action=edit Bug 18606: Get rid of GetItemsInCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #82 from Josef Moravec --- Created attachment 68437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68437&action=edit Bug 18606: Get rid of isItemInThisCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #83 from Josef Moravec --- Created attachment 68438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68438&action=edit Bug 18606: Get rid of isItemInAnyCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #81 from Josef Moravec --- Created attachment 68436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68436&action=edit Bug 18606: Get rid of TransferCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #84 from Josef Moravec --- Created attachment 68439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68439&action=edit Bug 18606: Remove lefover of C4::RotatingCollections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #79 from Josef Moravec --- Created attachment 68434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68434&action=edit Bug 18606: Get rid of AddItemToCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #78 from Josef Moravec --- Created attachment 68433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68433&action=edit Bug 18606: Get rid of GetCollectionItemBranches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #80 from Josef Moravec --- Created attachment 68435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68435&action=edit Bug 18606: Get rid of RemoveItemFromCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What|Removed |Added Attachment #67734|0 |1 is obsolete|| Attachment #67735|0 |1 is obsolete|| Attachment #67736|0 |1 is obsolete|| Attachment #67737|0 |1 is obsolete|| Attachment #67738|0 |1 is obsolete|| Attachment #67739|0 |1 is obsolete|| Attachment #67740|0 |1 is obsolete|| Attachment #67741|0 |1 is obsolete|| Attachment #67742|0 |1 is obsolete|| Attachment #67743|0 |1 is obsolete|| Attachment #67744|0 |1 is obsolete|| Attachment #67745|0 |1 is obsolete|| Attachment #67746|0 |1 is obsolete|| Attachment #67747|0 |1 is obsolete|| Attachment #67748|0 |1 is obsolete|| Attachment #67749|0 |1 is obsolete|| --- Comment #73 from Josef Moravec --- Created attachment 68428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68428&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #75 from Josef Moravec --- Created attachment 68430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68430&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/