[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |INVALID

--- Comment #9 from Marc Véron  ---
Sorry, there was nothing to fix. Mea culpa.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #8 from Jonathan Druart  
---
I do not understand the problem, please detail and propose a test plan for
translators.

What I see, before the patch (fr-FR)

 5465 #. SCRIPT
 5466 #: intranet-tmpl/prog/en/includes/cat-toolbar.inc:1
 5467 msgid ""
 5468 "%s item(s) are attached to this record. You must delete all items before
"
 5469 "deleting this record."
 5470 msgstr ""
 5471 "%s exemplaire(s) sont attachés à cette notice. Vous devez supprimer tous
les "
 5472 "exemplaires avant de supprimer cette notice."

After the patch applied and translate update fr-FR:

  592 #. %1$s:  END.
  593 #. %2$s:  IF CAN_user_editcatalogue_edit_catalogue or ( frameworkcode ==
'FA' and CAN_user_editcatalogue_fast_cataloging ).
  594 #. %3$s:  IF ( count ).
  595 #. %4$s:  BLOCK delrectitle.
  596 #. %5$s:  count.
  597 #. %6$s:  END.
  598 #: intranet-tmpl/prog/en/includes/cat-toolbar.inc:191
  599 #, fuzzy, c-format
  600 msgid ""
  601 "%s %s %s %s%s item(s) are attached to this record. You must delete all
items "
  602 "before deleting this record.%s "
  603 msgstr ""
  604 "%s exemplaire(s) sont attachés à cette notice. Vous devez supprimer tous
les "
  605 "exemplaires avant de supprimer cette notice."

AND

 5465 #. SCRIPT
 5466 #: intranet-tmpl/prog/en/includes/cat-toolbar.inc:1
 5467 msgid ""
 5468 "%s item(s) are attached to this record. You must delete all items before
"
 5469 "deleting this record."
 5470 msgstr ""
 5471 "%s exemplaire(s) sont attachés à cette notice. Vous devez supprimer tous
les "
 5472 "exemplaires avant de supprimer cette notice."

What is supposed to be better for translator?

Moreover it seems that the problem is the [% count %] in the string, but it is
needed to make the sentence translatable correctly in any languages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #7 from Jonathan Druart  
---
Ha yes, you might be right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

--- Comment #6 from Marc Véron  ---
(In reply to Jonathan Druart from comment #5)
> Marc, it would make more sense to use a TT variable instead of a block.

Not sure, the block contains text. If I assign a variable containing text, the
text is inside the tt directive - and will not be translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Marc, it would make more sense to use a TT variable instead of a block.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63776|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 63929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63929&action=edit
Bug 18650 - Translatability: Get rid of tt directive in translation for
cat-toolbar.inc

Translation tool shows [% count %] item(s) are... in translation for
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

This patch fixes it.

To test:
- Apply patch
- Go to a biblio record with at least 1 item attached
- Verify that tooltip for 'Edit > Delete record' shows same text as before
  (n item(s) are attached...)

(Amended to remove superfluous chomps 2017-05-27 mv)

Followed test plan and everything worked as intended
Signed-off-by: Alex Buckley 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-06-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Alex Buckley  changed:

   What|Removed |Added

  Attachment #63758|0   |1
is obsolete||

--- Comment #3 from Alex Buckley  ---
Created attachment 63776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63776&action=edit
Bug 18650 - Translatability: Get rid of tt directive in translation for
cat-toolbar.inc

Translation tool shows [% count %] item(s) are... in translation for
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

This patch fixes it.

To test:
- Apply patch
- Go to a biblio record with at least 1 item attached
- Verify that tooltip for 'Edit > Delete record' shows same text as before
  (n item(s) are attached...)

(Amended to remove superfluous chomps 2017-05-27 mv)

Followed test plan and everything worked as intended
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Marc Véron  changed:

   What|Removed |Added

  Attachment #63627|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 63758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63758&action=edit
Bug 18650 - Translatability: Get rid of tt directive in translation for
cat-toolbar.inc

Translation tool shows [% count %] item(s) are... in translation for
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

This patch fixes it.

To test:
- Apply patch
- Go to a biblio record with at least 1 item attached
- Verify that tooltip for 'Edit > Delete record' shows same text as before
  (n item(s) are attached...)

(Amended to remove superfluous chomps 2017-05-27 mv)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-05-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

Marc Véron  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18650] Translatability: Get rid of tt directive in translation for cat-toolbar.inc

2017-05-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18650

--- Comment #1 from Marc Véron  ---
Created attachment 63627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63627&action=edit
Bug 18650 - Translatability: Get rid of tt directive in translation for
cat-toolbar.inc

Translation tool shows [% count %] item(s) are... in translation for
koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

This patch fixes it.

To test:
- Apply patch
- Go to a biblio record with at least 1 item attached
- Verify that tooltip for 'Edit > Delete record' shows same text as before
  (n item(s) are attached...)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/