[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #46 from Victor Grousset/tuxayo --- Hi :) Here is an SQL query to detect orders and items (items.price) that were affected by this bug. And 2 others to fix these cases. And finally a large price check query that should p

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #45 from Victor Grousset/tuxayo --- Thanks Lucas and Fridolin! :D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bug

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #44 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@list

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #43 from Lucas Gass --- Thanks Victor, backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Josef Moravec changed: What|Removed |Added Attachment #86082|0 |1 is patch|

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #42 from Victor Grousset/tuxayo --- Applying the previous patch (Backport for 18.05) on top of current 17.11.x (tag v17.11.16) works. Test plan "ran" successfully. Lucas, Frido: is there anything else doable to help land

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #86082|1 |0 is pat

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #41 from Victor Grousset/tuxayo --- Created attachment 86082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86082&action=edit Backport of the patch to 18.05.x Cherry-picked from 18.11.x branch on top o

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Martin Renvoize changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communi

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #39 from Katrin Fischer --- The issue goes back as far as 17.11. Maybe a separate patch without the lines for replacement cost would work best (18.11 feature). -- You are receiving this mail because: You are watching al

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com ---

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #35 from Katrin Fischer --- Thx Jose-Mario and Victor! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koh

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #34 from Katrin Fischer --- Sorry, I am probably confusing (too early still). This should work for master and 18.11. Will just need to have the one line for replacement cost removed for lower versions. I know this is n

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Katrin Fischer changed: What|Removed |Added Attachment #84280|0 |1 is obsolete|

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexi

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #32 from Katrin Fischer --- This patch works fine for master, but I wonder about the lower versions. Maybe the addition of replacement cost for 18.11 changed something? It's not there in 17.11, so the same fix will not ap

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #31 from Katrin Fischer --- (In reply to José-Mario Monteiro-Santos from comment #30) > @Victor the patch is indeed obsolete, I simply forgot to mark it as such. > > @Katrin As Victor said, in CH format, 10,00 would be t

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #30 from José-Mario Monteiro-Santos --- @Victor the patch is indeed obsolete, I simply forgot to mark it as such. @Katrin As Victor said, in CH format, 10,00 would be treated as 1000 since commas are thousand separators

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #84150|0 |1 is ob

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #29 from Victor Grousset/tuxayo --- > I'll try to test myself, but not sure when time will allow. Don't worry, that's quite quick. It took me less than 10 min to test with the 3 syspref values. Including some time to get

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #28 from Katrin Fischer --- Sorry, quite confused here by now :( I'll try to test myself, but not sure when time will allow. If someone knows right away, what would be the expected behaviour for entering the actual pric

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #27 from Victor Grousset/tuxayo --- @José-Mario The patch "(Alternate Solution) Block form submission" is obsolete right? The previous functional discussion points toward using "Change dot into comma" if I understand corr

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #26 from Victor Grousset/tuxayo --- That's what I understood, good :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #25 from José-Mario Monteiro-Santos --- (In reply to Victor Grousset/tuxayo from comment #24) > Here are the result with the 3 formats, is that the expected behavior? > > CurrencyFormat: > - FR: > - dot: ok (act as de

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #24 from Victor Grousset/tuxayo --- Here are the result with the 3 formats, is that the expected behavior? CurrencyFormat: - FR: - dot: ok (act as decimal separator) - comma: ok (act as decimal separator) - US - do

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #84166|0 |1 is obsole

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 José-Mario Monteiro-Santos changed: What|Removed |Added Attachment #79892|0 |1 is ob

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 José-Mario Monteiro-Santos changed: What|Removed |Added Status|In Discussion |Needs Signoff

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #21 from Katrin Fischer --- I think what we want for the stable releases is consistent behaviour. If I have to add my data everywhere with a decimal dot (independent of the CurrencyFormat setting!) then I want that on the

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #20 from Katrin Fischer --- Can we just get a patch for now that makes this form behave like the rest of Koha again and keep elaborate better fixes for the next step? We have still not been able to fix the regression!

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #19 from Victor Grousset/tuxayo --- According to the QA and functionnal feedback that I got on bug 21507 and bug 12310: - here we must also use jQuery.validator - https://gitlab.com/tuxayo/Koha/compare/master...bug%2F2

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |In Discussion --

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #18 from José-Mario Monteiro-Santos --- (In reply to Victor Grousset/tuxayo from comment #16) > Hi, thanks for your help :) > > Something is a bit weird: > > >14- In Accounting details, notice the Actual cost is wr

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #83971|0 |1 is obsole

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #16 from Victor Grousset/tuxayo --- Hi, thanks for your help :) Something is a bit weird: >14- In Accounting details, notice the Actual cost is written with a > decimal dot. «Alright» >15- Change the Actual c

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.mont

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 José-Mario Monteiro-Santos changed: What|Removed |Added Status|Failed QA |Needs Signoff

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #15 from José-Mario Monteiro-Santos --- Created attachment 83971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83971&action=edit Bug 18723: (Alternate Solution) Block form submission When entering an

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #14 from Victor Grousset/tuxayo --- Quite complete discussion on the issue in the IRC channel: http://irc.koha-community.org/koha/2018-11-26#i_2100176 The current plan (bug 21507) is still valid from what I understand. A

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@bib

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr -- Y

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Commen

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #11 from Caroline Cyr La Rose --- Hi Josef, Thanks for the patch! I don't know if I didn't notice it before or if it's new, but when I change the actual cost to 20,99 (with a comma), the price once it's received is 20,0

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Josef Moravec changed: What|Removed |Added Depends on|12310 | Referenced Bugs: https:/

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #10 from Josef Moravec --- Created attachment 79892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79892&action=edit Bug 18723: Do not unformat price Test plan: a) Replicate the issue: 0- Set Curre

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are r

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Josef Moravec changed: What|Removed |Added CC||blac...@gmail.com,

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |NEW --- Comment #8 from Ka

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Katrin Fischer changed: What|Removed |Added Summary|Dot not recognized as |Dot not recognized as

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Status|ASSIGNED|BLOCKED --- Commen

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@co

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are rec

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@coll

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Depends on||12310 Referenced

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comme

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #4 from Victor Grousset/tuxayo --- caused by Bug 18471 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koh

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #3 from Victor Grousset/tuxayo --- Linked but not a duplicate. Needs an independent patch due to the specificities of the two different pages. The current plan is to make the order page take into account the CurrencyForm

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 paxed changed: What|Removed |Added CC||pasi.kalli...@joensuu.fi -- You ar

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Séverine Queune changed: What|Removed |Added Severity|enhancement |critical -- You are rece

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Séverine Queune changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |victor.grous...@biblibre.c

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #2 from Fridolin SOMERS --- You answered in Bug 19521 is it a mistake ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Fridolin SOMERS changed: What|Removed |Added Status|NEW |In Discussion

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 18723] Dot not recognized as decimal separator

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Séverine Queune changed: What|Removed |Added See Also||https://bugs.koha-communit