[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00, 18.11.04

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Owen Leonard changed: What|Removed |Added Status|Pushed to Stable|RESOLVED

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Blocks||22791 Referenced Bugs:

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Blocks||22618 Referenced Bugs:

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added Text to go in the||This patch introduces to

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added Keywords||Manual -- You are

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable ---

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #181 from Nick Clemens --- (In reply to Marcel de Rooy from comment #179) > QA Comment: > I re-entered the example with 8 * 16,99 and 42% discount, 19.45% tax. > > With the following results when patches applied: >

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA --- Comment

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83983|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83985|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83982|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83984|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83981|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83980|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83976|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83975|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83977|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83978|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83974|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83979|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Attachment #83973|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |BLOCKED --- Comment #165

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #164 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #163) > I think I'm happy with Nicks logic here.. > > Unfortunately, as we store calculated values we're open to having issues > like this. EDI

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #163 from Martin Renvoize --- I think I'm happy with Nicks logic here.. Unfortunately, as we store calculated values we're open to having issues like this. EDI for example can often give you both tax inclusive and tax

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #160 from Marcel de Rooy --- Small textual problems: +receiving=> 1 # boolean representing order stage, should pass only this or ordering +ordering => 1 # boolean representing order stage except fot --

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #159

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #158 from Nick Clemens --- (In reply to Marcel de Rooy from comment #144) > (In reply to Nick Clemens from comment #140) Ah, okay, I understand now - it seems we cannot leave the tax values untouched when enabling

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #83212|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #157 from Nick Clemens --- Created attachment 83985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83985=edit Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82977|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82976|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82974|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82975|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82973|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82970|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82971|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82972|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82968|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #82967|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #143 from Marcel de Rooy --- Created attachment 83214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83214=edit Test budget -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #142 from Marcel de Rooy --- Created attachment 83213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83213=edit Test basket -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #141 from Marcel de Rooy --- Created attachment 83212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83212=edit Bug 18736: (QA follow-up) Resolve uninitialized warn from Biblio.pm L3334 Running

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #140 from Nick Clemens --- Rebased on master (In reply to Marcel de Rooy from comment #127) > Look in C4::Budgets not Acquisition > > GetBudgetsPlanCell line 238, 251 ? > GetBudgetSpent line 335 > GetBudgetOrdered line

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #139 from Nick Clemens --- Created attachment 82977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82977=edit Bug 18736: (QA follow-up) Change to signed, add large int test [1] Add trivial subtest in

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #138 from Nick Clemens --- Created attachment 82976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82976=edit Bug 18736: (QA follow-up) Cosmetic changes [1] Resolve warnings like: Use of uninitialized

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #135 from Nick Clemens --- Created attachment 82973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82973=edit Bug 18736: Unit tests for GetBudgetHierarchy prove -v t/db_dependent/Budgets.t

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #137 from Nick Clemens --- Created attachment 82975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82975=edit Bug 18736: (follow-up) Remove duplicate code and adjust tests -- You are receiving this

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #136 from Nick Clemens --- Created attachment 82974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82974=edit Bug 18736: (follow-up) cast as UNSIGNED instead of INTEGER More recent MySql versions

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #130 from Nick Clemens --- Created attachment 82968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82968=edit Bug 18736: Use rounding syspref to determine correct prices in calculations To test: Place

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #133 from Nick Clemens --- Created attachment 82971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82971=edit Bug 18736: (follow-up) Add missing test cases We now fully cover GetBudgetsPlanCell in

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #134 from Nick Clemens --- Created attachment 82972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82972=edit Bug 18736: (follow-up) Fix missing rounding and bad formatting This patch: Adds a missing

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #131 from Nick Clemens --- Created attachment 82969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82969=edit Bug 18736: Unit tests for rounding Unit tests to highlight the issue To test: Prove

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #132 from Nick Clemens --- Created attachment 82970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82970=edit Bug 18736: (follow-up) Add tests and FIXME for GetbudgetsPlanCell prove

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #79098|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Brian changed: What|Removed |Added CC||bkl...@dubuque.lib.ia.us ---

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #127 from Marcel de Rooy --- Look in C4::Budgets not Acquisition GetBudgetsPlanCell line 238, 251 ? GetBudgetSpent line 335 GetBudgetOrdered line 366 ? GetBudgetHierarchy line 560, line 567 -- You are receiving this

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #126 from Nick Clemens --- (In reply to Marcel de Rooy from comment #125) > One area did not have attention yet: > > C4/Budgets.pm needs similar adjustments: > Look at e.g. SUM( COALESCE(unitprice_tax_included,

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #124 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #123) > Unable to finish this one right now, still in interface testing. Leaving it > in blocked, hope to return soon.. Resuming now -- You are

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #123 from Marcel de Rooy --- Unable to finish this one right now, still in interface testing. Leaving it in blocked, hope to return soon.. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #122 from Marcel de Rooy --- Created attachment 79563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79563=edit Bug 18736: (QA follow-up) Change to signed, add large int test [1] Add trivial subtest

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #121 from Marcel de Rooy --- Created attachment 79562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79562=edit Bug 18736: (QA follow-up) Cosmetic changes [1] Resolve warnings like: Use of

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #120 from Marcel de Rooy --- Got across this internal server error while testing: Undefined subroutine ::Acquisition::IsMarcStructureInternal called at /usr/share/koha/devclone/C4/Acquisition.pm line 3209. The famous

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #119 from Marcel de Rooy --- Would have expected a small change in t/Prices.t too btw -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #118 from Marcel de Rooy --- No blocker: Koha/Number/Price.pm return $self->value if $self->value > Number::Format::MAX_INT/100; What about self->value < -2**53 ? Big credit note.. -- You are receiving this mail

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #117

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Attachment #79187|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #113 from Nick Clemens --- Created attachment 79187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79187=edit Bug 18736: (follow-up) Remove duplicate code -- You are receiving this mail because: You

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #112 from Martin Renvoize --- QA Comment: _get_rounding_sql is present in both C4::Budgets and C4::Acquisitions, should this not be factored out somewhere to prevent it falling out of sync across the two locations? --

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #111 from Julian Maurice --- The bug status was 'Signed off' but it looks like it was never signed off... Well, it is now :-) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79090|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79092|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79091|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79087|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79093|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79094|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79088|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Julian Maurice changed: What|Removed |Added Attachment #79089|0 |1 is obsolete|

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #102 from Julian Maurice --- Thanks Nick! Reviewing this patchset once again, for the last time hopefully :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #101 from Nick Clemens --- Created attachment 79094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79094=edit Bug 18736: (follow-up) cast as UNSIGNED instead of INTEGER More recent MySql versions

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #97 from Nick Clemens --- Created attachment 79090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79090=edit Bug 18736: (follow-up) Add tests and FIXME for GetbudgetsPlanCell prove

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #96 from Nick Clemens --- Created attachment 79089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79089=edit Bug 18736: Unit tests for rounding Unit tests to highlight the issue To test: Prove

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #95 from Nick Clemens --- Created attachment 79088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79088=edit Bug 18736: Use rounding syspref to determine correct prices in calculations To test: Place

[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #99 from Nick Clemens --- Created attachment 79092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79092=edit Bug 18736: (follow-up) Fix missing rounding and bad formatting This patch: Adds a missing

  1   2   3   >