[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Pedro Amorim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||pedro.amo...@ptfs-europe.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #24 from Martin Renvoize  ---
Created attachment 155463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155463=edit
Bug 18783: DBIC Build

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #23 from Martin Renvoize  ---
Patch tidied and other minor QA script issues resolved inline.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #155458|0   |1
is obsolete||

--- Comment #22 from Martin Renvoize  ---
Created attachment 155462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155462=edit
Bug 18783: Allow automatic claims for serials

This patch adds a new script misc/cronjobs/serialsClaim.pl which send
email notification to all suppliers that have late or missing issues.
This is configurable per subscription and is disabled by default.

Test plan:
1. Create a new bookseller B1 with a delivery time of 5 days
2. Create a new daily subscription with bookseller B1 and enable
   automatic claims (new checkbox on the first page of
   subscription-add.pl)
3. Generate some late serials with an expected date in the past (some
   with more than 5 days in the past, some with less)
4. Create a notice for module "Claim serial issue" CLAIMSERIAL and write
   something in the 'Email' template
5. Run `misc/cronjobs/serialsClaims.pl --letter-code CLAIMSERIAL` and
   verify that it sends an email notification only for serials that were
   expected more than 5 days ago

Rescued-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #21 from Martin Renvoize  ---
Taking a look at some modernising patches now to bring it closer to current
guidelines/practices.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Patch doesn't apply |Needs Signoff

--- Comment #20 from Martin Renvoize  ---
Rebased ready for testing again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #124984|0   |1
is obsolete||

--- Comment #19 from Martin Renvoize  ---
Created attachment 155458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155458=edit
Bug 18783: Allow automatic claims for serials

This patch adds a new script misc/cronjobs/serialsClaim.pl which send
email notification to all suppliers that have late or missing issues.
This is configurable per subscription and is disabled by default.

Test plan:
1. Create a new bookseller B1 with a delivery time of 5 days
2. Create a new daily subscription with bookseller B1 and enable
   automatic claims (new checkbox on the first page of
   subscription-add.pl)
3. Generate some late serials with an expected date in the past (some
   with more than 5 days in the past, some with less)
4. Create a notice for module "Claim serial issue" CLAIMSERIAL and write
   something in the 'Email' template
5. Run `misc/cronjobs/serialsClaims.pl --letter-code CLAIMSERIAL` and
   verify that it sends an email notification only for serials that were
   expected more than 5 days ago

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #18 from Fridolin Somers  ---
@@ -1859,7 +1862,7 @@ sub GetLateOrMissingIssues {
 if ($supplierid) {
 $sth = $dbh->prepare(
 "SELECT
-serialid,  aqbooksellerid,name,
+serialid,  serial.aqbooksellerid,name,

This is outside of scope no ?
Maybe linked to Bug 18745

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #17 from Fridolin Somers  ---
installer/data/mysql/atomicupdate/bug-18783.pl needs exec file permission :
chmod 775

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #16 from Fridolin Somers  ---
+ use C4::Installer qw(column_exists);
Not sure this is needed in atomicupdate bug-18783.pl, I dont see it in existing
DBRevs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #15 from Katrin Fischer  ---
(In reply to Jessie Zairo from comment #13)
> When testing we got an error of DBIx::Class::Row::store_column(): No such
> column 'auto_claim_enabled' on Koha::Schema::Result::Subscription at
> /kohadevbox/koha/Koha/Object.pm line 79
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77

If you see an error like this, make sure that the database update has run and
if there is no Schema update patch, you need to 'refresh schema' in the sandbox
or run the dbic command.

Would love to see this back in the queues!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #14 from Fridolin Somers  ---
Hi,

This change looks like outside of scope :

@@ -502,7 +507,8 @@ sub SendAlerts {
 }

 my $success = try {
-$mail->send_or_die({ transport => $library->smtp_server->transport
});
+my $smtp_server = $library ? $library->smtp_server :
Koha::SMTP::Servers->get_default;
+$mail->send_or_die({ transport => $smtp_server->transport });
 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Fridolin Somers  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18745

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Jessie Zairo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #13 from Jessie Zairo  ---
When testing we got an error of DBIx::Class::Row::store_column(): No such
column 'auto_claim_enabled' on Koha::Schema::Result::Subscription at
/kohadevbox/koha/Koha/Object.pm line 79
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #12 from Julian Maurice  ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice  changed:

   What|Removed |Added

  Attachment #91428|0   |1
is obsolete||

--- Comment #11 from Julian Maurice  ---
Created attachment 124984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124984=edit
Bug 18783: Allow automatic claims for serials

This patch adds a new script misc/cronjobs/serialsClaim.pl which send
email notification to all suppliers that have late or missing issues.
This is configurable per subscription and is disabled by default.

Test plan:
1. Create a new bookseller B1 with a delivery time of 5 days
2. Create a new daily subscription with bookseller B1 and enable
   automatic claims (new checkbox on the first page of
   subscription-add.pl)
3. Generate some late serials with an expected date in the past (some
   with more than 5 days in the past, some with less)
4. Create a notice for module "Claim serial issue" CLAIMSERIAL and write
   something in the 'Email' template
5. Run `misc/cronjobs/serialsClaims.pl --letter-code CLAIMSERIAL` and
   verify that it sends an email notification only for serials that were
   expected more than 5 days ago

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #10 from Katrin Fischer  ---
I am sorry, doesn't apply - can we get another rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Laurence Rault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||laurence.ra...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #9 from Julian Maurice  ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice  changed:

   What|Removed |Added

  Attachment #64195|0   |1
is obsolete||

--- Comment #8 from Julian Maurice  ---
Created attachment 91428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91428=edit
Bug 18783: Allow automatic claims for serials

This patch adds a new script misc/cronjobs/serialsClaim.pl which send
email notification to all suppliers that have late or missing issues.
This is configurable per subscription and is disabled by default.

Test plan:
1. Create a new bookseller B1 with a delivery time of 5 days
2. Create a new daily subscription with bookseller B1 and enable
   automatic claims (new checkbox on the first page of
   subscription-add.pl)
3. Generate some late serials with an expected date in the past (some
   with more than 5 days in the past, some with less)
4. Create a notice for module "Claim serial issue" CLAIMSERIAL and write
   something in the 'Email' template
5. Run `misc/cronjobs/serialsClaims.pl --letter-code CLAIMSERIAL` and
   verify that it sends an email notification only for serials that were
   expected more than 5 days ago

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #7 from Fridolin SOMERS  ---
Needs rebase.
For example serials/subscription-add.pl has been modified by Bug 20461

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #6 from Katrin Fischer  ---
Would be nice to see this progressing, it's often asked for!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #5 from Katrin Fischer  ---
Ok, I have figured out a way to see the email:

1) Errors when running script
My message template was:

Das folgende Heft ist jetzt verfügbar:

<> <> <>

When I run the command, I receive some errors:
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
./misc/cronjobs/serialsClaim.pl --letter-code RLIST
Use of uninitialized value in substitution iterator at
/home/vagrant/kohaclone/C4/Letters.pm line 776.
Use of uninitialized value in substitution iterator at
/home/vagrant/kohaclone/C4/Letters.pm line 776.
Claim sent to Osiandersche Buchhandlung (3) for serials 3

The email is generated, but the placeholders are not being replaced.

2) Verbosity
I wonder if the success message should only be shown if you add -v, this way it
would be a bit less noisy when run as cronjob.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #4 from Katrin Fischer  ---
Hi Julian, 
that fixed the issue. 
I have tested adding and modifying subscriptions, the new option works nicely.
I have also run the command without errors, but then realized that I cannot
currently test emails on my installation. As they are not going through the
message_queue I can't verify them being sent/generated correctly right now. 
Leaving this Needs Signoff for now, maybe someone else can continue testing.

Note: You might want to add a test for the changes to SendAlert.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #3 from Julian Maurice  ---
Hi Katrin,

(In reply to Katrin Fischer from comment #2)
> kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
> ./misc/cronjobs/serialsClaim.pl --letter-code RLIST
> The method auto_claim_enabled is not covered by tests!

Did you run updatedatabase.pl and misc/devel/update_dbix_class_files.pl ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
This is another of the 'missing features' that I have been asked about often. I
have tried to test, but when running the script, I receive an error:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$
./misc/cronjobs/serialsClaim.pl --letter-code RLIST
The method auto_claim_enabled is not covered by tests!

Possible future enh: 
For servers with multiple instances it would be nice if the letter code could
be configured inside Koha. Either as a system preference or even better per
vendor, then you could have different letters for different languages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice  changed:

   What|Removed |Added

 Blocks||18784


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784
[Bug 18784] Add 'auto claim' option to subscription batch edit tool
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18783] Allow automatic claims for serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18783

--- Comment #1 from Julian Maurice  ---
Created attachment 64195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64195=edit
Bug 18783: Allow automatic claims for serials

This patch adds a new script misc/cronjobs/serialsClaim.pl which send
email notification to all suppliers that have late or missing issues.
This is configurable per subscription and is disabled by default.

Test plan:
1. Create a new bookseller B1 with a delivery time of 5 days
2. Create a new daily subscription with bookseller B1 and enable
   automatic claims (new checkbox on the first page of
   subscription-add.pl)
3. Generate some late serials with an expected date in the past (some
   with more than 5 days in the past, some with less)
4. Create a notice for module "Claim serial issue" CLAIMSERIAL and write
   something in the 'Email' template
5. Run `misc/cronjobs/serialsClaims.pl --letter-code CLAIMSERIAL` and
   verify that it sends an email notification only for serials that were
   expected more than 5 days ago

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/