https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Lisette Scheer changed:
What|Removed |Added
Blocks||22872
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Martin Renvoize changed:
What|Removed |Added
Blocks||22610
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Martin Renvoize changed:
What|Removed |Added
CC||kohapa...@gmail.com
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Martin Renvoize changed:
What|Removed |Added
Blocks||21791
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #56 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #55)
> Created attachment 75401 [details] [review]
> Bug 18786: Add PAYMENT_TYPE to the installer file
Pushed to master for 18.05
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #55 from Jonathan Druart
---
Created attachment 75401
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75401&action=edit
Bug 18786: Add PAYMENT_TYPE to the installer file
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #53 from Kyle M Hall ---
Created attachment 74436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74436&action=edit
Bug 18786: Remove duplicate block with bad IF
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #52 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #51)
> Take a look at the patch, the problem is obvious: the [% IF payment_types %]
> is duplicated. One has a call to ->count, the others not.
Ah, I *st
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #51 from Jonathan Druart
---
Take a look at the patch, the problem is obvious: the [% IF payment_types %] is
duplicated. One has a call to ->count, the others not.
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #50 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #49)
> Did you create AVs for PAYMENT_TYPE?
Yes, I tested every payment option with and without PAYMENT_TYPEs. In both
cases the av category itself exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #49 from Jonathan Druart
---
Did you create AVs for PAYMENT_TYPE?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #48 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #46)
> Just try to pay a fine.
I am completely unable to reproduce your error. Can you try again?
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Josef Moravec changed:
What|Removed |Added
QA Contact|josef.mora...@gmail.com |testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #47 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #46)
> Just try to pay a fine.
Thanks! Probably due to a recent change to master.
--
You are receiving this mail because:
You are watching all bug chan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #46 from Jonathan Druart
---
Just try to pay a fine.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #45 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #43)
> Hum, PQA, sure?
>
> Template process failed: undef error - The method count is not covered by
> tests! at /home/vagrant/kohaclone/C4/Templates.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Failed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #44 from Jonathan Druart
---
Created attachment 74172
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74172&action=edit
Bug 18786: Add PAYMENT_TYPE to the AV categories
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #43 from Jonathan Druart
---
Hum, PQA, sure?
Template process failed: undef error - The method count is not covered by
tests! at /home/vagrant/kohaclone/C4/Templates.pm line 122.
--
You are receiving this mail because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Josef Moravec changed:
What|Removed |Added
Attachment #72114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #42 from Josef Moravec ---
Created attachment 74149
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74149&action=edit
Bug 18786: Remove use of Koha::Patron::Images
Signed-off-by: Josef Moravec
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #41 from Josef Moravec ---
Created attachment 74148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74148&action=edit
Bug 18786: Add ability to create custom payment types
Some libraries would like to b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #39 from Josef Moravec ---
(In reply to Katrin Fischer from comment #38)
> Josef, do you have time to finish here?
Sorry, I missed this somehow, I'll take a look on this
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #38 from Katrin Fischer ---
Josef, do you have time to finish here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #37 from Kyle M Hall ---
(In reply to Josef Moravec from comment #35)
> Why did you added the cleaning of the code in C4/SIP/ILS.pm?
>
> It looks OK, but I think it's not related to this report.
No idea how the snuck i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Attachment #72282|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #35 from Josef Moravec ---
Why did you added the cleaning of the code in C4/SIP/ILS.pm?
It looks OK, but I think it's not related to this report.
--
You are receiving this mail because:
You are watching all bug change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #34 from Kyle M Hall ---
Created attachment 72282
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72282&action=edit
Bug 18786: Remove use of Koha::Patron::Images
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #33 from Katrin Fischer ---
As the payment types are ok as key value pairs and you wouldn't need more, I
think having them as an authorised value is ok. But we should start to make AV
translatable one by one (or all at on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #32 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #31)
> Cannot we try to be exhaustive and list all (or at least several to start)
> payment types in a separate table? We could have a FK at DB level and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #31 from Jonathan Druart
---
Cannot we try to be exhaustive and list all (or at least several to start)
payment types in a separate table? We could have a FK at DB level and make them
translatable.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #29 from Kyle M Hall ---
Created attachment 72115
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72115&action=edit
Bug 18786 - Add ability to create custom payment types
Some libraries would like to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Attachment #72015|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Claudio changed:
What|Removed |Added
CC||cost...@gmail.com
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #27 from Kyle M Hall ---
Created attachment 72016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72016&action=edit
Bug 18786 - Add ability to create custom payment types
Some libraries would like to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Attachment #71020|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #25 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #24)
> What I am not sure about is the relation to the already existing SIP payment
> types - will both work together nicely for reports etc?
Yes they wil
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #24 from Katrin Fischer ---
What I am not sure about is the relation to the already existing SIP payment
types - will both work together nicely for reports etc?
--
You are receiving this mail because:
You are watching a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Josef Moravec changed:
What|Removed |Added
QA Contact|tomasco...@gmail.com|josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Josef Moravec changed:
What|Removed |Added
Attachment #69156|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #22 from Josef Moravec ---
Created attachment 71021
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71021&action=edit
Bug 18786 - Add ability to create custom payment types
Some libraries would like to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #20 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #19)
> Found it - it was bug 5620!
That bug doesn't do what this one does. That one is specifically about SIP
payment types. Moreover, I see some issues w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #19 from Katrin Fischer ---
Found it - it was bug 5620!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #18 from Josef Moravec ---
(In reply to Katrin Fischer from comment #17)
> I think this is a duplicate of the older bug 5630 which is also signed off
> at the moment.
Katrin, which bug did you have in mind? This bug numb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #16 from Kyle M Hall ---
Created attachment 69157
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69157&action=edit
Bug 18786 - Add ability to create custom payment types
Some libraries would like to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Attachment #67476|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Attachment #67477|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Amit Gupta changed:
What|Removed |Added
CC||amitddng...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #13 from Kyle M Hall ---
Created attachment 67477
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67477&action=edit
Bug 18786 - Add ability to create custom payment types
Some libraries would like to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Attachment #64300|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #10 from Martha Fuerst ---
Got the following error when trying to pay a lost item charge, but fine is gone
from the account. No indication of payment on Account page or in
account_offsets table.
Software error:
{UNKNOWN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Martha Fuerst changed:
What|Removed |Added
CC||mfue...@hmcpl.org
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Marc Véron changed:
What|Removed |Added
Attachment #64288|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Marc Véron changed:
What|Removed |Added
Attachment #64202|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Marc Véron changed:
What|Removed |Added
Attachment #64203|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Attachment #64204|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #5 from Kyle M Hall ---
Ack! Thanks for the test plan! I'll get the patch set fixed up asap!
(In reply to Marc Véron from comment #4)
> Test plan was missing.
>
> I tested with following steps:
> Following test is OK:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
--- Comment #4
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Blocks||18790
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Patch complexity|--- |Medium patch
Stat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #2 from Kyle M Hall ---
Created attachment 64203
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64203&action=edit
Bug 18786 - Update schema
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #3 from Kyle M Hall ---
Created attachment 64204
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64204&action=edit
Bug 18786 - Add ability to create custom payment types
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
--- Comment #1 from Kyle M Hall ---
Created attachment 64202
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64202&action=edit
Bug 18786 - Update database
--
You are receiving this mail because:
You are watching a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
80 matches
Mail list logo
