[Koha-bugs] [Bug 18790] Add ability to void payments

2018-08-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||20629
 Depends on|20629   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629
[Bug 20629] Remove ability to 'reverse' payments
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790
Bug 18790 depends on bug 18786, which changed state.

Bug 18786 Summary: Add ability to create custom payment types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||20629


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20629
[Bug 20629] Remove ability to 'reverse' payments.
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #41 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #40 from Jonathan Druart  
---
Created attachment 74576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74576=edit
Bug 18790: Prevent the tests to fail if precision changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #39 from Kyle M Hall  ---
Created attachment 74162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74162=edit
Bug 18790 [QA Followup]: Use a transaction for voiding

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #74160|0   |1
is obsolete||

--- Comment #38 from Kyle M Hall  ---
Created attachment 74161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74161=edit
Bug 18790 [QA Followup]: Fix capitalization

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #37 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #31)
> Comment on attachment 72036 [details] [review]
> Bug 18790: Add logging for voided payments
> 
> Review of attachment 72036 [details] [review]:
> -
> 
> ::: Koha/Account/Line.pm
> @@ +18,4 @@
> >  use Modern::Perl;
> >  
> >  use Carp;
> > +use Data::Dumper;
> 
> Left over from debugging?

Just realized Dumper is used for action logs here. I'll restore that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #36 from Kyle M Hall  ---
Created attachment 74160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74160=edit
Bug 18790 [QA Followup]: Remove use of Data::Dumper, fix capitalization

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72035|0   |1
is obsolete||
  Attachment #72036|0   |1
is obsolete||
  Attachment #72037|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall  ---
Created attachment 74157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74157=edit
Bug 18790: Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #34 from Kyle M Hall  ---
Created attachment 74158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74158=edit
Bug 18790: Add logging for voided payments

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #35 from Kyle M Hall  ---
Created attachment 74159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74159=edit
Bug 18790: Add new account offsets to atomic update

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #32 from Katrin Fischer  ---
Comment on attachment 72035
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72035
Bug 18790: Add ability to void payments

Review of attachment 72035:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18790=72035)
-

Was looking for the line - found some other small stuff instead (sorry!)

::: installer/data/mysql/account_offset_types.sql
@@ +9,5 @@
>  ('Dropbox'),
>  ('Rental Fee'),
>  ('Fine Update'),
> +('Fine'),
> +('Void Payment');

Capitalization... but that's already a little late here.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ +60,4 @@
>[% CASE 'Pay00' %]Payment, thanks (cash via SIP2)
>[% CASE 'Pay01' %]Payment, thanks (VISA via SIP2)
>[% CASE 'Pay02' %]Payment, thanks (credit card via SIP2)
> +  [% CASE 'VOID' %]Payment, Voided

Capitalization - not too late here :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #31 from Katrin Fischer  ---
Comment on attachment 72036
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72036
Bug 18790: Add logging for voided payments

Review of attachment 72036:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18790=72036)
-

::: Koha/Account/Line.pm
@@ +18,4 @@
>  use Modern::Perl;
>  
>  use Carp;
> +use Data::Dumper;

Left over from debugging?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #30 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #29)
> *
> +use Koha::Patron::Images;
> 
> line readded by these patches

I'm not seeing this line in any of the patches. Can you point me to it?

> 
> * Koha::Account::Line->void must use a transaction to make sure the log will
> be done only if the offset has been created successfully.

Good idea!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #29 from Jonathan Druart  
---
*
+use Koha::Patron::Images;

line readded by these patches

* Koha::Account::Line->void must use a transaction to make sure the log will be
done only if the offset has been created successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #28 from Jonathan Druart  
---
Please add POD to the new method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Claudio  changed:

   What|Removed |Added

 CC||cost...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #27 from Kyle M Hall  ---
(In reply to Josef Moravec from comment #26)
> (In reply to Kyle M Hall from comment #22)
> > 
> > In addition to that, I've just added a followup to add payment voids to the
> > action logs as well!
> 
> Great!
> 
> And I just make the atomic update own file for this bug - in case it is not
> pushed together with bug 18786

Thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #26 from Josef Moravec  ---
(In reply to Kyle M Hall from comment #22)
> 
> In addition to that, I've just added a followup to add payment voids to the
> action logs as well!

Great!

And I just make the atomic update own file for this bug - in case it is not
pushed together with bug 18786

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #25 from Josef Moravec  ---
Created attachment 72037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72037=edit
Bug 18790: Add new account offsets to atomic update

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #24 from Josef Moravec  ---
Created attachment 72036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72036=edit
Bug 18790: Add logging for voided payments

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72018|0   |1
is obsolete||
  Attachment #72019|0   |1
is obsolete||
  Attachment #72021|0   |1
is obsolete||

--- Comment #23 from Josef Moravec  ---
Created attachment 72035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72035=edit
Bug 18790: Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #22 from Kyle M Hall  ---
(In reply to Josef Moravec from comment #15)
> (In reply to Katrin Fischer from comment #12)
> > Should we consider logging reversing or voiding payments somewhere? We have
> > talked to libraries that have to report regularly on money collected and
> > changing payments later on could cause confusing results if not used very
> > carefully.
> 
> I agree, we definitely need this for financial reports.

This patch set already includes account offsets for voided payments. All
modifications to accountlines are recorded in the account_offsets table to make
it a complete record of changes to a patron's account.

In addition to that, I've just added a followup to add payment voids to the
action logs as well!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72020|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 72021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72021=edit
Bug 18790: Add new account offsets to atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #20 from Kyle M Hall  ---
Created attachment 72020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72020=edit
Bug 18790: Add new account offsets to atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #19 from Kyle M Hall  ---
Created attachment 72019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72019=edit
Bug 18790: Add logging for voided payments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #72017|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 72018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72018=edit
Bug 18790: Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #69161|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 72017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72017=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #16 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #14)
> Also, wrong capitalization?

Yes, wrong capitalization too - for all the values, but these values are only
db keys, they are not showing anywhere (as I know), so no blocker for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |
 CC||josef.mora...@gmail.com

--- Comment #15 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #12)
> Should we consider logging reversing or voiding payments somewhere? We have
> talked to libraries that have to report regularly on money collected and
> changing payments later on could cause confusing results if not used very
> carefully.

I agree, we definitely need this for financial reports.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #14 from Katrin Fischer  ---
Also, wrong capitalization?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2018-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #13 from Josef Moravec  ---
Comment on attachment 69161
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69161
Bug 18790 - Add ability to void payments

Review of attachment 69161:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18790=69161)
-

::: installer/data/mysql/account_offset_types.sql
@@ +9,5 @@
>  ('Dropbox'),
>  ('Rental Fee'),
>  ('Fine Update'),
> +('Fine'),
> +('Void Payment');

This needs to be added as atomic update too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
Should we consider logging reversing or voiding payments somewhere? We have
talked to libraries that have to report regularly on money collected and
changing payments later on could cause confusing results if not used very
carefully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #69158|0   |1
is obsolete||
  Attachment #69159|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 69161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69161=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #10 from Kyle M Hall  ---
Created attachment 69159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69159=edit
Bug 18790 [QA Followup] - Store the new offset for the void

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67478|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 69158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69158=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65932|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 67478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67478=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Martha Fuerst  changed:

   What|Removed |Added

 CC||mfue...@hmcpl.org

--- Comment #7 from Martha Fuerst  ---
Everything looks good - void doesn't show up on Account Offsets table, but
fines restored successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #6 from bywatersandbo...@gmail.com ---
Created attachment 65932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65932=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

Signed-off-by: Koha-us conference 
Signed-off-by: BWS Sandboxes 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

bywatersandbo...@gmail.com changed:

   What|Removed |Added

  Attachment #65468|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

bywatersandbo...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bywatersandbo...@gmail.com

--- Comment #5 from bywatersandbo...@gmail.com ---
Patch tested with a sandbox, by Koha-us conference 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Cheryl  changed:

   What|Removed |Added

 CC||clack...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-08-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #64210|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 65468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65468=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #3 from Shella  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18790:
Cannot rebuild zebra: 
The command perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r
--wait-for-lock fails with the following error: 'perl
/home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock'
exited with value 2
The error message is: 
    Can't locate Koha/Account/Offsets.pm in @INC (you may need to install the
Koha::Account::Offsets module) (@INC contains: /home/koha/src /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1
/usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at
/home/koha/src/Koha/Account/Line.pm line 23.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account/Line.pm line
23.
Compilation failed in require at /home/koha/src/Koha/Account.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account.pm line 28.
Compilation failed in require at /home/koha/src/C4/Accounts.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Accounts.pm line 28.
Compilation failed in require at /home/koha/src/C4/Overdues.pm line 33.
BEGIN failed--compilation aborted at /home/koha/src/C4/Overdues.pm line 33.
Compilation failed in require at /home/koha/src/C4/Members.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/Members.pm line 30.
Compilation failed in require at /home/koha/src/C4/Reserves.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Reserves.pm line 28.
Compilation failed in require at /home/koha/src/C4/Circulation.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Circulation.pm line 28.
Compilation failed in require at /home/koha/src/C4/XSLT.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/XSLT.pm line 30.
Compilation failed in require at /home/koha/src/C4/Search.pm line 29.
BEGIN failed--compilation aborted at /home/koha/src/C4/Search.pm line 29.
Compilation failed in require at /home/koha/src/C4/AuthoritiesMarc.pm line 25.
BEGIN failed--compilation aborted at /home/koha/src/C4/AuthoritiesMarc.pm line
25.
Compilation failed in require at
/home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26.
BEGIN failed--compilation aborted at
/home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26. at
/home/koha/lib/contrib/sandbox/cron/../Run.pm line 28.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Shella  changed:

   What|Removed |Added

 CC||shellamarizjime...@yahoo.co
   ||m
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Shella  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 18790:
Cannot rebuild zebra: 
The command perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r
--wait-for-lock fails with the following error: 'perl
/home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock'
exited with value 2
The error message is: 
    Can't locate Koha/Account/Offsets.pm in @INC (you may need to install the
Koha::Account::Offsets module) (@INC contains: /home/koha/src /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1
/usr/lib/x86_64-linux-gnu/perl5/5.22 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.22 /usr/share/perl/5.22
/usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base .) at
/home/koha/src/Koha/Account/Line.pm line 23.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account/Line.pm line
23.
Compilation failed in require at /home/koha/src/Koha/Account.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Account.pm line 28.
Compilation failed in require at /home/koha/src/C4/Accounts.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Accounts.pm line 28.
Compilation failed in require at /home/koha/src/C4/Overdues.pm line 33.
BEGIN failed--compilation aborted at /home/koha/src/C4/Overdues.pm line 33.
Compilation failed in require at /home/koha/src/C4/Members.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/Members.pm line 30.
Compilation failed in require at /home/koha/src/C4/Reserves.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Reserves.pm line 28.
Compilation failed in require at /home/koha/src/C4/Circulation.pm line 28.
BEGIN failed--compilation aborted at /home/koha/src/C4/Circulation.pm line 28.
Compilation failed in require at /home/koha/src/C4/XSLT.pm line 30.
BEGIN failed--compilation aborted at /home/koha/src/C4/XSLT.pm line 30.
Compilation failed in require at /home/koha/src/C4/Search.pm line 29.
BEGIN failed--compilation aborted at /home/koha/src/C4/Search.pm line 29.
Compilation failed in require at /home/koha/src/C4/AuthoritiesMarc.pm line 25.
BEGIN failed--compilation aborted at /home/koha/src/C4/AuthoritiesMarc.pm line
25.
Compilation failed in require at
/home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26.
BEGIN failed--compilation aborted at
/home/koha/src/misc/migration_tools/rebuild_zebra.pl line 26. at
/home/koha/lib/contrib/sandbox/cron/../Run.pm line 28.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||2696


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696
[Bug 2696] Fine Payments Should Show What Was Paid For
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16486

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

--- Comment #1 from Kyle M Hall  ---
Created attachment 64210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64210=edit
Bug 18790 - Add ability to void payments

We've had the ability to 'reverse' a payment for a long time, but it
would be much better if we had a true void payment function that
replaces the paid amounts into the fee so that it appears as if the
payment was never made.

Test Plan:
1) Apply this patch and dependent patches
2) Run updatedatabase.pl
3) Create some fines
4) Pay those fines
5) Use the new 'void' button to void the payments
6) Note the fines were restored to their pre-payment amounts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18790] Add ability to void payments

2017-06-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/