[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #64830|0   |1
is obsolete||

--- Comment #16 from Mirko Tietgen  ---
Created attachment 64990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64990&action=edit
Bug 18851: Database handler must not be created at runtime

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #64832|0   |1
is obsolete||

--- Comment #18 from Mirko Tietgen  ---
Created attachment 64992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64992&action=edit
Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not
installed

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #64979|0   |1
is obsolete||

--- Comment #19 from Mirko Tietgen  ---
Created attachment 64993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64993&action=edit
Bug 18851: Fix 3 other tests

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #64831|0   |1
is obsolete||

--- Comment #17 from Mirko Tietgen  ---
Created attachment 64991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64991&action=edit
Bug 18851: Test::DBIx::Class is not needed in 00-load.t

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #15 from Mirko Tietgen  ---
Tests pass with the latest patch, nightly package + patch build works. I still
get the DB messages, but they seem to be only warnings then. Thanks! I'll do a
signoff when I get near a dev machine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #14 from Mirko Tietgen  ---
(In reply to Jonathan Druart from comment #13)
> I recreated the "Can't connect to MySQL server" errors, but actually they
> existed before bug 18266, there is nothing new here.

Thanks. It must have been pushed around the same time then I guess. Last
working nightly was June 5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #13 from Jonathan Druart  
---
I recreated the "Can't connect to MySQL server" errors, but actually they
existed before bug 18266, there is nothing new here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #12 from Jonathan Druart  
---
Created attachment 64979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64979&action=edit
Bug 18851: Fix 3 other tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #11 from Jonathan Druart  
---
I do not recreate the DB issues:

prove t/Biblio.t t/Biblio2.t
t/Biblio.t ... skipped: Need Test::DBIx::Class
t/Biblio2.t .. ok   
All tests successful.
Files=2, Tests=2,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.42 cusr  0.18
csys =  0.62 CPU)
Result: PASS

mysql is stopped and Test::DBIx::Class is not installed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #10 from Mirko Tietgen  ---
Created attachment 64913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64913&action=edit
build log: tests

Attached file: build log: tests. Problems with Test::DBIx::Class and missing DB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #9 from Mirko Tietgen  ---
Problems with missing Test::DBIx::Class are still present in

t/Patron.t
t/Search.t
t/SuggestionEngine_AuthorityFile.t

Additionally there are a lot of tests failing because of missing DB. They
should be skipped if DB is not available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #8 from Jonathan Druart  
---
non-dependent tests must be tested with and without Test::DBIx::Class and with
and without the DBMS running

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #7 from Jonathan Druart  
---
Mirko, could you confirm these patches fix the problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #6 from Jonathan Druart  
---
Created attachment 64832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64832&action=edit
Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not
installed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #5 from Jonathan Druart  
---
Created attachment 64831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64831&action=edit
Bug 18851: Test::DBIx::Class is not needed in 00-load.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #4 from Jonathan Druart  
---
Created attachment 64830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64830&action=edit
Bug 18851: Database handler must not be created at runtime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Ok, I am on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-07-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||m.de.r...@rijksmuseum.nl,
   ||olli-antti.kivila...@jns.fi
   ||, tomasco...@gmail.com

--- Comment #2 from Jonathan Druart  
---
My bad, I completely forgot that this module was not packaged.
So we have a problem here, the way we mocked our DB was not reliable and we
fixed it using Test::DBIx::Class.

Olli, Tomas, Marcel, any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18266   |
 Depends on|18266   |18226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226
[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266
[Bug 18266] Internal Server Error when paying fine for lost item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

--- Comment #1 from Mirko Tietgen  ---
Bug 18226 introduces a regression for a problem fixed in Bug 15150.

Test::DBIx::Class is not mandatory because it is not available in Debian,
packaging of Koha is broken because of the use in t/00-load.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18851] use Test::DBIx::Class in 00-load.t breaks packaging

2017-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18851

Mirko Tietgen  changed:

   What|Removed |Added

 Depends on||18266
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18266,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15150


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266
[Bug 18266] Internal Server Error when paying fine for lost item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/