[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-08-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

--- Comment #6 from Marc Véron  ---
(In reply to Katrin Fischer from comment #5)
> Aleisha++

+1  :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-08-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

--- Comment #5 from Katrin Fischer  ---
Aleisha++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-08-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

Aleisha Amohia  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|In Discussion   |RESOLVED

--- Comment #4 from Aleisha Amohia  ---
Both fair comments, I did not think of those cases. I'll set this to Resolved -
thanks for your input!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-08-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
I agree with Marc, this kind of very strict validation will probably cause more
problems than help. 
We are also used to enter phone numbers with spaces for better readability,
which is no longer possible with this patch. If this was implemented, it would
cause a lot of errors every time an existing record is edited.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Restriction to numbers only will lead to localization problems.

For ZIP codes / postal codes: Some countries use alphanumeric codes
https://en.wikipedia.org/wiki/Postal_code

For phone numbers: 
It is no longer possible to enter an interntaional number starting with +
https://en.wikipedia.org/wiki/List_of_country_calling_codes

It is no longer possible to enter a formatted number, e.g. in Switzerland we
often use
+41 61 123 45 67
where +41 is the country code and 61 the area code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-07-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

--- Comment #1 from Aleisha Amohia  ---
Created attachment 65013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65013=edit
Bug 18932: Implementing rules for validating number fields for borrower info

The fields I've added validation for are (in both OPAC and staff
client):
- phone
- secondary phone
- other phone
- fax
- zipcode
- alt address zipcode
- alt address phone
- alt contact zipcode
- alt contact phone
- SMS number (messaging preferences, may have to enable the
EnhancedMessagingPreferences and EnhancedMessagingPreferencesOPAC
sysprefs to see this)

To test:
1) In staff client, add a new patron or edit an existing one. Confirm
that attempting to enter symbols or letters in the above fields prevents
form submission
2) In OPAC, log in and edit your personal details. Confirm that
attempting to enter symbols or letters in the above fields prevents form
submission.
3) Go to your messaging preferences and confirm you can only save
numbers in the SMS number field

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-07-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-07-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18932] Validation not being completed on member entry for number fields

2017-07-12 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18932

Aleisha Amohia  changed:

   What|Removed |Added

Summary|Able to save symbols and|Validation not being
   |letters in SMS number for   |completed on member entry
   |messaging preferences   |for number fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/