[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 M. Tompsett changed: What|Removed |Added Attachment #65928|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 65936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65936&action=edit Bug 19088: plugins-upload causes error log noise After uploading a plugin the error log indicates use of uninitialized value in $op. This patch silences the noise. To test: 1) Set to 1 (one) in koha-conf.xml. 2) Set the UseKohaPlugins system preference to 'Enable'. 3) Navigate to Administration -> Manage plugins. 4) Install the test plugin KPZ file attached to this bug. 5) Notice the uninitialized value noise in the error log. 6) Uninstall the plugin (plack restart may be required if plack is enabled). 7) Apply patch. 8) Install the plugin again. 9) Notice no noise in the error log. 10) Run qa tools. 11) Run prove t/db_dependent/Plugins.t Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #4 from M. Tompsett --- Don't even need the plugin. Using the breadcrumbs to go back you can trigger the error over and over. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088
--- Comment #3 from M. Tompsett ---
Comment on attachment 65928
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65928
Bug 19088: plugins-upload causes error log noise
Review of attachment 65928:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19088&attachment=65928)
-
::: plugins/plugins-upload.pl
@@ +47,4 @@
>
> my $uploadfilename = $input->param('uploadfile');
> my $uploadfile = $input->upload('uploadfile');
> +my $op = $input->param('op') || q{};
// is better.
if 'op' is '0', then this would set $op to ''.
|| evaluates truthy only.
// is a defined check.
http://perldoc.perl.org/perlop.html#Logical-Defined-Or
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 --- Comment #2 from Lee Jamison --- Created attachment 65928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65928&action=edit Bug 19088: plugins-upload causes error log noise After uploading a plugin the error log indicates use of uninitialized value in $op. This patch silences the noise. To test: 1) Set to 1 (one) in koha-conf.xml. 2) Set the UseKohaPlugins system preference to 'Enable'. 3) Navigate to Administration -> Manage plugins. 4) Install the test plugin KPZ file attached to this bug. 5) Notice the uninitialized value noise in the error log. 6) Uninstall the plugin (plack restart may be required if plack is enabled). 7) Apply patch. 8) Install the plugin again. 9) Notice no noise in the error log. 10) Run qa tools. 11) Run prove t/db_dependent/Plugins.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Lee Jamison changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 --- Comment #1 from Lee Jamison --- Created attachment 65926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65926&action=edit Test Plugin KPZ Test plugin KPZ file to use to test this bug -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19088] plugins-upload.pl causes plack-error.log uninitialized value noise
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19088 Lee Jamison changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ldjami...@marywood.edu |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
