[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Keywords|release-notes-needed|

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druart changed: What|Removed |Added Keywords|

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Mason James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #33 from Chris Cormack --- It could be, but really it's just trying to complete the CAS spec you could equally consider it a Bugfix :) Might be nicer for the release notes to say new feature

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #32 from Jonathan Druart --- Should this considered as a new feature (instead of enhancement)? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #31 from Katrin Fischer --- Sorry for missing the last 2 and thx for fixing them! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #25 from Kyle M Hall --- Created attachment 72359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72359=edit Bug 19160: Move duplicated code to its own private subroutine

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #29 from Kyle M Hall --- Created attachment 72363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72363=edit Bug 19160: Remove tab characters causing qa script to fail

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #30 from Kyle M Hall --- Created attachment 72364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72364=edit Bug 19160: Add POD Signed-off-by: Kyle M Hall

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #26 from Kyle M Hall --- Created attachment 72360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72360=edit Bug 19160: Move the code from controller to C4::Auth_with_cas

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #27 from Kyle M Hall --- Created attachment 72361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72361=edit Bug 19160: Isolate CAS code into its own module Signed-off-by:

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #28 from Kyle M Hall --- Created attachment 72362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72362=edit Bug 19160: (follow-up) Fix problems introduced by renaming

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What|Removed |Added Attachment #71831|0 |1

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #23 from Katrin Fischer --- We found some small issues in testing as side effects of the rewrite, fixed in a follow-up. Kyle, could you take another look? Thx! -- You are receiving this mail

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Attachment #70408|0

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #22 from Katrin Fischer --- Created attachment 71835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71835=edit Bug 19160: (follow-up) Fix problems introduced by renaming

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Attachment #70442|0

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Attachment #71829|0

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Attachment #70441|0

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Attachment #71830|0

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Attachment #70440|0

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #16 from Katrin Fischer --- Created attachment 71829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71829=edit Bug 19160: CAS Single logout CAS supports single logout, where

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #15 from Katrin Fischer --- Found a small issue. The last patch renamed the routine logout_required to logout_if_required, but misses to change the import: C4/Auth.pm:import

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #14 from Katrin Fischer --- Some first feedback: We successfully tested the patches on our 16.11.x branch, but want to run some more tests. So far it's looking good! We will try to sign off

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Chris Cormack changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #9 from Jonathan Druart --- Created attachment 70440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70440=edit Bug 19160: Move duplicated code to its own

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #11 from Jonathan Druart --- Created attachment 70442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70442=edit Bug 19160: Isolate CAS code into its own module

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #10 from Jonathan Druart --- Created attachment 70441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70441=edit Bug 19160: Move the code from controller to

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Comment #8 is|1

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #7 from Jonathan Druart --- (In reply to Jonathan Druart from comment #5) > 3. I guess it is just my undestanding of CAS that is bad but why do we call > get_session then delete

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #6 from Chris Cormack --- (In reply to Jonathan Druart from comment #5) > > Another one: from the pod of CGI::Session->find : > "Experimental feature. > Note: find() is meant to be convenient,

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What|Removed |Added Attachment #66306|0 |1

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #3 from Katrin Fischer --- We have since used these patches successfully in production for several months, at first as a backport to 3.22, now in 16.11. No issues so far. The CAS logout will

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Attachment #66285|0

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Chris Cormack changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 --- Comment #1 from Chris Cormack --- Created attachment 66285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66285=edit Bug 19160 CAS Single logout CAS supports single logout, where if

[Koha-bugs] [Bug 19160] CAS Single Log Out

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19160 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun