[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #8 from Jonathan Druart --- Created attachment 74728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74728&action=edit Bug 19204: Add a test: holiday is expiration date -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #7 from Jonathan Druart --- Created attachment 74727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74727&action=edit Bug 19204: Clean the tests a bit to reuse the same pattern The same pattern is used several times in test: checkout, checkin, get the debarment, compare the dates and remove the debarment. Let's move that to a separate subroutine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #6 from Jonathan Druart --- Created attachment 74726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74726&action=edit Bug 19204: Make the debarment date calculation depends on finesCalendar This patchs adds the ability to calculate the end of the suspension date (debarment date) using the finesCalendar syspref. Prior to this patch it was never calculating without taking into account the calendar. calculated without taking holidays into account. This was a problem because the restriction could end in the middle of a period the library is closed. Test plan: - Set finescalendar to 'not including days the library is closed' - Set a circulation condition with no fine/maxfine, but fine days and max fine days instead - Check out an item with a due date in the past - Check the item in and verify the restriction date - Clean the restriction - Add holidays to your calendar on the calculated restriction date - Check the item out again with the same due date in the past - Check in the item again - Verify the calculated restriction end date has changed, it's set to the day after the holiday. Fines in days restriction calculation is correctly taking calendar into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Niamh changed: What|Removed |Added CC||niamh.walker-headon@it-tall ||aght.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Katrin Fischer changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #5 from Katrin Fischer --- We are looking into it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Tomás Cohen Arazi changed: What|Removed |Added Blocks||13958 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13958 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 [Bug 13958] Add a suspensionsCalendar syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- What is the status for this? Is anyone going to work on this for 18.05? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13958 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19804 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #3 from Katrin Fischer --- Actually looking at Bug 13909 - Suspension days calculation doesn't honour finesCalendar I think finesCalendar would be best. And update the description to say: Calculate fines and suspensions based on days overdue ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #2 from Katrin Fischer --- useDaysMode is used for calculating the due dates and usually not involved in the overdues process. I am not sure it's the right one. Maybe finesCalendar would be a better fit as it's already used to count the days overdue? So it would make sense to use it for determining the suspension date as well. With an update to the description. We could also have a new preference SuspensionCalendar mimicking the behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Gaetan Boisson changed: What|Removed |Added CC||gaetan.bois...@biblibre.com --- Comment #1 from Gaetan Boisson --- I guess this is a good thing. After discussing this with others we would suggest to make it work with useDaysMode, to be consistent with the library policy for computing return dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Christian Stelzenmüller changed: What|Removed |Added CC||christian.stelzenmueller@bs ||z-bw.de Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
