[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||cont...@alvet.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 73349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73349=edit
Bug 19223: Add methods to correctly handle plugin-generated output

This patch introduces two methods to be used by plugin authors:

->output
->output_html

They are basically wrappers for the helper methods from C4::Output
(output_html_with_http_headers and output_with_http_headers).

Plugin authors can use them, or keep the current flexibility of handling
the headers themselves in their code.

The KitchenSink plugin should be updated to highlight this.

To test:
- Run:
  $ kshell
 k$ prove t/db_dependent/Plugins.t
=> FAIL: The methods are not implemented
- Apply this patch
- Run:
 k$ prove t/db_dependent/Plugins.t
=> SUCCESS: Tests pass, and they are meaningful
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 73348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73348=edit
Bug 19223: Unit tests for output and output_html methods

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #9 from Tomás Cohen Arazi  ---
Common practice is to have the plugins print their output, but it is not
obvious that headers need to be generated correctly, etc. I will provide a
patch that adds helper methods, and this needs to be highlighted in the
KitchenSink plugin somehow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #8 from Tomás Cohen Arazi  ---
Steps to reproduce:

- Install some translation:
  $ kshell
 k$ cd misc/translator
 k$ perl translate install es-ES
 k$ exit
  $ restart_all
- Enable es-ES in the sysprefs (languages)
- Choose 'Español'
- Upload a plugin
(https://github.com/bywatersolutions/koha-plugin-csv2marc/releases)
- Choose to configure the plugin
=> FAIL: Double-encoded chars on the header, everywhere actually.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #6)
> Maybe some best practice is needed or a fix, hard to tell - EDS plugin is
> hard to test, is there another we could take a look at more closely?

When I put 'Tomás' in the author metadata for a plugin, it gets double-encoded
in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #6 from Katrin Fischer  ---
Maybe some best practice is needed or a fix, hard to tell - EDS plugin is hard
to test, is there another we could take a look at more closely?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #5 from Magnus Enger  ---
(In reply to Kyle M Hall from comment #4)
> The crux of the matter is the question of the bug being in Koha's plugin
> system, or is it a bug in the plugin?

I have seen it with more than one plugin. But those plugins might be based off
each other (I know I have copied the KitchenSink plugin as a starter for my own
plugins), so they might have the same bug...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #4 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #3)
> Moving forward with plugins, I think we need to make sure that encodings are
> correctly handled. Upping severity.

The crux of the matter is the question of the bug being in Koha's plugin
system, or is it a bug in the plugin?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|minor   |major

--- Comment #3 from Katrin Fischer  ---
Moving forward with plugins, I think we need to make sure that encodings are
correctly handled. Upping severity.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #2 from Magnus Enger  ---
Still a problem, with Koha 17.05.06.000 and version 17.11 of the EDS plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19223] Problem with plugins and encodings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223

--- Comment #1 from Magnus Enger  ---
Created attachment 68057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68057=edit
Encoding problems around the EDS plugin

The problem with encodings also shows up when the EDS API plugin is installed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/