[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301
Bug 19301 depends on bug 19300, which changed state.

Bug 19300 Summary: Move C4::Reserves::OPACItemHoldsAllowed to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19300

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #15 from Marcel de Rooy  ---
Created attachment 70109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70109=edit
Bug 19301: (QA follow-up) Add a few simple tests

We removed tests from Reserves.t, but would be nice to test the new
sub in IssuingRules.t too.
Adding a subtest there.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #14 from Marcel de Rooy  ---
Created attachment 70108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70108=edit
Bug 19301: (QA follow-up) Add POD, use statements and correct typo

Add POD for new sub in Koha/IssuingRules.pm.
Adding use Koha::IssuingRules to opac-detail and opac-MARCdetail.
Adding use Koha::Items to opac-detail and opac-MARCdetail.
Correct typo $items => $item in opac-MARCdetail.pl.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69847|0   |1
is obsolete||

--- Comment #13 from Marcel de Rooy  ---
Created attachment 70107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70107=edit
Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed

At this point the subroutine is not used anymore

Signed-off-by: Alex Buckley 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69846|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 70106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70106=edit
Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy

Following the pattern introduced by bug 19300, we are going to move the
OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy

Test plan:
Make sure the onshelfholds policy is correct when placing a hold

Signed-off-by: Alex Buckley 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #11 from Marcel de Rooy  ---
QA: Looking here now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||4319

--- Comment #10 from Jonathan Druart  
---
Rebased on top of bug 4319.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319
[Bug 4319] waiting and in transit items cannot be reserved
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67420|0   |1
is obsolete||
  Attachment #67421|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 69846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69846=edit
Bug 19301: Move C4::Reserves::OnShelfHoldsAllowed to get_onshelfholds_policy

Following the pattern introduced by bug 19300, we are going to move the
OnShelfHoldsAllowed logic to Koha::IssuingRules->get_onshelfholds_policy

Test plan:
Make sure the onshelfholds policy is correct when placing a hold

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

--- Comment #9 from Jonathan Druart  
---
Created attachment 69847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69847=edit
Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed

At this point the subroutine is not used anymore

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=4319

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #7 from Marcel de Rooy  ---
May I suggest to rebase this one on top of 4319 (which has taken quite some
time already) ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19301] Move C4::Reserves::OnShelfHoldsAllowed to the Koha namespace

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19301

Jonathan Druart  changed:

   What|Removed |Added

Summary|Move|Move
   |C4::Reserves::OnShelfHoldsA |C4::Reserves::OnShelfHoldsA
   |llowed to the code  |llowed to the Koha
   |namespace   |namespace

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/