[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Katrin Fischer changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Katrin Fischer changed: What|Removed |Added Keywords|Sandbox |release-notes-needed Status|Passed QA |Failed QA --- Comment #36 from Katrin Fischer --- Hi Nick, some questions: 1) It looks like these fields for items are MARC independent. They appear in the forms independent of a mapping to 952. Is this correct? 2) How would you import or export this data? 3) What would happen if they were mapped to a MARC subfield? (not in test plan) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #169470|0 |1 is obsolete|| --- Comment #35 from Nick Clemens (kidclamp) --- Created attachment 169507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169507&action=edit Bug 19316: Add CSRF protection Signed-off-by: baptiste Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #169469|0 |1 is obsolete|| --- Comment #34 from Nick Clemens (kidclamp) --- Created attachment 169506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169506&action=edit Bug 19316: Update items api definition Signed-off-by: baptiste Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #169468|0 |1 is obsolete|| --- Comment #33 from Nick Clemens (kidclamp) --- Created attachment 169505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169505&action=edit Bug 19316: Add sort1 and sort2 fields to interface and allow editing This patch adds the new sort1 and sort2 fields to the interface so that they can be viewed and edited Test plan: 1) Apply patch and reset_all 2) In the catalog, search for a record with at least one item 3) In the Holdings table, click on the barcode for an item. You should now be on /cgi-bin/koha/catalogue/moredetail.pl 4) Scroll down and observe that there is now a section called "Sort fields" with two fields, Sort 1 and Sort 2. 5) Enter some text in the textarea for Sort 1 (max 50 characters) and click Update 6) The page will refresh and your text should still be visible. Check that item in the database and the text should be stored in the sort1 column. 7) Repeat steps 5-6 for Sort 2. 8) Copy the barcode and navigate to Cataloging > Batch item modification 9) Enter the barcode in the textarea under "Or scan items one by one" (You can add multiple bar codes here if you wish) 10) Fill in the Required values (Home library, Current library, Koha item type) 11) In "Other attributes" there should be two fields, Sort 1 and Sort 2 12) Enter some text into both these fields 13) Click save and a job will be enqueued 14) Click "view detail of the enqueued job" 15) A message should be shown on completion that says "X item(s) modified (with Y field(s) modified)." X should match the number of barcodes that you entered into the batch mod and Y should equal X x 2 16) Check the item either in the interface or the database and the text you entered should now be stored and visible 17) Repeat steps 8 - 14 but this time only fill in Sort 1 18) This time X should equal the number of barcodes that you entered into the batch mod but Y should equal X as only one field was filled in. 19) Again, the text you entered should now be stored on the item record Signed-off-by: baptiste Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #169467|0 |1 is obsolete|| --- Comment #32 from Nick Clemens (kidclamp) --- Created attachment 169504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169504&action=edit Bug 19316: Add DBIC files Signed-off-by: baptiste Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #169466|0 |1 is obsolete|| --- Comment #31 from Nick Clemens (kidclamp) --- Created attachment 169503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169503&action=edit Bug 19316: Add sort1 and sort2 to items and deleteditems tables This patch adds to new fields to the items table to allow input for additional data into item records to help with sorting Sponsored-by: PTFS Europe Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #30 from Kyle M Hall --- > I can't recreate this, nor can I find a method anywhere called > set_bundle_items > I installed the patch and ran a reset_all and the test passes fine - is > there some additional config you have that I need to check with? It could be something about my setup. Let's go back to SO and see if another QA'er can have a go at it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #29 from Matt Blenkinsop --- (In reply to Kyle M Hall from comment #23) > I'm getting some odd behavior: > > t/db_dependent/api/v1/items/bundled_items.t (Wstat: 512 (exited 2) Tests: 1 > Failed: 1) > Failed test: 1 > Non-zero exit status: 2 > Parse errors: Bad plan. You planned 2 tests but ran 1. > > *** > DBIx::Class::Relationship::ManyToMany::many_to_many(): > *** > The many-to-many relationship 'bundle_items' is trying to create a utility > method > called set_bundle_items. > This will completely overwrite one such already existing method on class > Koha::Schema::Result::Item. > > You almost certainly want to rename your method or the many-to-many > relationship, as the functionality of the original method will not be > accessible anymore. > > To disable this warning set to a true value the environment variable > DBIC_OVERWRITE_HELPER_METHODS_OK I can't recreate this, nor can I find a method anywhere called set_bundle_items I installed the patch and ran a reset_all and the test passes fine - is there some additional config you have that I need to check with? I've rebased one of the commits to fix some tidying issues on the QA tests and add Baptiste's sign off line to all the commits rather than just the final one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #166593|0 |1 is obsolete|| --- Comment #28 from Matt Blenkinsop --- Created attachment 169470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169470&action=edit Bug 19316: Add CSRF protection Signed-off-by: baptiste -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #166301|0 |1 is obsolete|| --- Comment #27 from Matt Blenkinsop --- Created attachment 169469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169469&action=edit Bug 19316: Update items api definition Signed-off-by: baptiste -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #166300|0 |1 is obsolete|| --- Comment #26 from Matt Blenkinsop --- Created attachment 169468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169468&action=edit Bug 19316: Add sort1 and sort2 fields to interface and allow editing This patch adds the new sort1 and sort2 fields to the interface so that they can be viewed and edited Test plan: 1) Apply patch and reset_all 2) In the catalog, search for a record with at least one item 3) In the Holdings table, click on the barcode for an item. You should now be on /cgi-bin/koha/catalogue/moredetail.pl 4) Scroll down and observe that there is now a section called "Sort fields" with two fields, Sort 1 and Sort 2. 5) Enter some text in the textarea for Sort 1 (max 50 characters) and click Update 6) The page will refresh and your text should still be visible. Check that item in the database and the text should be stored in the sort1 column. 7) Repeat steps 5-6 for Sort 2. 8) Copy the barcode and navigate to Cataloging > Batch item modification 9) Enter the barcode in the textarea under "Or scan items one by one" (You can add multiple bar codes here if you wish) 10) Fill in the Required values (Home library, Current library, Koha item type) 11) In "Other attributes" there should be two fields, Sort 1 and Sort 2 12) Enter some text into both these fields 13) Click save and a job will be enqueued 14) Click "view detail of the enqueued job" 15) A message should be shown on completion that says "X item(s) modified (with Y field(s) modified)." X should match the number of barcodes that you entered into the batch mod and Y should equal X x 2 16) Check the item either in the interface or the database and the text you entered should now be stored and visible 17) Repeat steps 8 - 14 but this time only fill in Sort 1 18) This time X should equal the number of barcodes that you entered into the batch mod but Y should equal X as only one field was filled in. 19) Again, the text you entered should now be stored on the item record Signed-off-by: baptiste -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #166299|0 |1 is obsolete|| --- Comment #25 from Matt Blenkinsop --- Created attachment 169467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169467&action=edit Bug 19316: Add DBIC files Signed-off-by: baptiste -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #166298|0 |1 is obsolete|| --- Comment #24 from Matt Blenkinsop --- Created attachment 169466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169466&action=edit Bug 19316: Add sort1 and sort2 to items and deleteditems tables This patch adds to new fields to the items table to allow input for additional data into item records to help with sorting Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #23 from Kyle M Hall --- I'm getting some odd behavior: t/db_dependent/api/v1/items/bundled_items.t (Wstat: 512 (exited 2) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 2 Parse errors: Bad plan. You planned 2 tests but ran 1. *** DBIx::Class::Relationship::ManyToMany::many_to_many(): *** The many-to-many relationship 'bundle_items' is trying to create a utility method called set_bundle_items. This will completely overwrite one such already existing method on class Koha::Schema::Result::Item. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Baptiste changed: What|Removed |Added Attachment #166578|0 |1 is obsolete|| --- Comment #22 from Baptiste --- Created attachment 166593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166593&action=edit Bug 19316: Add CSRF protection Signed-off-by: baptiste -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Baptiste changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #21 from Baptiste --- Hi, It works perfectly, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #20 from Matt Blenkinsop --- I've rebased and added missing CRSF protection. Test plan works fine for me now, would you be able to try again? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #19 from Matt Blenkinsop --- Created attachment 166578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166578&action=edit Bug 19316: Add CSRF protection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Baptiste changed: What|Removed |Added CC||baptiste.bay...@inlibro.com --- Comment #18 from Baptiste --- Hi, I realized the test plan, but at the step 15) I have a message that say "No items modified.". The good item is found, but is not modified. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #17 from Matt Blenkinsop --- Rebased and managed to fix the QA tests without tidying the whole Items.pm file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #154967|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #154966|0 |1 is obsolete|| --- Comment #16 from Matt Blenkinsop --- Created attachment 166301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166301&action=edit Bug 19316: Update items api definition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #154965|0 |1 is obsolete|| --- Comment #15 from Matt Blenkinsop --- Created attachment 166300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166300&action=edit Bug 19316: Add sort1 and sort2 fields to interface and allow editing This patch adds the new sort1 and sort2 fields to the interface so that they can be viewed and edited Test plan: 1) Apply patch and reset_all 2) In the catalog, search for a record with at least one item 3) In the Holdings table, click on the barcode for an item. You should now be on /cgi-bin/koha/catalogue/moredetail.pl 4) Scroll down and observe that there is now a section called "Sort fields" with two fields, Sort 1 and Sort 2. 5) Enter some text in the textarea for Sort 1 (max 50 characters) and click Update 6) The page will refresh and your text should still be visible. Check that item in the database and the text should be stored in the sort1 column. 7) Repeat steps 5-6 for Sort 2. 8) Copy the barcode and navigate to Cataloging > Batch item modification 9) Enter the barcode in the textarea under "Or scan items one by one" (You can add multiple bar codes here if you wish) 10) Fill in the Required values (Home library, Current library, Koha item type) 11) In "Other attributes" there should be two fields, Sort 1 and Sort 2 12) Enter some text into both these fields 13) Click save and a job will be enqueued 14) Click "view detail of the enqueued job" 15) A message should be shown on completion that says "X item(s) modified (with Y field(s) modified)." X should match the number of barcodes that you entered into the batch mod and Y should equal X x 2 16) Check the item either in the interface or the database and the text you entered should now be stored and visible 17) Repeat steps 8 - 14 but this time only fill in Sort 1 18) This time X should equal the number of barcodes that you entered into the batch mod but Y should equal X as only one field was filled in. 19) Again, the text you entered should now be stored on the item record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #154964|0 |1 is obsolete|| --- Comment #14 from Matt Blenkinsop --- Created attachment 166299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166299&action=edit Bug 19316: Add DBIC files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Attachment #154963|0 |1 is obsolete|| --- Comment #13 from Matt Blenkinsop --- Created attachment 166298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166298&action=edit Bug 19316: Add sort1 and sort2 to items and deleteditems tables This patch adds to new fields to the items table to allow input for additional data into item records to help with sorting Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #12 from David Cook --- (In reply to Martin Renvoize from comment #11) > and David, were you happy with the permissions response? More or less heh. I think we have some significant design flaws with the REST API (particularly in terms of admin API vs public API), but that's out of scope for this one I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #11 from Martin Renvoize --- What was the conclusion here in the end? Do we need a rebase to resume testing or were we considering using additional fields as an alternative.. and David, were you happy with the permissions response? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Martin Renvoize changed: What|Removed |Added Keywords||Sandbox -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #10 from Matt Blenkinsop --- I think the staff permissions should be sufficient protection, this is currently the case on the items table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316
--- Comment #9 from David Cook ---
(In reply to David Cook from comment #8)
> At a glance, it looks like this data could leak out to the public through
> the API. How might that be prevented?
Then again... while it's available via REST API as exposed by the OPAC
website... it looks like you need to be a logged in staff user to see it.
If an API consumer is showing items, hopefully they're using a public endpoint
like http://kohadev.mydnsname.org:8080/api/v1/public/biblios/29/items
So maybe it's fine...
http://kohadev.mydnsname.org:8080/api/v1/items/73
{"error":"Authorization failure. Missing required
permission(s).","required_permissions":{"catalogue":"1"}}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #8 from David Cook --- At a glance, it looks like this data could leak out to the public through the API. How might that be prevented? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #7 from Matt Blenkinsop --- If the follow-up commit needs adding to its own bug then let me know and I'll happily do so, I just couldn't get the QA script to pass for that file without tidying the whole file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #6 from Matt Blenkinsop --- Created attachment 154967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154967&action=edit Bug 19316: (follow-up) Tidy Items.pm Items.pm kept failing the QA script despite all new lines having been tidied with perltidy. There must be a larger tidying issue in the file that is affecting all the new lines so I've tidied the whole file and added a separate commit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #5 from Matt Blenkinsop --- Created attachment 154966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154966&action=edit Bug 19316: Update items api definition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #4 from Matt Blenkinsop --- Created attachment 154965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154965&action=edit Bug 19316: Add sort1 and sort2 fields to interface and allow editing This patch adds the new sort1 and sort2 fields to the interface so that they can be viewed and edited Test plan: 1) Apply patch and reset_all 2) In the catalog, search for a record with at least one item 3) In the Holdings table, click on the barcode for an item. You should now be on /cgi-bin/koha/catalogue/moredetail.pl 4) Scroll down and observe that there is now a section called "Sort fields" with two fields, Sort 1 and Sort 2. 5) Enter some text in the textarea for Sort 1 (max 50 characters) and click Update 6) The page will refresh and your text should still be visible. Check that item in the database and the text should be stored in the sort1 column. 7) Repeat steps 5-6 for Sort 2. 8) Copy the barcode and navigate to Cataloging > Batch item modification 9) Enter the barcode in the textarea under "Or scan items one by one" (You can add multiple bar codes here if you wish) 10) Fill in the Required values (Home library, Current library, Koha item type) 11) In "Other attributes" there should be two fields, Sort 1 and Sort 2 12) Enter some text into both these fields 13) Click save and a job will be enqueued 14) Click "view detail of the enqueued job" 15) A message should be shown on completion that says "X item(s) modified (with Y field(s) modified)." X should match the number of barcodes that you entered into the batch mod and Y should equal X x 2 16) Check the item either in the interface or the database and the text you entered should now be stored and visible 17) Repeat steps 8 - 14 but this time only fill in Sort 1 18) This time X should equal the number of barcodes that you entered into the batch mod but Y should equal X as only one field was filled in. 19) Again, the text you entered should now be stored on the item record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #3 from Matt Blenkinsop --- Created attachment 154964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154964&action=edit Bug 19316: Add DBIC files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 --- Comment #2 from Matt Blenkinsop --- Created attachment 154963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154963&action=edit Bug 19316: Add sort1 and sort2 to items and deleteditems tables This patch adds to new fields to the items table to allow input for additional data into item records to help with sorting Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Matt Blenkinsop changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19316] Items should have sort1 and sort2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19316 Katrin Fischer changed: What|Removed |Added CC||matt.blenkinsop@ptfs-europe ||.com --- Comment #1 from Katrin Fischer --- *** Bug 32897 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
