[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Jonathan Druart changed: What|Removed |Added Blocks||24051 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #19) > From > commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea > Bug 19490: Add a 'Holds' column to the items batchmodification tool > > This following line: > +$this_row{item_holds} = Koha::Holds->search( itemnumber => > $itemnumber )->count; > > displays a DBIC warning: > [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client > 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: > DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use > search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm > line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: > http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl > > Must be ->search({ itemnumber => $itemnumber })->count See bug 24051. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Lucas Gass changed: What|Removed |Added Blocks||22914 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22914 [Bug 22914] Batch Item Delete column misconfigured when using show/hide tool -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #19 from Jonathan Druart --- From commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea Bug 19490: Add a 'Holds' column to the items batchmodification tool This following line: +$this_row{item_holds} = Koha::Holds->search( itemnumber => $itemnumber )->count; displays a DBIC warning: [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl Must be ->search({ itemnumber => $itemnumber })->count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|RESOLVED --- Comment #18 from Martin Renvoize --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemens changed: What|Removed |Added Attachment #80705|0 |1 is obsolete|| --- Comment #16 from Nick Clemens --- Created attachment 80708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80708=edit Bug 19490: (follow-up) Improve tooltip message and some tidying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #15 from Nick Clemens --- Created attachment 80705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80705=edit Bug 19490: (follow-up) Improve tooltip message and some tidying -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Katrin Fischer changed: What|Removed |Added Attachment #79429|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 80170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80170=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Katrin Fischer changed: What|Removed |Added Attachment #79430|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 80171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80171=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Katrin Fischer changed: What|Removed |Added Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #12 from Nick Clemens --- Rebasing (In reply to Jonathan Druart from comment #9) > 1. There are "Show/hide columns" links on top of the page, the new column is > not taken into account. This was intentional, there are two other columns at the start that cannot be hidden, this seemed appropriate for the holds info. I will attempt a followup > 2. Maybe we could improve the tooltip "Holds on this record: 0" => "No hold > on this record"? Will offer a followup shortly. > Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemens changed: What|Removed |Added Attachment #75533|0 |1 is obsolete|| --- Comment #10 from Nick Clemens --- Created attachment 79429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79429=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemens changed: What|Removed |Added Attachment #75534|0 |1 is obsolete|| --- Comment #11 from Nick Clemens --- Created attachment 79430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79430=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- 1. There are "Show/hide columns" links on top of the page, the new column is not taken into account. 2. Maybe we could improve the tooltip "Holds on this record: 0" => "No hold on this record"? Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #8 from Séverine Queune--- Just tested once more with follow-up, tooltip on each row is clear for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Séverine Queunechanged: What|Removed |Added Attachment #75489|0 |1 is obsolete|| --- Comment #6 from Séverine Queune --- Created attachment 75533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75533=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Séverine Queunechanged: What|Removed |Added Attachment #75516|0 |1 is obsolete|| --- Comment #7 from Séverine Queune --- Created attachment 75534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75534=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #5 from Nick Clemens--- Created attachment 75516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75516=edit Bug 19490: (follow-up) Add tooltip to each row To test: 1 - Run batch modification on some items 2 - Hover over the holds column 3 - Note the tool tip 4 - PLace some holds to verify combinations of item/record level holds show appropriately -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Séverine Queunechanged: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #4 from Séverine Queune --- That's interesting ! Works fine for me. A detail about css hiding : I had to use #tools_batchMod-edit .holds_count { display: none; } -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Séverine Queunechanged: What|Removed |Added Attachment #75321|0 |1 is obsolete|| --- Comment #3 from Séverine Queune --- Created attachment 75489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75489=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Séverine Queunechanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #2 from Owen Leonard--- > 6 - Note the column has a tooltip to indicate item vs. record holds I think it would be very helpful if we could have a tooltip on the table cells too: "0 item holds / 3 total holds" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemenschanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 --- Comment #1 from Nick Clemens--- Created attachment 75321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75321=edit Bug 19490: Add a 'Holds' column to the items batchmodification tool To test: 1 - Add some items to bathc modification 2 - Note there is no indication fo holds 3 - Apply patch 4 - Reload and note you can see how many holds (or none) 5 - Note you can hide this column with css: #batchMod-edit .holds_count { display: none; } 6 - Note the column has a tooltip to indicate item vs. record holds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com Assignee|je...@bywatersolutions.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Lisettechanged: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/