https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #43 from Katrin Fischer ---
Pushed for 24.05!
Well done everyone, thank you!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Pushed to main
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #42 from Pedro Amorim ---
Created attachment 165201
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165201=edit
Bug 19605: (QA follow-up): available_backends fix reduce
available_backends was only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Blocks||36650
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
CC||oleon...@myacpl.org
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #40 from Tomás Cohen Arazi ---
(In reply to Pedro Amorim from comment #39)
> (In reply to Tomás Cohen Arazi from comment #29)
> > I've just sent a PR for adjusting the sample plugin to the proposed changes.
>
> I got
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #39 from Pedro Amorim ---
(In reply to Tomás Cohen Arazi from comment #29)
> I've just sent a PR for adjusting the sample plugin to the proposed changes.
I got some errors testing it and followed up, please take a look
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #38 from Pedro Amorim ---
Created attachment 164091
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164091=edit
Bug 19605: Another fix after bug 35536
Signed-off-by: Pedro Amorim
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Attachment #163846|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Attachment #163007|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Attachment #163006|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Attachment #163005|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Attachment #163004|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Attachment #163003|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Attachment #163002|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #30 from Tomás Cohen Arazi ---
Created attachment 163846
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163846=edit
Bug 19605: Fix after bug 35536
Signed-off-by: Tomas Cohen Arazi
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
URL|https://github.com/ammopt/k |https://github.com/PTFS-Eur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #29 from Tomás Cohen Arazi ---
I've just sent a PR for adjusting the sample plugin to the proposed changes.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Tomás Cohen Arazi changed:
What|Removed |Added
URL|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #28 from Tomás Cohen Arazi ---
Sorry for the noise, I forgot to stamp my signature.
Remarks:
* I will submit on a follow-up bug an idea for some error checking we are
lacking here. No rush though. Will do on monday for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #27 from Tomás Cohen Arazi ---
Created attachment 163007
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163007=edit
Bug 19605: Clarify method name
Signed-off-by: Tomas Cohen Arazi
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #26 from Tomás Cohen Arazi ---
Created attachment 163006
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163006=edit
Bug 19605: Rename method and use the instantiated plugin in the call
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #25 from Tomás Cohen Arazi ---
Created attachment 163005
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163005=edit
Bug 19605: Tidy
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #24 from Tomás Cohen Arazi ---
Created attachment 163004
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163004=edit
Bug 19605: Add support for ILL backends as plugins
This is designed to maintain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #23 from Tomás Cohen Arazi ---
Created attachment 163003
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163003=edit
Bug 19605: Update expandTemplate to expand_template method name
Signed-off-by: David
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #162996|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #21 from Tomás Cohen Arazi ---
Created attachment 163001
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163001=edit
Bug 19605: Clarify method name
Signed-off-by: Tomas Cohen Arazi
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #20 from Tomás Cohen Arazi ---
Created attachment 163000
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163000=edit
Bug 19605: Rename method and use the instantiated plugin in the call
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #19 from Tomás Cohen Arazi ---
Created attachment 162999
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162999=edit
Bug 19605: Tidy
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #18 from Tomás Cohen Arazi ---
Created attachment 162998
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162998=edit
Bug 19605: Add support for ILL backends as plugins
This is designed to maintain
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #17 from Tomás Cohen Arazi ---
Created attachment 162997
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162997=edit
Bug 19605: Update expandTemplate to expand_template method name
Signed-off-by: David
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #160433|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Tomás Cohen Arazi changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #15 from Tomás Cohen Arazi ---
I been looking at the PluginBackend implementation, and got a bit confused
about this:
sub new_backend {
my ( $class, $params ) = @_;
my $self = {};
$self->{_logger} =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Depends on|19822 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
David Nind changed:
What|Removed |Added
Attachment #158070|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
David Nind changed:
What|Removed |Added
Attachment #158069|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
David Nind changed:
What|Removed |Added
Attachment #158068|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Blocks||35581
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #11 from Magnus Enger ---
(In reply to Pedro Amorim from comment #9)
> My suggestions is that we support both ways of loading ILL backends (old
> backend_dir way and this new plugin way) for a while (1 year? 2 years?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #10 from Katrin Fischer ---
(In reply to Pedro Amorim from comment #9)
> My suggestions is that we support both ways of loading ILL backends (old
> backend_dir way and this new plugin way) for a while (1 year? 2 years?)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #9 from Pedro Amorim ---
My suggestions is that we support both ways of loading ILL backends (old
backend_dir way and this new plugin way) for a while (1 year? 2 years?) and
after that period we deprecate the old
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #8 from Pedro Amorim ---
Instructions on converting old ILL backend into a plugin can be found at the
PluginBackend sample plugin https://github.com/ammopt/koha-ill-backend-plugin:
- Create your plugin, copy the contents
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #7 from Pedro Amorim ---
Created attachment 158070
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158070=edit
Bug 19605: Add support for ILL backends as plugins
This is designed to maintain existing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #6 from Pedro Amorim ---
Created attachment 158069
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158069=edit
Bug 19605: Update expandTemplate to expand_template method name
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #5 from Pedro Amorim ---
Created attachment 158068
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158068=edit
Bug 19605: Add 'ill_backend' plugin category
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Pedro Amorim changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |pedro.amo...@ptfs-europe.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #4 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #3)
> Lets make this happen for 23.11 :)
+ 1 :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Martin Renvoize changed:
What|Removed |Added
Component|Architecture, internals,|ILL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #3 from Martin Renvoize ---
Lets make this happen for 23.11 :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Martin Renvoize changed:
What|Removed |Added
Blocks|19822 |
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #2 from Michal Denar ---
+100 too :-)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
--- Comment #1 from Katrin Fischer ---
+100 :)
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Katrin Fischer changed:
What|Removed |Added
Blocks||23578
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Andrew Isherwood changed:
What|Removed |Added
CC|bugzi...@warmlight.co.uk|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Andrew Isherwood changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Bug 19605 depends on bug 18589, which changed state.
Bug 18589 Summary: Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Martin Renvoize changed:
What|Removed |Added
Blocks||19822
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Bug 19605 depends on bug 7317, which changed state.
Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Martin Renvoize changed:
What|Removed |Added
Depends on|20536
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Martin Renvoize changed:
What|Removed |Added
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Josef Moravec changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Caroline Cyr La Rose changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Josef Moravec changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Magnus Enger changed:
What|Removed |Added
Depends on||7317
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Magnus Enger changed:
What|Removed |Added
CC|
72 matches
Mail list logo