[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21050


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21050
[Bug 21050] Datepickers on LabelItemSearch broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #20 from Martin Renvoize  ---
Enhancement, not backporting to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #19 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75253|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 76163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76163=edit
Bug 19709: Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

This patch also modifies the templates to use the Bootstrap grid instead
of YUI, and removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Blocks||20641


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641
[Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Blocks|19959   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959
[Bug 19959] Update popup window templates to use Bootstrap grid: Label creator
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

--- Comment #17 from Owen Leonard  ---
*** Bug 19959 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

  Attachment #75155|0   |1
is obsolete||

--- Comment #16 from Claire Gravely  ---
Created attachment 75253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75253=edit
Bug 19709: Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

This patch also modifies the templates to use the Bootstrap grid instead
of YUI, and removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

  Attachment #72625|0   |1
is obsolete||
  Attachment #72701|0   |1
is obsolete||
  Attachment #73021|0   |1
is obsolete||

--- Comment #15 from Owen Leonard  ---
Created attachment 75155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75155=edit
Bug 19709: Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

This patch also modifies the templates to use the Bootstrap grid instead
of YUI, and removes obsolete "text/javascript" attributes from

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

--- Comment #14 from Olivier  ---
Same result the 'Cancel' link do nothing.
Am I missing something ?
I use a Sandbox with unimarc.
My test :
I created a new batch with only one item.
Then I test following the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

--- Comment #13 from Owen Leonard  ---
Created attachment 73021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73021=edit
Bug 19709 (follow-up) Add missing Greybox library files

This patch adds the Greybox assets to the label print template so that
Greybox-related JS functions will work correctly.

To test, apply the patch and go to Tools -> Label creator -> Manage ->
Label batches.

- Select a batch and click 'Export selected'
- In the modal window, click the 'Cancel' link. It should close the
  window.
- Click 'Export selected' again.
- Click 'Export'
- Click 'Done.'  The window should close.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Olivier  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Olivier  changed:

   What|Removed |Added

 CC||olivier.ro...@enssib.fr

--- Comment #12 from Olivier  ---
I reproduce the same problems with same steps.
As Claire said :
"- From 'Manage' I go to 'Label Batches'
- select one of the batches and click 'Export selected'
- Click the Cancel link in the frame ... and nothing happens. 

- Clicking 'Export' on the same page takes me to the options to download the
Batch.
- The 'Done' button in this frame does nothing. Whether I have downloaded
something or not. It can be closed using the 'Close' link in the top right
corner. "

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

--- Comment #11 from Owen Leonard  ---
Created attachment 72701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72701=edit
Bug 19709 (follow-up) Add KOHA_VERSION variables to js includes

This follow-up adds the new [%i KOHA_VERSION %] variable to some

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

  Attachment #72439|0   |1
is obsolete||

--- Comment #10 from Claire Gravely  ---
Created attachment 72625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72625=edit
Bug 19709 - Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

Edit: Fixed footer include error causing blank popup

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

  Attachment #71557|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 72439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72439=edit
Bug 19709 - Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

Edit: Fixed footer include error causing blank popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

 Depends on||20193


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193
[Bug 20193] Label export displaying on never-ending webpage
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70432|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 71557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71557=edit
Bug 19709 - Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

Edit: Fixed footer include error causing blank popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #7 from Owen Leonard  ---
I'm going to put this back to "needs signoff" in hopes that getting some more
testers might shed some light on why it works fine for me but not Claire.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #6 from Claire Gravely  ---
(In reply to Owen Leonard from comment #5)
> (In reply to Claire Gravely from comment #3)
> > - clicking 'add items' without entering any barcodes opens an empty frame
> 
> My updated patch fixes this.

This is now working


> 
> > - When exporting items or a batch, the 'cancel' link in the first frame
> > doesn't work
> > - After exporting, the 'done' button doesn't work
> 
> I can't reproduce these problems. Can you please try again and let me know
> if it's still happening?


yep. I still have these issues. These are my steps
- From 'Manage' I go to 'Label Batches'
- select one of the batches and click 'Export selected'
- Click the Cancel link in the frame ... and nothing happens. 

- Clicking 'Export' on the same page takes me to the options to download the
Batch.
- The 'Done' button in this frame does nothing. Whether I have downloaded
something or not. It can be closed using the 'Close' link in the top right
corner.

Both the 'Cancel' link and 'Done' button work on Master branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19959


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959
[Bug 19959] Update popup window templates to use Bootstrap grid: Label creator
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

--- Comment #5 from Owen Leonard  ---
(In reply to Claire Gravely from comment #3)
> - clicking 'add items' without entering any barcodes opens an empty frame

My updated patch fixes this.

> - When exporting items or a batch, the 'cancel' link in the first frame
> doesn't work
> - After exporting, the 'done' button doesn't work

I can't reproduce these problems. Can you please try again and let me know if
it's still happening?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

  Attachment #69418|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 70432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70432=edit
Bug 19709 - Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

Edit: Fixed footer include error causing blank popup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709
Bug 19709 depends on bug 19647, which changed state.

Bug 19647 Summary: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

--- Comment #3 from Claire Gravely  ---
When creating/managing batches I had the following issues:

- clicking 'add items' without entering any barcodes opens an empty frame
- When exporting items or a batch, the 'cancel' link in the first frame doesn't
work
- After exporting, the 'done' button doesn't work


The other parts seemed to be ok!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Depends on|19608   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||claire_grav...@hotmail.com

--- Comment #2 from Claire Gravely  ---
Cannot apply when the process reaches bug 19607 (one of the dependencies)

Applying: Bug 19607: Move admin templates JavaScript to the footer: Basic
parameters
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

--- Comment #1 from Owen Leonard  ---
Created attachment 69418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69418=edit
Bug 19709 - Move template JavaScript to the footer: Labels

This patch modifies the staff client label creator templates so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing batches
- Creating and managing templates
- Creating and managing printer profiles
- Creating quick spine labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/