[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 --- Comment #8 from Owen Leonard --- Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What|Removed |Added Attachment #71326|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 71476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71476&action=edit Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3 This patch modifies even more staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Vendor -> Vendor details - Contracts datatable - Edit vendor - Add contacts, form validation - Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt" - Datatables, MARC and Card previews - Transfer - Confirmation of transfer, window closes - Acquisitions -> Vendor -> Receive shipments - Datatables, date pickers - Acquisitions -> Available funds table -> Spent report - Datatables - Acquisitions -> Vendor -> Uncertain prices - Datatables, form validation - Acquisitions -> Vendor -> Basket -> Add to basket from external source - Select and clear all on search form - Search results - Datatables, MARC and Card previews, in-table pop-up controls (click any table cell) Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer changed: What|Removed |Added Attachment #70873|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 71326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71326&action=edit Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3 This patch modifies even more staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Vendor -> Vendor details - Contracts datatable - Edit vendor - Add contacts, form validation - Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt" - Datatables, MARC and Card previews - Transfer - Confirmation of transfer, window closes - Acquisitions -> Vendor -> Receive shipments - Datatables, date pickers - Acquisitions -> Available funds table -> Spent report - Datatables - Acquisitions -> Vendor -> Uncertain prices - Datatables, form validation - Acquisitions -> Vendor -> Basket -> Add to basket from external source - Select and clear all on search form - Search results - Datatables, MARC and Card previews, in-table pop-up controls (click any table cell) Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 --- Comment #5 from Katrin Fischer --- (In reply to Katrin Fischer from comment #3) > 1) With the patch applied the paging (next page, previous page) when > ordering from z39.50 are no longer working. Owen asked me to retest this and he was right - works like a charm now. > 2) Transferring from the invoice page opens in a new tab, while transferring > from the basket page opens a new window - shouldn't both behave the same? > Outside of the scope of this bug, as it's the same with and without the > patches. > > Owen, should we file a new bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #4 from Katrin Fischer --- Retesting... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- 1) With the patch applied the paging (next page, previous page) when ordering from z39.50 are no longer working. 2) Transferring from the invoice page opens in a new tab, while transferring from the basket page opens a new window - shouldn't both behave the same? Outside of the scope of this bug, as it's the same with and without the patches. Owen, should we file a new bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Claire Gravely changed: What|Removed |Added Attachment #69560|0 |1 is obsolete|| --- Comment #2 from Claire Gravely --- Created attachment 70873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70873&action=edit Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3 This patch modifies even more staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Vendor -> Vendor details - Contracts datatable - Edit vendor - Add contacts, form validation - Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt" - Datatables, MARC and Card previews - Transfer - Confirmation of transfer, window closes - Acquisitions -> Vendor -> Receive shipments - Datatables, date pickers - Acquisitions -> Available funds table -> Spent report - Datatables - Acquisitions -> Vendor -> Uncertain prices - Datatables, form validation - Acquisitions -> Vendor -> Basket -> Add to basket from external source - Select and clear all on search form - Search results - Datatables, MARC and Card previews, in-table pop-up controls (click any table cell) Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What|Removed |Added Blocks||20038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038 [Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Bug 19755 depends on bug 19753, which changed state. Bug 19753 Summary: Move template JavaScript to the footer: Acquisitions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19753 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What|Removed |Added Blocks||19947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947 [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What|Removed |Added Blocks|19931 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What|Removed |Added Blocks||19931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931 [Bug 19931] Update popup window templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 --- Comment #1 from Owen Leonard --- Created attachment 69560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69560&action=edit Bug 19755: Move template JavaScript to the footer: Acquisitions, part 3 This patch modifies even more staff client acquisitions templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Acquisitions -> Vendor -> Vendor details - Contracts datatable - Edit vendor - Add contacts, form validation - Acquisitions -> Vendor -> Invoices -> Invoice -> "Go to receipt" - Datatables, MARC and Card previews - Transfer - Confirmation of transfer, window closes - Acquisitions -> Vendor -> Receive shipments - Datatables, date pickers - Acquisitions -> Available funds table -> Spent report - Datatables - Acquisitions -> Vendor -> Uncertain prices - Datatables, form validation - Acquisitions -> Vendor -> Basket -> Add to basket from external source - Select and clear all on search form - Search results - Datatables, MARC and Card previews, in-table pop-up controls (click any table cell) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19755] Move template JavaScript to the footer: Acquisitions, part 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19755 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/