[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Jonathan Druartchanged: What|Removed |Added Blocks||19786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19786 [Bug 19786] Move template JavaScript to the footer: Authorities, part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Nick Clemenschanged: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED CC||n...@bywatersolutions.com --- Comment #17 from Nick Clemens --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #16 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 --- Comment #15 from Jonathan Druart--- Created attachment 71916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71916=edit Bug 19785: Replace intranet-tmpl with [% interface %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 --- Comment #14 from Katrin Fischer--- Hi Owen, QA tools complain, but I suspect false positives. Could you please double check? FAIL koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 102) forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 102) The line in the template is: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Katrin Fischerchanged: What|Removed |Added Attachment #71601|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 71902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71902=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Claire Gravelychanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Claire Gravelychanged: What|Removed |Added Attachment #71553|0 |1 is obsolete|| --- Comment #12 from Claire Gravely --- Created attachment 71601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71601=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Attachment #71390|0 |1 is obsolete|| --- Comment #11 from Owen Leonard --- Created attachment 71553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71553=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Claire Gravelychanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||claire_grav...@hotmail.com --- Comment #10 from Claire Gravely --- Hullo, when merging two authorities (merge.pl) I get: ReferenceError: _ is not defined merge.pl:54:9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Attachment #70565|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 71390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71390=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Blocks||19983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983 [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Attachment #69683|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 70565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70565=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 --- Comment #7 from Simon Pouchol--- Seems like it's a bug on Firefox, totally unrelated to this patch my bad. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 --- Comment #6 from Owen Leonard--- Sorry Simon, I don't understand the problem you're having! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Simon Poucholchanged: What|Removed |Added CC||simon.pouc...@biblibre.com --- Comment #5 from Simon Pouchol --- There seems to be an issue with suggestions from cache (not sure how to call them, when pressing down arrow or double-clicking on a text input to show previously used text) on the Z39.50 search form. When double clicking on a text field, these options immediately hide and have weird behavior overall. Might be unrelated to this patch ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 --- Comment #4 from Owen Leonard--- Created attachment 69683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69683=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Attachment #69662|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- Hi Dominic, if you find something wrong with a patch, please switch to 'failed QA', thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Dominic Pichettechanged: What|Removed |Added CC||dominic.piche...@inlibro.co ||m --- Comment #2 from Dominic Pichette --- I am not able to delete an authority from the results page. The confirmation window is shown but when I come back the authority is still there. Is there an Ajax call that is not working here or is it a problem from my DB maybe? Otherwise, everything works fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 --- Comment #1 from Owen Leonard--- Created attachment 69662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69662=edit Bug 19785: Move template JavaScript to the footer: Authorities, part 1 This patch modifies even more staff client authorities templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the modified templates: All button controls, DataTables functionality, tabs, etc. - Authorities - New from Z39.50 -> Search -> Results - New from Z39.50 - Deletion confirmation - Merge records -> Merge - Tabs - Tag selection -> Authority detail - Tabs - Deletion confirmation - New from Z39.50 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19785] Move template JavaScript to the footer: Authorities, part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19785 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/