https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #257 from Nick Clemens ---
*** Bug 21146 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to Master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #255 from Katrin Fischer ---
(In reply to Ere Maijala from comment #254)
> I've now updated https://wiki.koha-community.org/wiki/Elasticsearch with
> more up to date information about the configuration.
+1 Thx Ere!
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #254 from Ere Maijala ---
I've now updated https://wiki.koha-community.org/wiki/Elasticsearch with more
up to date information about the configuration.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #253 from David Gustafsson ---
Late to the party, but nice! Great work everyone!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Text to go in the||This patch significantly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #252 from Nicolas Legrand ---
Bravo!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #251 from Tomás Cohen Arazi ---
Congrats to everyone involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #249 from Ere Maijala ---
Actually, we don't have anything about Elasticsearch in the current manual, but
when this has been committed, I'd be happy to revise the wiki page at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #248 from Ere Maijala ---
I'll try to also post a pull request for an update to the manual.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #247 from Ere Maijala ---
Nick, I'm strongly supporting including these, and I'd like to nominate also
bug 19365 for consideration.
My test plan has been briefly put this:
1. Index records using the master version (and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Nick Clemens changed:
What|Removed |Added
Keywords||rel_18_11_candidate
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #245 from David Gustafsson ---
(In reply to Martin Renvoize from comment #243)
> Fantastic effort everyone.. thank you all for the perseverance and continual
> refinement of these patches and responses to feedback!
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #244 from Martin Renvoize ---
*** Bug 21331 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Keywords||Manual
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Keywords||release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82150|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82151|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82152|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #242 from Martin Renvoize ---
Created attachment 82267
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82267=edit
Bug 19893: (QA follow-up) Convert atomicupdate to .perl
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #241 from Martin Renvoize ---
Created attachment 82266
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82266=edit
Bug 19893: (QA follow-up) Spelling correction in POD
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82143|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82147|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82145|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82144|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82148|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82146|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Attachment #82149|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #230 from David Gustafsson ---
Great! Thanks for the help with rebasing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #229 from Ere Maijala ---
Thanks for your hard work David and Joonas! I've gone through the changes and
tested once more, and I believe we're ready for QA. I did a very minor rebase
caused by bug 18316 to mappings.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81965|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81966|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81964|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81962|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81963|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81961|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81959|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81960|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81957|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Attachment #81958|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Ere Maijala changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81955|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #78690|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #78693|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #78696|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #78694|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81284|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #78695|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81903|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #209 from David Gustafsson ---
Created attachment 81957
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81957=edit
Bug 19893: Alternative optimized indexing for Elasticsearch
Implement optimized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #78691|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #78692|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #208 from Joonas Kylmälä ---
(In reply to David Gustafsson from comment #207)
> Created new commit, if should be squashed I can do that if requested.
Seems separate enough from the rest of the non-signed-off-by commits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #207 from David Gustafsson ---
Created new commit, if should be squashed I can do that if requested.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #206 from David Gustafsson ---
Created attachment 81955
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81955=edit
Bug 19893: Increase test coverage
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #205 from David Gustafsson ---
But to clarify, I will increase test coverage and add test for
"ecode_record_from_result" on monday, and we can take it from there.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81901|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #203 from David Gustafsson ---
Forgot to add it to sysprefs.sql though, will fix this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #202 from David Gustafsson ---
*"I have _now_ replaced them with exceptions instead."
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #201 from David Gustafsson ---
(In reply to Joonas Kylmälä from comment #197)
> Thanks for the patch!
>
> Instead of croak or die the exceptions need to be used, e.g.
> Koha::Exceptions::Exception->throw(""). Please do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81822|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #199 from Joonas Kylmälä ---
The first patch's title "Bug 19893 - Alternative optimized indexing for
Elasticsearch" should be Bug 19893: Alternative optimized indexing for
Elasticsearch
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #198 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #197)
> Then we also need a test plan for this code. Like what steps need to be
> taken to index authorities and biblios and what should be the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #197 from Joonas Kylmälä ---
Thanks for the patch!
Instead of croak or die the exceptions need to be used, e.g.
Koha::Exceptions::Exception->throw(""). Please do a git diff
origin/master..HEAD to see all the dies and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #196 from David Gustafsson ---
I also took the liberty to fix commit line length to 80 (perhaps not for all
comments though), since some where a bit long.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #195 from David Gustafsson ---
Ok, thanks for the feedback! I think I fixed most things except:
(In reply to Joonas Kylmälä from comment #188)
> Comment on attachment 78690 [details] [review]
> Bug 19893 - Alternative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #194 from David Gustafsson ---
Created attachment 81822
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81822=edit
Bug 19893: Add code review fixes
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Katrin Fischer changed:
What|Removed |Added
Priority|P5 - low|P1 - high
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #193 from Joonas Kylmälä ---
Comment on attachment 78692
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78692
Bug 19893: Add index status
Review of attachment 78692:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #192 from Joonas Kylmälä ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #191 from Joonas Kylmälä ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #190 from Joonas Kylmälä ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #189 from Joonas Kylmälä ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #188 from Joonas Kylmälä ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #187 from Joonas Kylmälä ---
Comment on attachment 81284
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #186 from Joonas Kylmälä ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #185 from Ere Maijala ---
I'm okay with the big patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #184 from Joonas Kylmälä ---
If one big commit is fine for everybody else then I can pass it through this
time. And if you come across the situation again where you have to change the
commit or split them up you can do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
Martin Renvoize changed:
What|Removed |Added
Blocks||21331
See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #183 from David Gustafsson ---
What you could do is to to click "Show Obsolute" and download the two latest
patches, then run "interdiff old_patch.patch new_patch.patch" and you will get
the latest changes.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #182 from David Gustafsson ---
(In reply to Joonas Kylmälä from comment #181)
> Hi,
>
> could you still split the changes to their own commits?
I was considering your previous comment:
(In reply to Joonas Kylmälä
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #181 from Joonas Kylmälä ---
Hi,
could you still split the changes to their own commits?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81015|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #179 from Joonas Kylmälä ---
(In reply to Jonathan Druart from comment #176)
> Or moved to Koha::FieldMappings.
> Tests must be provided in either case.
Koha::FieldMappings is not really related to the MARC to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #178 from David Gustafsson ---
There is also no meaningful way of testing them in isolation, tests cover them
through the tests for "marc_records_to_document".
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #177 from David Gustafsson ---
I can have a look at this an move the subs out, I confused them with another
case where closures where used, so no closures thus they work also outside. I
don't really agree this is an
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
e.betemps changed:
What|Removed |Added
CC||e.bete...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #176 from Jonathan Druart
---
(In reply to Nick Clemens from comment #175)
> The subroutine should be moved to the top level
Or moved to Koha::FieldMappings.
Tests must be provided in either case.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #175 from Nick Clemens ---
(In reply to Joonas Kylmälä from comment #174)
> (In reply to David Gustafsson from comment #173)
> > I agree It might benefit from documentation, it should (or even can) not be
> > moved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #174 from Joonas Kylmälä ---
(In reply to David Gustafsson from comment #173)
> I agree It might benefit from documentation, it should (or even can) not be
> moved outside though, since I think there are some closures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #173 from David Gustafsson ---
I agree It might benefit from documentation, it should (or even can) not be
moved outside though, since I think there are some closures within. It is also
a specific and private
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #172 from Joonas Kylmälä ---
Comment on attachment 78690
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78690
Bug 19893 - Alternative optimized indexing for Elasticsearch
Review of attachment 78690:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #171 from David Gustafsson ---
(In reply to Joonas Kylmälä from comment #168)
> Comment on attachment 80971 [details] [review]
> Bug 19893: Add pods, remove syspref, add tests for serialization format
>
> Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #81014|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
David Gustafsson changed:
What|Removed |Added
Attachment #80971|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #168 from Joonas Kylmälä ---
Comment on attachment 80971
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80971
Bug 19893: Add pods, remove syspref, add tests for serialization format
Review of
1 - 100 of 290 matches
Mail list logo
