[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED --- Comment #30 from Fridolin SOMERS --- Depending on Bug 18298 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #29 from Nick Clemens --- Awesome work all, backported to stable for 17.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Andreas Jonsson changed: What|Removed |Added CC||andreas.jons...@kreablo.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 John Yorio changed: What|Removed |Added CC||jyo...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Joe McGlynn changed: What|Removed |Added CC||joe.mcgl...@educampus.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #28 from Agnes Rivers-Moore --- (In reply to Agnes Rivers-Moore from comment #22) > (In reply to Josef Moravec from comment #21) > > (In reply to Agnes Rivers-Moore from comment #17) > > > Our Koha as of 17.11.03 does not generate default username for any patron > > > type. > > > Josef said 'Other categories (than org) have username generated as > > > "firstname.surname" if you leave it blank' - but that does not seem to be > > > the case any more. > > > Previous behaviour also assigned a default password, and that also does > > > not > > > happen any more. > > > Result is staff have to add three fields, making them unique/matching, > > > even > > > if the patron does not want an online account. > > > Looking forward to this being non-mandatory! Thanks. > > > > Hi Agnes, please fill a bug report about user names not generated. > > Will test further and submit a new bug for Koha not auto-generating username > & password. It seems that resolving bug 19908 will probably fix the auto-generating username and password issue. They were generated when a new record was saved. Mandatory password prevented the save process. I believe this is why the username and password were never generated. Using a quick add without the password fields does allow save, and on reviewing the record, the username and password have been inserted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #27 from Agnes Rivers-Moore --- Will patches be issued for 17.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #26 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #25 from Agnes Rivers-Moore --- Bug 20378 created for Koha does not auto-generate OPAC ID and password. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #24 from Josef Moravec --- Switching back to Passed QA, see comment 20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #23 from Katrin Fischer --- Should this be assigned or another status? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #22 from Agnes Rivers-Moore --- (In reply to Josef Moravec from comment #21) > (In reply to Agnes Rivers-Moore from comment #17) > > Our Koha as of 17.11.03 does not generate default username for any patron > > type. > > Josef said 'Other categories (than org) have username generated as > > "firstname.surname" if you leave it blank' - but that does not seem to be > > the case any more. > > Previous behaviour also assigned a default password, and that also does not > > happen any more. > > Result is staff have to add three fields, making them unique/matching, even > > if the patron does not want an online account. > > Looking forward to this being non-mandatory! Thanks. > > Hi Agnes, please fill a bug report about user names not generated. Will test further and submit a new bug for Koha not auto-generating username & password. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #21 from Josef Moravec --- (In reply to Agnes Rivers-Moore from comment #17) > Our Koha as of 17.11.03 does not generate default username for any patron > type. > Josef said 'Other categories (than org) have username generated as > "firstname.surname" if you leave it blank' - but that does not seem to be > the case any more. > Previous behaviour also assigned a default password, and that also does not > happen any more. > Result is staff have to add three fields, making them unique/matching, even > if the patron does not want an online account. > Looking forward to this being non-mandatory! Thanks. Hi Agnes, please fill a bug report about user names not generated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Attachment #72189|0 |1 is obsolete|| Attachment #72190|0 |1 is obsolete|| --- Comment #18 from Josef Moravec --- Created attachment 72503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72503&action=edit Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference Test plan: 0) Do not apply the patch, note the password field is always required 1) Apply the patch 2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting 3) Use "Change password" button in patron toolbar, the password field should be never required here - when leaved blank, the password is unchanged 4) Play with minPasswordLength and RequireStrongPassword preferences, to ensure they work as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #20 from Josef Moravec --- (In reply to Jonathan Druart from comment #16) > We should apply the same fix at the OPAC, right? > > Please fix bug number on the second patch. Bug number fixed. Where in OPAC do you think? On change password page it doesn't make sense for me and on self registration, the password field is not required a if leaved blanked, the password is generated, which is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #19 from Josef Moravec --- Created attachment 72504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72504&action=edit Bug 19908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #17 from Agnes Rivers-Moore --- Our Koha as of 17.11.03 does not generate default username for any patron type. Josef said 'Other categories (than org) have username generated as "firstname.surname" if you leave it blank' - but that does not seem to be the case any more. Previous behaviour also assigned a default password, and that also does not happen any more. Result is staff have to add three fields, making them unique/matching, even if the patron does not want an online account. Looking forward to this being non-mandatory! Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #16 from Jonathan Druart --- We should apply the same fix at the OPAC, right? Please fix bug number on the second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13655 --- Comment #15 from Katrin Fischer --- I was about to file a new bug for the problem with organisations, but then found it: bug 13655. I think this patch is important as a bugfix for stable releases so should not be blocked by old broken behavoiur. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Katrin Fischer changed: What|Removed |Added Attachment #72188|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 72190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72190&action=edit Bug 18908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank https://bugs.koha-community.org/show_bug.cgi?id=19908 Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Katrin Fischer changed: What|Removed |Added Attachment #71970|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 72189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72189&action=edit Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference Test plan: 0) Do not apply the patch, note the password field is always required 1) Apply the patch 2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting 3) Use "Change password" button in patron toolbar, the password field should be never required here - when leaved blank, the password is unchanged 4) Play with minPasswordLength and RequireStrongPassword preferences, to ensure they work as expected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Katrin Fischer changed: What|Removed |Added Attachment #72159|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 72188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72188&action=edit Bug 18908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank https://bugs.koha-community.org/show_bug.cgi?id=19908 Signed-off-by: Roch D'Amour Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Roch D'Amour changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Roch D'Amour changed: What|Removed |Added Attachment #71971|0 |1 is obsolete|| --- Comment #11 from Roch D'Amour --- Created attachment 72159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72159&action=edit Bug 18908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank https://bugs.koha-community.org/show_bug.cgi?id=19908 Signed-off-by: Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Roch D'Amour changed: What|Removed |Added CC||roch.dam...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #10 from Josef Moravec --- rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #9 from Josef Moravec --- Created attachment 71971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71971&action=edit Bug 18908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Attachment #70242|0 |1 is obsolete|| Attachment #71217|0 |1 is obsolete|| --- Comment #8 from Josef Moravec --- Created attachment 71970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71970&action=edit Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference Test plan: 0) Do not apply the patch, note the password field is always required 1) Apply the patch 2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting 3) Use "Change password" button in patron toolbar, the password field should be never required here - when leaved blank, the password is unchanged 4) Play with minPasswordLength and RequireStrongPassword preferences, to ensure they work as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Josef Moravec --- (In reply to Claire Gravely from comment #5) > Hi, > > I got as far as applying the first patch to test. > BorrowerMandatoryField is empty > > I was unable to save the patron record without entering a username. I get > the following message: > > The following fields are wrong. Please fix them. > - Username/password already exists. > > It will not let me save until I have entered a username for the patron. > Previous behaviour was that one was automatically generated if left blank. That is bug in master too and not related to this bug. Other categories have username generated as "firstname.surname" if you leave it blank, but organization not and when you have any patron with userid=null in db, koha thinks its duplicate and you can't save it. But out of scope of this bug report i think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #6 from Claire Gravely --- (In reply to Claire Gravely from comment #5) > Hi, > > I got as far as applying the first patch to test. > BorrowerMandatoryField is empty > > I was unable to save the patron record without entering a username. I get > the following message: > > The following fields are wrong. Please fix them. > - Username/password already exists. > > It will not let me save until I have entered a username for the patron. > Previous behaviour was that one was automatically generated if left blank. Sorry, should add this was for patron categories with type Org. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Claire Gravely changed: What|Removed |Added CC||claire_grav...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Claire Gravely --- Hi, I got as far as applying the first patch to test. BorrowerMandatoryField is empty I was unable to save the patron record without entering a username. I get the following message: The following fields are wrong. Please fix them. - Username/password already exists. It will not let me save until I have entered a username for the patron. Previous behaviour was that one was automatically generated if left blank. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #4 from Josef Moravec --- (In reply to Jonathan Druart from comment #2) > On members/member-password.pl I can submit the form without confirming the > password. Should be fixed by this second patch. This is restoring the original behavior, but there is still room for imporvements: It is not possible to change only userid from here. When you submit the blank passwords, then you get the same form again - not very useful I think. So probably adding the ability to change only userid from here would be nice enhancement here I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #3 from Josef Moravec --- Created attachment 71217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71217&action=edit Bug 18908: Do not use .optional in password match validation function Test plan: 0) Aplly only first patch 1) You will be able to submit a from on member-password.pl even if the passwords don't match 2) Apply this patch -> you can't be able to submit the form if the paswords don't match, but you'll be able to submit the form when password fields are blank -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 acoval...@gmail.com changed: What|Removed |Added CC||acoval...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Bob Ewart changed: What|Removed |Added CC||bob-ew...@bobsown.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 tmcma...@wlpl.org changed: What|Removed |Added CC||tmcma...@wlpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- On members/member-password.pl I can submit the form without confirming the password. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Blocks||19907 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 [Bug 19907] Email validation on patron add/edit not working -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 --- Comment #1 from Josef Moravec --- Created attachment 70242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70242&action=edit Bug 19908: Password fields in edit/add patron form should respect BorrowerMandatoryField preference Test plan: 0) Do not apply the patch, note the password field is always required 1) Apply the patch 2) Try to add and edit patron with and without "password" in BorrowerMandatoryField, it should always respect this setting 3) Use "Change password" button in patron toolbar, the password field should be never required here - when leaved blank, the password is unchanged 4) Play with minPasswordLength and RequireStrongPassword preferences, to ensure they work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19908] Password should not be mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Depends on||18298 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 [Bug 18298] Allow enforcing password complexity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
