[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936
Bug 19936 depends on bug 12001, which changed state.

Bug 12001 Summary: GetMemberAccountRecords slows down display of patron details 
and checkout pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #89 from Jonathan Druart  
---
(In reply to Liz Rea from comment #87)
> Since this patch trying to import patrons seems to be noisy, lots of

You did not tell if you were using the UI of the command line script (I tried
with both).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-06-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #88 from Jonathan Druart  
---
Hi Liz,

I have tried with your line (with sample data, replaced "STAFF" with "S" and
"BRANCHCODE" with "CPL", I have also created the patron's attribute "GROUP").

I see these 2 lines:
Use of uninitialized value $uploadborrowers in concatenation (.) or string at
/home/vagrant/kohaclone/tools/import_borrowers.pl line 109.

CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_tools_import_borrowers_2epl line
123, this can lead to vulnerabilities. See the warning in "Fetching the value
or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.

But not the one you are referring to.
Let me know if you have more detail to provide and if you recreate on a devbox,
or with the sample data.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-06-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #87 from Liz Rea  ---
Since this patch trying to import patrons seems to be noisy, lots of

Argument "" isn't numeric in numeric eq (==) at
/usr/share/perl5/DBIx/Class/Row.pm line 1017, <$handle> line 512.

example line that has this problem, with header, private stuff removed:
cardnumber,firstname,surname,address,address2,city,zipcode,email,phone,B_phone,branchcode,patron_attributes,borrowernotes,categorycode
10090,"borrower surname",firstname,"Po Box x","
City",,,firstname.surn...@institution.co.nz,,123456,BRANCHCODE,GROUP:STAFF,,STAFF

It doesn't seem to affect the performance, patrons still get imported, but it
sure does fill up the logs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-05-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED
 CC||n...@bywatersolutions.com

--- Comment #86 from Nick Clemens  ---
Enhancement, not backported for 17.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #85 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #84 from Katrin Fischer  ---
Preserves current behaviour - including remaining bugs :D (bug 13655)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73974|0   |1
is obsolete||

--- Comment #83 from Katrin Fischer  ---
Created attachment 74082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74082=edit
Bug 19936: Reuse existing userid if none provided

Found this regression when working on other patches:
If you edit a patron and blank the userid field, it will be regenerated
with an incremented value (firstname.surname will be firstname.surname1)

This is because we use a non-existing patron and ->in_storage in
has_valid_userid is always false.
The trick here is to backup the value, generate the userid, then reset
userid to the previous value.

As the POD says, it will be fix later, when AddMember and ModMember will
be replaced with Koha::Patron->store

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #82 from Katrin Fischer  ---
Created attachment 74081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74081=edit
Bug 19936: Replace Check_userid - Update the occurrences

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73971|0   |1
is obsolete||

--- Comment #80 from Katrin Fischer  ---
Created attachment 74079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74079=edit
Bug 19936: Remove the subroutine Generate_Userid

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73972|0   |1
is obsolete||

--- Comment #81 from Katrin Fischer  ---
Created attachment 74080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74080=edit
Bug 19936: Remove warnings from tests

C4::Members did not "use warnings;"

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73965|0   |1
is obsolete||
  Attachment #73973|0   |1
is obsolete||

--- Comment #74 from Katrin Fischer  ---
Created attachment 74073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74073=edit
Bug 19936: Replace Check_userid - Update the occurrences

We previously prove that the method and the subroutine were equivalent,
we know update the controller calls.

Test plan:
- Add and update a patron with different variations of userid
(automatically generated or not)
- Import patrons with and without userid, as well as with existing
userid

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73968|0   |1
is obsolete||

--- Comment #77 from Katrin Fischer  ---
Created attachment 74076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74076=edit
Bug 19936: Add the Koha::Patron->generate_userid method

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73964|0   |1
is obsolete||

--- Comment #73 from Katrin Fischer  ---
Created attachment 74072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74072=edit
Bug 19936: Add the Koha::Patron->has_valid_userid method

Reuse how C4::Members::Check_Userid works and adapt it to write
Koha::Patron->check_userid
Adapt the tests to use this new method.
The tests still pass, we can adapt the different callers

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73970|0   |1
is obsolete||

--- Comment #79 from Katrin Fischer  ---
Created attachment 74078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74078=edit
Bug 19936: Replace Generate_Userid - Update the occurrences

Test plan:
Same test plan as previous patch:
add/update/import patrons and watch the userid

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73969|0   |1
is obsolete||

--- Comment #78 from Katrin Fischer  ---
Created attachment 74077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74077=edit
Bug 19936: Adapt tests

And prove that we are not cheating

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73966|0   |1
is obsolete||

--- Comment #75 from Katrin Fischer  ---
Created attachment 74074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74074=edit
Bug 19936: Remove the subroutine Check_Userid

It is no longer in user, we can remove it.

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73963|0   |1
is obsolete||

--- Comment #72 from Katrin Fischer  ---
Created attachment 74071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74071=edit
Bug 19936: Replace Check_userid - just move the tests

This patch moves the tests related to Check_userid out of Members.t
The tests must pass with only this patch applied

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73967|0   |1
is obsolete||

--- Comment #76 from Katrin Fischer  ---
Created attachment 74075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74075=edit
Bug 19936: Move and add tests for Generate_Userid

Signed-off-by: Josef Moravec 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||13655


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13655
[Bug 13655] Can't save organisation type patron without entering
userid/password
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
 CC||katrin.fisc...@bsz-bw.de

--- Comment #71 from Katrin Fischer  ---
Giving this a try.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #67 from Josef Moravec  ---
Created attachment 73971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73971=edit
Bug 19936: Remove the subroutine Generate_Userid

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #66 from Josef Moravec  ---
Created attachment 73970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73970=edit
Bug 19936: Replace Generate_Userid - Update the occurrences

Test plan:
Same test plan as previous patch:
add/update/import patrons and watch the userid

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #62 from Josef Moravec  ---
Created attachment 73966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73966=edit
Bug 19936: Remove the subroutine Check_Userid

It is no longer in user, we can remove it.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #69 from Josef Moravec  ---
Created attachment 73973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73973=edit
Bug 19936: Replace Check_userid - Update the occurrences

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #63 from Josef Moravec  ---
Created attachment 73967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73967=edit
Bug 19936: Move and add tests for Generate_Userid

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #68 from Josef Moravec  ---
Created attachment 73972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73972=edit
Bug 19936: Remove warnings from tests

C4::Members did not "use warnings;"

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #70 from Josef Moravec  ---
Created attachment 73974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73974=edit
Bug 19936: Reuse existing userid if none provided

Found this regression when working on other patches:
If you edit a patron and blank the userid field, it will be regenerated
with an incremented value (firstname.surname will be firstname.surname1)

This is because we use a non-existing patron and ->in_storage in
has_valid_userid is always false.
The trick here is to backup the value, generate the userid, then reset
userid to the previous value.

As the POD says, it will be fix later, when AddMember and ModMember will
be replaced with Koha::Patron->store

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #60 from Josef Moravec  ---
Created attachment 73964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73964=edit
Bug 19936: Add the Koha::Patron->has_valid_userid method

Reuse how C4::Members::Check_Userid works and adapt it to write
Koha::Patron->check_userid
Adapt the tests to use this new method.
The tests still pass, we can adapt the different callers

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #64 from Josef Moravec  ---
Created attachment 73968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73968=edit
Bug 19936: Add the Koha::Patron->generate_userid method

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #65 from Josef Moravec  ---
Created attachment 73969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73969=edit
Bug 19936: Adapt tests

And prove that we are not cheating

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #61 from Josef Moravec  ---
Created attachment 73965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73965=edit
Bug 19936: Replace Check_userid - Update the occurrences

We previously prove that the method and the subroutine were equivalent,
we know update the controller calls.

Test plan:
- Add and update a patron with different variations of userid
(automatically generated or not)
- Import patrons with and without userid, as well as with existing
userid

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Josef Moravec  changed:

   What|Removed |Added

  Attachment #73630|0   |1
is obsolete||
  Attachment #73631|0   |1
is obsolete||
  Attachment #73632|0   |1
is obsolete||
  Attachment #73633|0   |1
is obsolete||
  Attachment #73634|0   |1
is obsolete||
  Attachment #73635|0   |1
is obsolete||
  Attachment #73636|0   |1
is obsolete||
  Attachment #73637|0   |1
is obsolete||
  Attachment #73638|0   |1
is obsolete||
  Attachment #73639|0   |1
is obsolete||
  Attachment #73640|0   |1
is obsolete||
  Attachment #73641|0   |1
is obsolete||

--- Comment #59 from Josef Moravec  ---
Created attachment 73963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73963=edit
Bug 19936: Replace Check_userid - just move the tests

This patch moves the tests related to Check_userid out of Members.t
The tests must pass with only this patch applied

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #55 from Jonathan Druart  
---
Created attachment 73638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73638=edit
Bug 19936: Remove the subroutine Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #57 from Jonathan Druart  
---
Created attachment 73640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73640=edit
Bug 19936: Replace Check_userid - Update the occurrences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #56 from Jonathan Druart  
---
Created attachment 73639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73639=edit
Bug 19936: Remove warnings from tests

C4::Members did not "use warnings;"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #58 from Jonathan Druart  
---
Created attachment 73641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73641=edit
Bug 19936: Reuse existing userid if none provided

Found this regression when working on other patches:
If you edit a patron and blank the userid field, it will be regenerated
with an incremented value (firstname.surname will be firstname.surname1)

This is because we use a non-existing patron and ->in_storage in
has_valid_userid is always false.
The trick here is to backup the value, generate the userid, then reset
userid to the previous value.

As the POD says, it will be fix later, when AddMember and ModMember will
be replaced with Koha::Patron->store

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #53 from Jonathan Druart  
---
Created attachment 73636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73636=edit
Bug 19936: Adapt tests

And prove that we are not cheating

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #52 from Jonathan Druart  
---
Created attachment 73635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73635=edit
Bug 19936: Add the Koha::Patron->generate_userid method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #54 from Jonathan Druart  
---
Created attachment 73637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73637=edit
Bug 19936: Replace Generate_Userid - Update the occurrences

Test plan:
Same test plan as previous patch:
add/update/import patrons and watch the userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #51 from Jonathan Druart  
---
Created attachment 73634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73634=edit
Bug 19936: Move and add tests for Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72141|0   |1
is obsolete||
  Attachment #72142|0   |1
is obsolete||
  Attachment #72143|0   |1
is obsolete||
  Attachment #72144|0   |1
is obsolete||
  Attachment #72145|0   |1
is obsolete||
  Attachment #72146|0   |1
is obsolete||
  Attachment #72147|0   |1
is obsolete||
  Attachment #72148|0   |1
is obsolete||
  Attachment #72149|0   |1
is obsolete||
  Attachment #72150|0   |1
is obsolete||
  Attachment #72151|0   |1
is obsolete||
  Attachment #72152|0   |1
is obsolete||

--- Comment #47 from Jonathan Druart  
---
Created attachment 73630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73630=edit
Bug 19936: Replace Check_userid - just move the tests

This patch moves the tests related to Check_userid out of Members.t
The tests must pass with only this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #49 from Jonathan Druart  
---
Created attachment 73632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73632=edit
Bug 19936: Replace Check_userid - Update the occurrences

We previously prove that the method and the subroutine were equivalent,
we know update the controller calls.

Test plan:
- Add and update a patron with different variations of userid
(automatically generated or not)
- Import patrons with and without userid, as well as with existing
userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #50 from Jonathan Druart  
---
Created attachment 73633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73633=edit
Bug 19936: Remove the subroutine Check_Userid

It is no longer in user, we can remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #48 from Jonathan Druart  
---
Created attachment 73631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73631=edit
Bug 19936: Add the Koha::Patron->has_valid_userid method

Reuse how C4::Members::Check_Userid works and adapt it to write
Koha::Patron->check_userid
Adapt the tests to use this new method.
The tests still pass, we can adapt the different callers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||josef.mora...@gmail.com

--- Comment #46 from Josef Moravec  ---
Sorry, could you rebase please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936
Bug 19936 depends on bug 12001, which changed state.

Bug 12001 Summary: GetMemberAccountRecords slows down display of patron details 
and checkout pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #45 from Jonathan Druart  
---
Rebased on top of bug 12001

+ 2 bugs fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||12001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001
[Bug 12001] GetMemberAccountRecords slows down display of patron details and
checkout pages
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #44 from Jonathan Druart  
---
Created attachment 72152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72152=edit
Bug 19936: Reuse existing userid if none provided

Found this regression when working on other patches:
If you edit a patron and blank the userid field, it will be regenerated
with an incremented value (firstname.surname will be firstname.surname1)

This is because we use a non-existing patron and ->in_storage in
has_valid_userid is always false.
The trick here is to backup the value, generate the userid, then reset
userid to the previous value.

As the POD says, it will be fix later, when AddMember and ModMember will
be replaced with Koha::Patron->store

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #43 from Jonathan Druart  
---
Created attachment 72151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72151=edit
Bug 19936: (follow-up) Replace Check_userid - Update the occurrences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #38 from Jonathan Druart  
---
Created attachment 72146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72146=edit
Bug 19936: Add the Koha::Patron->generate_userid method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #42 from Jonathan Druart  
---
Created attachment 72150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72150=edit
Bug 19936: Remove warnings from tests

C4::Members did not "use warnings;"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #36 from Jonathan Druart  
---
Created attachment 72144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72144=edit
Bug 19936: Remove the subroutine Check_Userid

It is no longer in user, we can remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #41 from Jonathan Druart  
---
Created attachment 72149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72149=edit
Bug 19936: Remove the subroutine Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #34 from Jonathan Druart  
---
Created attachment 72142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72142=edit
Bug 19936: Add the Koha::Patron->has_valid_userid method

Reuse how C4::Members::Check_Userid works and adapt it to write
Koha::Patron->check_userid
Adapt the tests to use this new method.
The tests still pass, we can adapt the different callers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #39 from Jonathan Druart  
---
Created attachment 72147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72147=edit
Bug 19936: Adapt tests

And prove that we are not cheating

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #40 from Jonathan Druart  
---
Created attachment 72148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72148=edit
Bug 19936: Replace Generate_Userid - Update the occurrences

Test plan:
Same test plan as previous patch:
add/update/import patrons and watch the userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72129|0   |1
is obsolete||
  Attachment #72130|0   |1
is obsolete||
  Attachment #72131|0   |1
is obsolete||
  Attachment #72132|0   |1
is obsolete||
  Attachment #72133|0   |1
is obsolete||
  Attachment #72134|0   |1
is obsolete||
  Attachment #72135|0   |1
is obsolete||
  Attachment #72136|0   |1
is obsolete||
  Attachment #72137|0   |1
is obsolete||
  Attachment #72138|0   |1
is obsolete||
  Attachment #72139|0   |1
is obsolete||
  Attachment #72140|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart  
---
Created attachment 72141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72141=edit
Bug 19936: Replace Check_userid - just move the tests

This patch moves the tests related to Check_userid out of Members.t
The tests must pass with only this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #37 from Jonathan Druart  
---
Created attachment 72145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72145=edit
Bug 19936: Move and add tests for Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #35 from Jonathan Druart  
---
Created attachment 72143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72143=edit
Bug 19936: Replace Check_userid - Update the occurrences

We previously prove that the method and the subroutine were equivalent,
we know update the controller calls.

Test plan:
- Add and update a patron with different variations of userid
(automatically generated or not)
- Import patrons with and without userid, as well as with existing
userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #32 from Jonathan Druart  
---
Created attachment 72140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72140=edit
Bug 19936: Fix number of tests

will be squashed later, but lazy to reupload the whole patchset

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #30 from Jonathan Druart  
---
Created attachment 72138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72138=edit
Bug 19936: Remove warnings from tests

C4::Members did not "use warnings;"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #31 from Jonathan Druart  
---
Created attachment 72139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72139=edit
Bug 19936: Reuse existing userid if none provided

Found this regression when working on other patches:
If you edit a patron and blank the userid field, it will be regenerated
with an incremented value (firstname.surname will be firstname.surname1)

This is because we use a non-existing patron and ->in_storage in
has_valid_userid is always false.
The trick here is to backup the value, generate the userid, then reset
userid to the previous value.

As the POD says, it will be fix later, when AddMember and ModMember will
be replaced with Koha::Patron->store

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #29 from Jonathan Druart  
---
Created attachment 72137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72137=edit
Bug 19936: Remove the subroutine Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #25 from Jonathan Druart  
---
Created attachment 72133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72133=edit
Bug 19936: Move and add tests for Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #28 from Jonathan Druart  
---
Created attachment 72136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72136=edit
Bug 19936: Replace Generate_Userid - Update the occurrences

Test plan:
Same test plan as previous patch:
add/update/import patrons and watch the userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #71787|0   |1
is obsolete||
  Attachment #71788|0   |1
is obsolete||
  Attachment #71789|0   |1
is obsolete||
  Attachment #71790|0   |1
is obsolete||
  Attachment #71791|0   |1
is obsolete||
  Attachment #71792|0   |1
is obsolete||
  Attachment #71793|0   |1
is obsolete||
  Attachment #71794|0   |1
is obsolete||
  Attachment #71795|0   |1
is obsolete||
  Attachment #71796|0   |1
is obsolete||

--- Comment #21 from Jonathan Druart  
---
Created attachment 72129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72129=edit
Bug 19936: Replace Check_userid - just move the tests

This patch moves the tests related to Check_userid out of Members.t
The tests must pass with only this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #26 from Jonathan Druart  
---
Created attachment 72134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72134=edit
Bug 19936: Add the Koha::Patron->generate_userid method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #27 from Jonathan Druart  
---
Created attachment 72135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72135=edit
Bug 19936: Adapt tests

And prove that we are not cheating

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #24 from Jonathan Druart  
---
Created attachment 72132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72132=edit
Bug 19936: Remove the subroutine Check_Userid

It is no longer in user, we can remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #22 from Jonathan Druart  
---
Created attachment 72130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72130=edit
Bug 19936: Add the Koha::Patron->has_valid_userid method

Reuse how C4::Members::Check_Userid works and adapt it to write
Koha::Patron->check_userid
Adapt the tests to use this new method.
The tests still pass, we can adapt the different callers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #23 from Jonathan Druart  
---
Created attachment 72131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72131=edit
Bug 19936: Replace Check_userid - Update the occurrences

We previously prove that the method and the subroutine were equivalent,
we know update the controller calls.

Test plan:
- Add and update a patron with different variations of userid
(automatically generated or not)
- Import patrons with and without userid, as well as with existing
userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #20 from Jonathan Druart  
---
Created attachment 71796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71796=edit
Bug 19936: Remove warnings from tests

C4::Members did not "use warnings;"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #19 from Jonathan Druart  
---
Created attachment 71795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71795=edit
Bug 19936: Remove the subroutine Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #13 from Jonathan Druart  
---
Created attachment 71789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71789=edit
Bug 19936: Replace Check_userid - Update the occurrences

We previously prove that the method and the subroutine were equivalent,
we know update the controller calls.

Test plan:
- Add and update a patron with different variations of userid
(automatically generated or not)
- Import patrons with and without userid, as well as with existing
userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #18 from Jonathan Druart  
---
Created attachment 71794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71794=edit
Bug 19936: Replace Generate_Userid - Update the occurrences

Test plan:
Same test plan as previous patch:
add/update/import patrons and watch the userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #12 from Jonathan Druart  
---
Created attachment 71788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71788=edit
Bug 19936: Add the Koha::Patron->has_valid_userid method

Reuse how C4::Members::Check_Userid works and adapt it to write
Koha::Patron->check_userid
Adapt the tests to use this new method.
The tests still pass, we can adapt the different callers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #14 from Jonathan Druart  
---
Created attachment 71790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71790=edit
Bug 19936: Remove the subroutine Check_Userid

It is no longer in user, we can remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #17 from Jonathan Druart  
---
Created attachment 71793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71793=edit
Bug 19936: Adapt tests

And prove that we are not cheating

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #16 from Jonathan Druart  
---
Created attachment 71792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71792=edit
Bug 19936: Add the Koha::Patron->generate_userid method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #15 from Jonathan Druart  
---
Created attachment 71791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71791=edit
Bug 19936: Move and add tests for Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #70365|0   |1
is obsolete||
  Attachment #70366|0   |1
is obsolete||
  Attachment #70367|0   |1
is obsolete||
  Attachment #70368|0   |1
is obsolete||
  Attachment #70369|0   |1
is obsolete||
  Attachment #70370|0   |1
is obsolete||
  Attachment #70371|0   |1
is obsolete||
  Attachment #70372|0   |1
is obsolete||
  Attachment #70373|0   |1
is obsolete||
  Attachment #70374|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 71787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71787=edit
Bug 19936: Replace Check_userid - just move the tests

This patch moves the tests related to Check_userid out of Members.t
The tests must pass with only this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-02-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16846


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
[Bug 16846] Move patron related code to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #8 from Jonathan Druart  
---
Created attachment 70372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70372=edit
Bug 19936: Replace Generate_Userid - Update the occurrences

Test plan:
Same test plan as previous patch:
add/update/import patrons and watch the userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #10 from Jonathan Druart  
---
Created attachment 70374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70374=edit
Bug 19936: Remove warnings from tests

C4::Members did not "use warnings;"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #7 from Jonathan Druart  
---
Created attachment 70371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70371=edit
Bug 19936: Adapt tests

And prove that we are not cheating

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #5 from Jonathan Druart  
---
Created attachment 70369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70369=edit
Bug 19936: Move and add tests for Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #1 from Jonathan Druart  
---
Created attachment 70365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70365=edit
Bug 19936: Replace Check_userid - just move the tests

This patch moves the tests related to Check_userid out of Members.t
The tests must pass with only this patch applied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #4 from Jonathan Druart  
---
Created attachment 70368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70368=edit
Bug 19936: Remove the subroutine Check_Userid

It is no longer in user, we can remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #6 from Jonathan Druart  
---
Created attachment 70370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70370=edit
Bug 19936: Add the Koha::Patron->generate_userid method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #2 from Jonathan Druart  
---
Created attachment 70366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70366=edit
Bug 19936: Add the Koha::Patron->has_valid_userid method

Reuse how C4::Members::Check_Userid works and adapt it to write
Koha::Patron->check_userid
Adapt the tests to use this new method.
The tests still pass, we can adapt the different callers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #3 from Jonathan Druart  
---
Created attachment 70367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70367=edit
Bug 19936: Replace Check_userid - Update the occurrences

We previously prove that the method and the subroutine were equivalent,
we know update the controller calls.

Test plan:
- Add and update a patron with different variations of userid
(automatically generated or not)
- Import patrons with and without userid, as well as with existing
userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron

2018-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936

--- Comment #9 from Jonathan Druart  
---
Created attachment 70373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70373=edit
Bug 19936: Remove the subroutine Generate_Userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >